Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • 16:04
    jeffwadsworth labeled #6220
  • 16:03
    jeffwadsworth commented #6220
  • 10:47
    JayDi85 closed #6215
  • 10:47
    JayDi85 commented #6215
  • 10:46

    JayDi85 on master

    * Bolas's Citadel - fixed that … (compare)

  • 08:47
    JayDi85 assigned #6215
  • 08:33
    JayDi85 edited #6169
  • 08:33

    JayDi85 on master

    * War's Toll - fixed that is ap… (compare)

  • 07:55
    Zechr opened #6220
  • 07:00

    JayDi85 on master

    Code cleanup (compare)

  • 06:34

    JayDi85 on master

    Extractor Demon Text Fixes Merge pull request #6219 from E… (compare)

  • 06:34
    JayDi85 closed #6219
  • 06:32
    JayDi85 closed #3129
  • 06:32
    JayDi85 commented #3129
  • 06:23
    JayDi85 commented #5155
  • 06:18
    Ebola16 opened #6219
  • 06:08
    JayDi85 closed #2412
  • 06:08
    JayDi85 commented #2412
  • 06:06
    JayDi85 closed #2444
  • 06:06
    JayDi85 commented #2444
Evan Kranzler
@theelk801
because it usually is
except here it isn't
but it's hard to figure out what does and doesn't need to be changed
also Vivien, Arkbow Ranger can target "up to" 2 target creatures, which is also different since distribution effects usually require at least one target
Oleg Agafonov
@JayDi85
@theelk801 it's already have maxNumberOfTargets
Oleg Agafonov
@JayDi85
You can setup it in cards and improve code in TargetAnyTargetAmount to implement support of that limit in maxNumberOfTargets
Oleg Agafonov
@JayDi85
shot_190924_060240.png
shot_190924_060317.png
shot_190924_060404.png
Just add support of maxNumberOfTargets as example above -- that's all.
Evan Kranzler
@theelk801
wow
that's it
thank you
Evan Kranzler
@theelk801
so I'm testing it, and it doesn't work
doesn't prevent you from choosing more than the maximum amount
Oleg Agafonov
@JayDi85
You must add same code in all other places like possibleTargets, canChoose, etc
canTarget, canChoose, possibleTargets
Evan Kranzler
@theelk801
alright
so just add if (getMaxNumberOfTargets() > 0 && getTargets().size() >= getMaxNumberOfTargets()) {return false;}to the boolean methods?
Oleg Agafonov
@JayDi85
nope
you can choose already choosen
if... return getTargets.contain(objectId)
Evan Kranzler
@theelk801
ah ok
do that for both boolean methods?
Oleg Agafonov
@JayDi85
yearh
hmm
Evan Kranzler
@theelk801
wait, for canChoose
don't I just return false there?
Oleg Agafonov
@JayDi85
I don't think so... if you reach max limit then you can choose between already selected, but not new
Evan Kranzler
@theelk801
do you mind implementing the changes and pushing them?
Oleg Agafonov
@JayDi85
nope, thats for you)
but canTarget code... you must test (is it need limit code or not)
Evan Kranzler
@theelk801
I implemented the changes you suggested but I can still select more than the maximum
Oleg Agafonov
@JayDi85
well, then I'll debug it later
it's can be canTarget problem
Evan Kranzler
@theelk801
I'm going to bed
but thanks for the help
Oleg Agafonov
@JayDi85
TargetAmout was improved by magefree/mage@bad26b1
Fenhl
@fenhl
hey, where are the XMage client preferences stored?
Fenhl
@fenhl
ah, found it (for Windows, in the registry at Computer\HKEY_CURRENT_USER\Software\JavaSoft\Prefs\mage\client)
Evan Kranzler
@theelk801
@JayDi85 awesome, thanks again for doing that
Zach H
@ZeldaZach
You got it working?
Evan Kranzler
@theelk801
yeah he made it work
although I need to apply the changes to TargetCreaturePermanentAmount so I can finally implement Forked Lightning
Fenhl
@fenhl
hey, what's the opinion on custom sets here?
there's that Star Wars set, but I'm considering XMage for a custom format with multiple sets
and I'm wondering if that's something that could go in the main repo or if a fork would be better
Zach H
@ZeldaZach
Probably a fork
That’s not really official and most people won’t want non official cards
Fenhl
@fenhl
XMage already has unofficial cards