Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • 17:28
    jeffwadsworth closed #6208
  • 17:27
    jeffwadsworth commented #6208
  • 17:27
    jeffwadsworth unlabeled #6208
  • 17:09
    jeffwadsworth closed #6220
  • 17:09

    jeffwadsworth on master

    - Fixed #6220 (compare)

  • 17:05
    jeffwadsworth assigned #6220
  • 16:47
    jeffwadsworth commented #6220
  • 16:44
    jeffwadsworth commented #6220
  • 16:23
    jeffwadsworth unlabeled #6220
  • 16:23
    jeffwadsworth commented #6220
  • 16:22
    jeffwadsworth commented #6220
  • 15:42
    jeffwadsworth commented #6220
  • 15:42
    jeffwadsworth labeled #6220
  • 15:36

    jeffwadsworth on master

    - Added some extra log clarity … (compare)

  • 14:18

    JayDi85 on master

    Update TaintedPact.java Merge pull request #6224 from b… (compare)

  • 14:18
    JayDi85 closed #6224
  • 14:15
    brookeburkett opened #6224
  • 06:31
    Zechr commented #6220
  • Jan 23 22:26
    JayDi85 edited #6169
  • Jan 23 22:26
    jeffwadsworth labeled #6223
Oleg Agafonov
@JayDi85
@theelk801 it's already have maxNumberOfTargets
Oleg Agafonov
@JayDi85
You can setup it in cards and improve code in TargetAnyTargetAmount to implement support of that limit in maxNumberOfTargets
Oleg Agafonov
@JayDi85
shot_190924_060240.png
shot_190924_060317.png
shot_190924_060404.png
Just add support of maxNumberOfTargets as example above -- that's all.
Evan Kranzler
@theelk801
wow
that's it
thank you
Evan Kranzler
@theelk801
so I'm testing it, and it doesn't work
doesn't prevent you from choosing more than the maximum amount
Oleg Agafonov
@JayDi85
You must add same code in all other places like possibleTargets, canChoose, etc
canTarget, canChoose, possibleTargets
Evan Kranzler
@theelk801
alright
so just add if (getMaxNumberOfTargets() > 0 && getTargets().size() >= getMaxNumberOfTargets()) {return false;}to the boolean methods?
Oleg Agafonov
@JayDi85
nope
you can choose already choosen
if... return getTargets.contain(objectId)
Evan Kranzler
@theelk801
ah ok
do that for both boolean methods?
Oleg Agafonov
@JayDi85
yearh
hmm
Evan Kranzler
@theelk801
wait, for canChoose
don't I just return false there?
Oleg Agafonov
@JayDi85
I don't think so... if you reach max limit then you can choose between already selected, but not new
Evan Kranzler
@theelk801
do you mind implementing the changes and pushing them?
Oleg Agafonov
@JayDi85
nope, thats for you)
but canTarget code... you must test (is it need limit code or not)
Evan Kranzler
@theelk801
I implemented the changes you suggested but I can still select more than the maximum
Oleg Agafonov
@JayDi85
well, then I'll debug it later
it's can be canTarget problem
Evan Kranzler
@theelk801
I'm going to bed
but thanks for the help
Oleg Agafonov
@JayDi85
TargetAmout was improved by magefree/mage@bad26b1
Fenhl
@fenhl
hey, where are the XMage client preferences stored?
Fenhl
@fenhl
ah, found it (for Windows, in the registry at Computer\HKEY_CURRENT_USER\Software\JavaSoft\Prefs\mage\client)
Evan Kranzler
@theelk801
@JayDi85 awesome, thanks again for doing that
Zach H
@ZeldaZach
You got it working?
Evan Kranzler
@theelk801
yeah he made it work
although I need to apply the changes to TargetCreaturePermanentAmount so I can finally implement Forked Lightning
Fenhl
@fenhl
hey, what's the opinion on custom sets here?
there's that Star Wars set, but I'm considering XMage for a custom format with multiple sets
and I'm wondering if that's something that could go in the main repo or if a fork would be better
Zach H
@ZeldaZach
Probably a fork
That’s not really official and most people won’t want non official cards
Fenhl
@fenhl
XMage already has unofficial cards
Evan Kranzler
@theelk801
yeah we do have the star wars cards for some reason but adding new sets potentially leads to issues so we prefer not to
Fenhl
@fenhl
makes sense
are there any custom sets implemented in Java using the plugin system?
@Lymia has an example but it's in Scala which doesn't help much with copy/pasting card abilities