by

Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • 08:57
    JayDi85 commented #6190
  • 08:49
    luziferius commented #6190
  • 08:41
    JayDi85 synchronize #6190
  • 07:49
    JayDi85 synchronize #6190
  • 07:30
    JayDi85 synchronize #6190
  • 07:08
    JayDi85 synchronize #6190
  • 00:48
    JayDi85 synchronize #6190
  • Aug 06 23:59

    JayDi85 on master

    Tests: added verify test to che… (compare)

  • Aug 06 22:42
    JayDi85 commented #6872
  • Aug 06 22:41
    JayDi85 commented #6872
  • Aug 06 21:49

    jeffwadsworth on master

    - Added Cornered Market. (compare)

  • Aug 06 21:11
    jeffwadsworth edited #5229
  • Aug 06 21:07
    jeffwadsworth closed #6872
  • Aug 06 21:07

    jeffwadsworth on master

    - Fixed #6872. ¯\_(ツ)_/¯ (compare)

  • Aug 06 20:35
    jeffwadsworth assigned #6872
  • Aug 06 19:31
    JayDi85 commented #6939
  • Aug 06 19:31
    JayDi85 commented #6939
  • Aug 06 19:29
    JayDi85 commented #6939
  • Aug 06 19:09
    JayDi85 closed #3708
  • Aug 06 19:09
    JayDi85 commented #3708
Evan Kranzler
@theelk801
but if you put them all into the same set file you end up with an issue due to single cards showing up more than once but the art shouldn't be "various" since people will want to use one or another
Zach H
@ZeldaZach
Can do what you do with Strip mine like things
Evan Kranzler
@theelk801
so as far as I know those cards pick a random art to use
but I'm not actually sure since I don't eat the dog food
Oleg Agafonov
@JayDi85
@theelk801 maybe it's scryfall error and they fix it later (move collectors to another set).
You don't need to fix various logic -- it's ok (select random card from multiple image). Images download can be fixed like old promos cards -- buy direct images download links (e.g. collectors saved as CELD set).
Evan Kranzler
@theelk801
it's not a mistake, they're doing it on purpose
Oleg Agafonov
@JayDi85
That's cards have different card numbers and can be downloaded by set code alias. All works fine now: magefree/mage@4dbc1aa
Evan Kranzler
@theelk801
alright, so leave CELD as is?
Oleg Agafonov
@JayDi85
Yes, it's ok with eld and celd.
Zach H
@ZeldaZach
MTGJSON and SF both moved away from CELD
as collector numbers are diff for diff printings
So we’re calling it one set
Adrian Petrescu
@apetresc
Does anyone actually chat on here?
Development questions, etc
Or is it purely like a news feed for the github repo
Evan Kranzler
@theelk801
people do chat on here
it's just not a constant feed
Adrian Petrescu
@apetresc
Ah okay, awesome
EikePeace
@EikePeace
So, Oko is bugged
His Elk ability stops working, after the player that used him is out of the game
Evan Kranzler
@theelk801
damn it
that's not exclusive to oko either
EikePeace
@EikePeace
And Kenrith seems bugged according to his text at least
Evan Kranzler
@theelk801
it's because the game gets rid of continuous effects associated with a given player
kenrith's already been fixed
EikePeace
@EikePeace
Not sure, if the fix is already implemented in the actual version
Ah okay :D
Evan Kranzler
@theelk801
yeah I'm not sure how to deal with the oko problem
Zach H
@ZeldaZach
Stupid idea: attach association to the targeted player. If oko targets your creature, act as if oko was used by that player
Evan Kranzler
@theelk801
@JayDi85 hey, I'm gonna try and fix the rankle problem soon, if I can I think we should do a new release
the problem is twofold- it seems that choosing "up to x" modes on triggered abilities doesn't work, but also there's no support for choosing zero modes
this also affects Ravager Wurm, which doesn't currently allow zero modes chosen
Michael Milton
@TMiguelT
Can anyone point me to where the AI is implemented? I can't find it in the repo
Oleg Agafonov
@JayDi85
@TMiguelT search ComputerPlayer7.java -- it's main AI with min-max logic (it's calcs battlefield score and chooses best actions tree to play -- only for current priority).
Michael Milton
@TMiguelT
Thanks! I'll have a look
Michael Milton
@TMiguelT
Ah I see, there's a Mage.Player.AIMCTS and a Mage.Player.AIMinimax
Oleg Agafonov
@JayDi85
@TMiguelT AIMCTS, AIMinimax -- it's old experimental code (some of that logic was implemented in main AI classes).
Michael Milton
@TMiguelT
Oh, but neither is actually used?
I was thinking about implementing MCTS but it seems someone has already tried (and failed)
Oleg Agafonov
@JayDi85
MCTS implemented in current ComputerPlayer version (decisions tree with best score selections).
Michael Milton
@TMiguelT
ComputerPlayer6/7 (one inherits from the other) seems to use a MinMax + AB Pruning style algorithm
And not MCTS
Though I admit I didn't read all 1000 lines
Adrian Petrescu
@apetresc
Hey @theelk801, I'm gonna try and take a serious stab at implementing Adventures tonight
Do you have any uncommitted progress, or just the CardImpl refactorings on that branch so far?
Evan Kranzler
@theelk801
I have some stuff stashed but none of it really matters
thanks, I really appreciate the help
Evan Kranzler
@theelk801
I would definitely focus on the casting part
even if the adventure ends up going to the graveyard it's not really the issue