by

Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Sep 18 18:00

    JayDi85 on master

    Fixed NPE on freeze fix in non … (compare)

  • Sep 18 14:50
    jeffwadsworth commented #7063
  • Sep 18 14:19

    LevelX2 on master

    * Some code cleanup. (compare)

  • Sep 18 14:15
    LevelX2 closed #7063
  • Sep 18 14:15

    LevelX2 on master

    * Some standardisation of dies … (compare)

  • Sep 18 13:23
    LevelX2 labeled #7063
  • Sep 18 13:22
    LevelX2 assigned #7063
  • Sep 18 11:19

    LevelX2 on master

    Create a test to verify Grim Ha… Merge pull request #7071 from D… (compare)

  • Sep 18 11:19
    LevelX2 closed #7071
  • Sep 18 11:19
    LevelX2 opened #7071
  • Sep 18 01:31
    Zerrisx edited #7046
  • Sep 18 01:31
    Zerrisx edited #7046
  • Sep 18 00:24
    Zerrisx edited #7046
  • Sep 18 00:05
    Zerrisx edited #7046
  • Sep 18 00:04

    theelk801 on master

    [ZNR] fixed an error with Nimbl… (compare)

  • Sep 17 23:44
    Zerrisx edited #7046
  • Sep 17 23:38
    Zerrisx closed #7050
  • Sep 17 23:38
    Zerrisx commented #7050
  • Sep 17 22:21

    theelk801 on master

    [ZNR] fixed Kazandu Mammoth boo… [ZNR] fixed Spikefield Hazard n… [ZNR] fixed missing target for … and 1 more (compare)

  • Sep 17 22:20
    theelk801 edited #7046
Oleg Agafonov
@JayDi85
@TMiguelT search ComputerPlayer7.java -- it's main AI with min-max logic (it's calcs battlefield score and chooses best actions tree to play -- only for current priority).
Michael Milton
@TMiguelT
Thanks! I'll have a look
Michael Milton
@TMiguelT
Ah I see, there's a Mage.Player.AIMCTS and a Mage.Player.AIMinimax
Oleg Agafonov
@JayDi85
@TMiguelT AIMCTS, AIMinimax -- it's old experimental code (some of that logic was implemented in main AI classes).
Michael Milton
@TMiguelT
Oh, but neither is actually used?
I was thinking about implementing MCTS but it seems someone has already tried (and failed)
Oleg Agafonov
@JayDi85
MCTS implemented in current ComputerPlayer version (decisions tree with best score selections).
Michael Milton
@TMiguelT
ComputerPlayer6/7 (one inherits from the other) seems to use a MinMax + AB Pruning style algorithm
And not MCTS
Though I admit I didn't read all 1000 lines
Adrian Petrescu
@apetresc
Hey @theelk801, I'm gonna try and take a serious stab at implementing Adventures tonight
Do you have any uncommitted progress, or just the CardImpl refactorings on that branch so far?
Evan Kranzler
@theelk801
I have some stuff stashed but none of it really matters
thanks, I really appreciate the help
Evan Kranzler
@theelk801
I would definitely focus on the casting part
even if the adventure ends up going to the graveyard it's not really the issue
looks like we got us a new format to add
Michael Milton
@TMiguelT
Good stuff! Getting out a new release soon with Pioneer would probably be wise
Fenhl
@fenhl
hey, we need a way to add card image sources for custom cards for the EXH project
our idea was to add a new card image source which is the XMage server you're connected to right now
and then send card image URLs via the XMage server/client protocol
the issue is I haven't been able to find where the server/client protocol is defined in the codebase
Michael Milton
@TMiguelT
Is the "Image URLs" source not sufficient?
Fenhl
@fenhl
I believe these are hardcoded
Michael Milton
@TMiguelT
What is hard coded?
Fenhl
@fenhl
the URLs
nvm, I confused the image URLs source with grabbag
using that would be asking our players to copy/paste a big list of URLs, not exactly the best UX
Michael Milton
@TMiguelT
That's true. But if you're making a fork of XMage for the custom set, you could just as easily add a new card source
Fenhl
@fenhl
ideally we'd like to use the extension system
so that players won't have to install a custom client
the extension system most likely needs some additional features though, like support for this server-based card source feature
which is something we want to contribute to as pull requests
I just need some help getting started
Michael Milton
@TMiguelT
I'm not familiar with the plugins system unfortunately, but it looks like there might be built-in hooks for loading images: https://github.com/magefree/mage/blob/master/Mage.Client/src/main/java/mage/client/plugins/MagePlugins.java#L16-L54
Fenhl
@fenhl
the plugin system is unrelated to the extension system as far as I know
as you can see, it currently only allows adding sets, Cubes, and deck types. Adding an API for the image source here is easy, the hard part is figuring out how to change the protocol
Michael Milton
@TMiguelT
Good call. Adding a hook to the ExtensionPackage that adds a new image source seems reasonable.
Allowing the server to act as an image source might be more dubious, possibly because we would normally want to offload as much onto the client as possible (especially because of any legal issues with card images)
Fenhl
@fenhl
ExtensionPackage is server-only though
so adding image sources there won't do anything if the client doesn't have a way to access them
Michael Milton
@TMiguelT
True. You could add a plugin and extension then I suppose?
Fenhl
@fenhl
I'd like to avoid having to modify the client in any way, for ease of installation
it would be the server admin's call to install any extensions anyway
Michael Milton
@TMiguelT
Hmm, I don't quite understand how you could have an extension with custom cards anyway, because all the ExpansionSet does is list cards which I would have thought have to be defined in the client
Fenhl
@fenhl
the card list in ExpansionSet is a list of card classes. These can just be packaged in the same extension
Michael Milton
@TMiguelT
But then how does the client get them?
Fenhl
@fenhl
via the server/client protocol, I'd assume