Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • 09:08
    weirddan455 commented #7978
  • Oct 20 19:41
    weirddan455 commented #8377
  • Oct 20 19:38
    weirddan455 closed #8377
  • Oct 20 19:38

    weirddan455 on master

    [C21] Fixed Fractal Harness add… (compare)

  • Oct 20 17:51
    weirddan455 commented on aa4397d
  • Oct 20 16:42

    jeffwadsworth on master

    - refactoring related to #8375 … (compare)

  • Oct 20 16:09

    jeffwadsworth on master

    - refactoring related to #8375 … (compare)

  • Oct 20 14:41
    jeffwadsworth commented on aa4397d
  • Oct 20 03:07
    weirddan455 closed #8052
  • Oct 20 03:07
    weirddan455 commented #8052
  • Oct 20 03:06
    weirddan455 closed #8183
  • Oct 20 03:06
    weirddan455 commented #8183
  • Oct 20 02:55
    weirddan455 closed #7950
  • Oct 20 02:55

    weirddan455 on master

    BalanceEffect - Fixed effect wh… (compare)

  • Oct 19 23:10
    weirddan455 closed #8396
  • Oct 19 23:10

    weirddan455 on master

    [AKH] Fixed Harvest Season when… (compare)

  • Oct 19 21:31

    jeffwadsworth on master

    - fixed failing test from previ… (compare)

  • Oct 19 21:25
    jeffwadsworth commented on 2e625cc
  • Oct 19 20:33

    jeffwadsworth on master

    - refactoring related to #8375 … (compare)

  • Oct 19 20:18

    jeffwadsworth on master

    - refactoring related to #8375 … (compare)

Evan Kranzler
@theelk801
I have some stuff stashed but none of it really matters
thanks, I really appreciate the help
Evan Kranzler
@theelk801
I would definitely focus on the casting part
even if the adventure ends up going to the graveyard it's not really the issue
looks like we got us a new format to add
Michael Milton
@multimeric
Good stuff! Getting out a new release soon with Pioneer would probably be wise
Fenhl
@fenhl
hey, we need a way to add card image sources for custom cards for the EXH project
our idea was to add a new card image source which is the XMage server you're connected to right now
and then send card image URLs via the XMage server/client protocol
the issue is I haven't been able to find where the server/client protocol is defined in the codebase
Michael Milton
@multimeric
Is the "Image URLs" source not sufficient?
Fenhl
@fenhl
I believe these are hardcoded
Michael Milton
@multimeric
What is hard coded?
Fenhl
@fenhl
the URLs
nvm, I confused the image URLs source with grabbag
using that would be asking our players to copy/paste a big list of URLs, not exactly the best UX
Michael Milton
@multimeric
That's true. But if you're making a fork of XMage for the custom set, you could just as easily add a new card source
Fenhl
@fenhl
ideally we'd like to use the extension system
so that players won't have to install a custom client
the extension system most likely needs some additional features though, like support for this server-based card source feature
which is something we want to contribute to as pull requests
I just need some help getting started
Michael Milton
@multimeric
I'm not familiar with the plugins system unfortunately, but it looks like there might be built-in hooks for loading images: https://github.com/magefree/mage/blob/master/Mage.Client/src/main/java/mage/client/plugins/MagePlugins.java#L16-L54
Fenhl
@fenhl
the plugin system is unrelated to the extension system as far as I know
as you can see, it currently only allows adding sets, Cubes, and deck types. Adding an API for the image source here is easy, the hard part is figuring out how to change the protocol
Michael Milton
@multimeric
Good call. Adding a hook to the ExtensionPackage that adds a new image source seems reasonable.
Allowing the server to act as an image source might be more dubious, possibly because we would normally want to offload as much onto the client as possible (especially because of any legal issues with card images)
Fenhl
@fenhl
ExtensionPackage is server-only though
so adding image sources there won't do anything if the client doesn't have a way to access them
Michael Milton
@multimeric
True. You could add a plugin and extension then I suppose?
Fenhl
@fenhl
I'd like to avoid having to modify the client in any way, for ease of installation
it would be the server admin's call to install any extensions anyway
Michael Milton
@multimeric
Hmm, I don't quite understand how you could have an extension with custom cards anyway, because all the ExpansionSet does is list cards which I would have thought have to be defined in the client
Fenhl
@fenhl
the card list in ExpansionSet is a list of card classes. These can just be packaged in the same extension
Michael Milton
@multimeric
But then how does the client get them?
Fenhl
@fenhl
via the server/client protocol, I'd assume
I don't know how exactly it works but I'm pretty sure this feature has been tested
Oleg Agafonov
@JayDi85
It's have CopyPaste source -- you can insert images source list and download it without new source implemented. It's buggy but works.
E.g. clients connected to server, downloads new cards, open CopyPaste image source and insert urls list from your website to dialog. And download all images as normal.
Fenhl
@fenhl
I know that. I would like to add an easier way
Oleg Agafonov
@JayDi85
BTW -- all cards classes uses only for cards database generate on startup/update. Client uses only database info and don't use cards classes (it's server side logic).
If database is empty (or it's first start of new version) then client generate new db (by classes in jar/folder). If database older version than server then client download new cards from server. If versions same then do nothing.
Michael Milton
@multimeric
Huh, I didn't realise that. Super interesting
Oleg Agafonov
@JayDi85
That's why you can play on new server and with new cards without client update.
Fenhl
@fenhl
@JayDi85 do you know where the server/client protocol is defined?
Oleg Agafonov
@JayDi85
What's you mean by "protocol"?
Fenhl
@fenhl
network communication