Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Jan 11 10:36
    kkrieger85 commented #183
  • Jan 11 10:26
    kkrieger85 commented #183
  • Jan 11 10:26
    kkrieger85 commented #183
  • Jan 11 10:23
    kkrieger85 commented #183
  • Jan 11 10:01
    kkrieger85 commented #183
  • Jan 11 08:44
    kkrieger85 commented #183
  • Jan 10 13:10
    kkrieger85 commented #183
  • Jan 10 12:58
    kkrieger85 commented #183
  • Dec 16 2019 19:18
    olythy commented #183
  • Dec 16 2019 18:58
    kkrieger85 commented #183
  • Dec 16 2019 15:57
    kkrieger85 commented #183
  • Dec 11 2019 17:52
  • Dec 11 2019 17:41

    Flyingmana on 3.2.2

    (compare)

  • Dec 11 2019 17:36
    Flyingmana commented #184
  • Dec 11 2019 17:36

    Flyingmana on master

    fix: avoid crashing if the rule… Merge pull request #184 from cr… (compare)

  • Dec 11 2019 17:36
    Flyingmana closed #184
  • Dec 11 2019 13:43
  • Dec 11 2019 13:40
    m4rw3r opened #184
  • Nov 18 2019 23:49
    Flyingmana commented #180
  • Nov 18 2019 23:28
Bryan "BJ" Hoffpauir
@beejhuff
@Flyingmana I’m just logging in and seeing your update - I hope you are recovering quickly!
Daniel Fahlke
@Flyingmana
finally fixed the testsuite
Aydin Hassan
@AydinHassan
awesome, hopefully I can finish off the windows tests when I get some time now
Daniel Fahlke
@Flyingmana
they have working phpunit here https://github.com/puli/repository
but for me it only outputs the phpunit help :(
Aydin Hassan
@AydinHassan
I have it on loads of repos, works fine for me
Daniel Fahlke
@Flyingmana
then I hope you have more luck then me :/
Aydin Hassan
@AydinHassan
haha I'll try find sometime tomorrow
Aydin Hassan
@AydinHassan
@Flyingmana I know why you can get the tests running
you are doing a shallow clone in appveyor
which uses gitattributes file
which excludes tests dir
so there are no tests on appveyor
lol
Daniel Fahlke
@Flyingmana
argh
thats what you get for trying to optimize before have it working :D
Aydin Hassan
@AydinHassan
haha
Theres lots of fixes to make to get it working
i'm making progress
Daniel Fahlke
@Flyingmana
good to hear
current progress ^
just trying to setup xdebug on my windows machine, it's a nightmare
Daniel Fahlke
@Flyingmana
maybe exclude the fullstack tests on windows for now, would that help? I want to move them into the regression tests anyway
Aydin Hassan
@AydinHassan
if i can't get them working in the next hour I will do :)
Aydin Hassan
@AydinHassan
@Flyingmana Cotya/composer-test-framework#2
could you check this
this fixes two of the failures
Aydin Hassan
@AydinHassan
ok the 3 failures for: testEverything
are due to the libraryPath stuff
which leaves the last issue, which is path to long on Windows when unzipping archives repositories
Daniel Fahlke
@Flyingmana
@AydinHassan merged
Aydin Hassan
@AydinHassan
@Flyingmana sent Cotya/magento-composer-installer#69 for the unit tests
Daniel Fahlke
@Flyingmana
@AydinHassan what is the timeout for the generate artifacts for?
Aydin Hassan
@AydinHassan
kept timing out
can you enable appveyor for PR's now? So I can try fix the rest
Daniel Fahlke
@Flyingmana
looks fine
not sure, but I think i activated the setting needed for PRs
Aydin Hassan
@AydinHassan
cool thanks,
Philippe Savary
@psavary
Hello World! I've just created my first magento-composer-installer enabled magento module. It took me some time to figure out how to achieve a seamless integration with this useful tool. Would it make sense if I add a page to the documentation explaining the whole process from the perspective of an magento module developer?
Steve Johnson
@xcomSteveJohnson
We'd certainly love it if you did! If you'd like to contribute your topic to devdocs.magento.com, start here: https://github.com/magento/devdocs/blob/develop/guides/v2.0/extension-dev-guide/Contribute_edg.md
Or you can also open an issue with the details: https://github.com/magento/devdocs/issues
Aydin Hassan
@AydinHassan
Magento 2 doesn't use this installer though does it?
Also more docs is always great 😃
Steve Johnson
@xcomSteveJohnson
Don't understand your question about the installer. Is that for me?
Philippe Savary
@psavary
The question is: Should I document in the magento-composer-installer the way you can create a magento 1.x module using all the pieces to the puzzle like "composer-repository" and the modman file
Aydin Hassan
@AydinHassan
I don't see why not. It could be a sort of cook book. Start to finish document using an ecample which people could actually follow
Philippe Savary
@psavary
I wasn't quite sure if the magento-installer docs is the right place for such a cookbook which spans over several repositories in the end....but I'sure it would save some time for the next one having this (in the magento-installer-world) quite common problem...I guess....
Aydin Hassan
@AydinHassan
@psavary why would you think it would not fit? Sounds like it would to me :)