Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
Aydin Hassan
@AydinHassan
so there are no tests on appveyor
lol
Daniel Fahlke
@Flyingmana
argh
thats what you get for trying to optimize before have it working :D
Aydin Hassan
@AydinHassan
haha
Theres lots of fixes to make to get it working
i'm making progress
Daniel Fahlke
@Flyingmana
good to hear
Aydin Hassan
@AydinHassan
https://ci.appveyor.com/project/AydinHassan/magento-composer-installer-w7ojo
current progress ^
just trying to setup xdebug on my windows machine, it's a nightmare
Daniel Fahlke
@Flyingmana
maybe exclude the fullstack tests on windows for now, would that help? I want to move them into the regression tests anyway
Aydin Hassan
@AydinHassan
if i can't get them working in the next hour I will do :)
Aydin Hassan
@AydinHassan
@Flyingmana Cotya/composer-test-framework#2
could you check this
this fixes two of the failures
Aydin Hassan
@AydinHassan
ok the 3 failures for: testEverything
are due to the libraryPath stuff
which leaves the last issue, which is path to long on Windows when unzipping archives repositories
Daniel Fahlke
@Flyingmana
@AydinHassan merged
Aydin Hassan
@AydinHassan
@Flyingmana sent Cotya/magento-composer-installer#69 for the unit tests
Daniel Fahlke
@Flyingmana
@AydinHassan what is the timeout for the generate artifacts for?
Aydin Hassan
@AydinHassan
kept timing out
can you enable appveyor for PR's now? So I can try fix the rest
Aydin Hassan
@AydinHassan
also sent https://github.com/Cotya/composer-test-framework/pull/3/files
Daniel Fahlke
@Flyingmana
looks fine
not sure, but I think i activated the setting needed for PRs
Aydin Hassan
@AydinHassan
cool thanks,
Philippe Savary
@psavary
Hello World! I've just created my first magento-composer-installer enabled magento module. It took me some time to figure out how to achieve a seamless integration with this useful tool. Would it make sense if I add a page to the documentation explaining the whole process from the perspective of an magento module developer?
Steve Johnson
@xcomSteveJohnson
We'd certainly love it if you did! If you'd like to contribute your topic to devdocs.magento.com, start here: https://github.com/magento/devdocs/blob/develop/guides/v2.0/extension-dev-guide/Contribute_edg.md
Or you can also open an issue with the details: https://github.com/magento/devdocs/issues
Aydin Hassan
@AydinHassan
Magento 2 doesn't use this installer though does it?
Also more docs is always great 😃
Steve Johnson
@xcomSteveJohnson
Don't understand your question about the installer. Is that for me?
Philippe Savary
@psavary
The question is: Should I document in the magento-composer-installer the way you can create a magento 1.x module using all the pieces to the puzzle like "composer-repository" and the modman file
Aydin Hassan
@AydinHassan
I don't see why not. It could be a sort of cook book. Start to finish document using an ecample which people could actually follow
Philippe Savary
@psavary
I wasn't quite sure if the magento-installer docs is the right place for such a cookbook which spans over several repositories in the end....but I'sure it would save some time for the next one having this (in the magento-installer-world) quite common problem...I guess....
Aydin Hassan
@AydinHassan
@psavary why would you think it would not fit? Sounds like it would to me :)
Philippe Savary
@psavary
:) ok...I'm on the task then....I'll send a pull as soon it's good enough!
Aydin Hassan
@AydinHassan
Awesome, I'll look forward to it
@xcomSteveJohnson I was asking why he would place documentation for magento-composer-installer in the Magento 2docs ? Magento 2 doesn't use magento-composer-installer as far as I'm aware?
Steve Johnson
@xcomSteveJohnson
@psavary @AydinHassan Then I misunderstood the request. I didn't realize that magento-composer-install was (a) the name of this room (jk) and (b) a separate utility. We're delighted to help Magento 2 developers in any way we can though, so please feed us ideas.
Kevin Mitchell
@develpr
Hey all
Daniel Fahlke
@Flyingmana
Hi
Kevin Mitchell
@develpr
First time (trying!) to use composer installer... I'm wondering if anybody can tell me if it's normal to have your composer.json file in a different directory than the actual installation of Magento?
Kevin Mitchell
@develpr
Or can somebody recommend a SIIIIICK tutorial/video that shows "best practices" for using composer to deploy a magento site?
Daniel Fahlke
@Flyingmana
I usually set a sub directory as target for magento, and composer is a dependency fetching tool, not a deployment tool
I suggest deployer.phar as a simple php deploy tool
For composer and magento i suggest the readme of the installer
Kevin Mitchell
@develpr
Thanks <3 - out of curriouosity, do you use deployer for deployments? I've never used it tbqh.