Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
    Tarmo Leppänen
    @tarlepp
    it will propably broke something
    Tieson Trowbridge
    @tiesont
    But, say, adding radiobutton as an option to prompt would be a minor release.
    I've been using 4.4 with Bootstrap 4. I have an issue with the changes required to make it work with Alpha 6
    It doesn't take much.
    Tarmo Leppänen
    @tarlepp
    yep, that would be minor
    and if you have used it with bootstrap 4 with "minor" changes, does the same work still with bootstrap 3 ?
    Tieson Trowbridge
    @tiesont
    Yes and no. It works with or without those changes, which are mostly cosmetic.
    btn-default was replaced with btn-secondary, and the flexbox layout messes up the header
    Tarmo Leppänen
    @tarlepp
    if just cosmetic, those are really not changes - imho
    Tieson Trowbridge
    @tiesont
    Well, the header is the biggest issue. The bits have to be appended in a different order, or the title and close button are laid out incorrectly
    The close button still works, but it looks awful
    Tarmo Leppänen
    @tarlepp
    hmm does that btn-secondary work as the same within bootstrap 3 ?
    Tieson Trowbridge
    @tiesont
    It's more or less the same style. The colors have been tweaked a little in BS4
    Not sure what the point of a new name was.
    Tarmo Leppänen
    @tarlepp
    is there a 'btn-secondary' in bootstrap 3 ?
    Tieson Trowbridge
    @tiesont
    No.
    Tarmo Leppänen
    @tarlepp
    so that is breaking change
    Tieson Trowbridge
    @tiesont
    It's a swap
    To a degree. The btn styles are still applied, just like BS3. You just don't get the color associated with btn-secondary
    Tarmo Leppänen
    @tarlepp
    now we're using 'btn-default' which is replaced in bs4 , so same version won't work with bs3 and bs4
    and that is still breaking change - color changed
    • there is no more 'btn-default' style that users might override themselfs on bootbox dialogs...
    Tieson Trowbridge
    @tiesont
    Fair enough. From a "does it still work" perspective, it doesn't stop anyone from using Bootbox, but I agree with your point(s).
    Tarmo Leppänen
    @tarlepp
    functionality might work just previously, but that part is not the whole thing
    Tieson Trowbridge
    @tiesont
    So, do you think 5.0 is a complete rewrite, or just figure out how to support the expected changes in makeusabrew/bootbox#545 plus BS4 compatibility?
    Tarmo Leppänen
    @tarlepp
    /functionality/progmatic functionality/s
    major version don't mean a complete rewrite
    Tieson Trowbridge
    @tiesont
    As a general rule, yeah, but I'm speaking specifically for Bootbox
    For instance, there seems to be a persistent request for a message option for prompt
    Tarmo Leppänen
    @tarlepp
    just that something "major" has changed, and it "might" broke backwards compatibility
    but eg in bs3 => bs4 i would make new major of bootbox
    and reason for that
    • new major version library that bootbox uses
    • we don't need to support multiple major versions of main library (bs)
    • easy to end-users to understand which version to use
    • we can tell that dependency to bs in bower.json exactly
    and really if there is no any structural changes on modals, buttons on bs3 => bs4 then there is no need to update major version
    Tieson Trowbridge
    @tiesont
    Unfortunately, I don't use bower at all, so that would be on you or Nick.
    Tarmo Leppänen
    @tarlepp
    but what i have heard here now, it seems like there is
    same with package.json
    and that is another thing what we should discuss
    Tieson Trowbridge
    @tiesont
    The only structural change I know of is the order of the elements in the title
    Tarmo Leppänen
    @tarlepp
    and that is enough
    Tieson Trowbridge
    @tiesont
    Since BS4 uses flexbox, the order changes.
    Tarmo Leppänen
    @tarlepp
    is the structure same within bs3 and bs4 if not => breaking change
    Tieson Trowbridge
    @tiesont
    So, I guess to get back to the original question, do we want to push a 4.5 release with just the new locales? And then work on a plan for 5.0?
    Tarmo Leppänen
    @tarlepp
    yes
    again
    and "rapid" means like new minor in every month (if there is something new)
    new major in every 9 months (if there is a new one)
    and patches weekly (if there is any)
    Tieson Trowbridge
    @tiesont
    So, who should work on that? Like I said, I'm not really a bower/node/whatever user, so I can do anything that just requires putting files together and writing some documentation. Anything else is outside my comfort zone, although I'm not adverse to taking a crack at it.