Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
    Tarmo Leppänen
    @tarlepp
    now we're using 'btn-default' which is replaced in bs4 , so same version won't work with bs3 and bs4
    and that is still breaking change - color changed
    • there is no more 'btn-default' style that users might override themselfs on bootbox dialogs...
    Tieson Trowbridge
    @tiesont
    Fair enough. From a "does it still work" perspective, it doesn't stop anyone from using Bootbox, but I agree with your point(s).
    Tarmo Leppänen
    @tarlepp
    functionality might work just previously, but that part is not the whole thing
    Tieson Trowbridge
    @tiesont
    So, do you think 5.0 is a complete rewrite, or just figure out how to support the expected changes in makeusabrew/bootbox#545 plus BS4 compatibility?
    Tarmo Leppänen
    @tarlepp
    /functionality/progmatic functionality/s
    major version don't mean a complete rewrite
    Tieson Trowbridge
    @tiesont
    As a general rule, yeah, but I'm speaking specifically for Bootbox
    For instance, there seems to be a persistent request for a message option for prompt
    Tarmo Leppänen
    @tarlepp
    just that something "major" has changed, and it "might" broke backwards compatibility
    but eg in bs3 => bs4 i would make new major of bootbox
    and reason for that
    • new major version library that bootbox uses
    • we don't need to support multiple major versions of main library (bs)
    • easy to end-users to understand which version to use
    • we can tell that dependency to bs in bower.json exactly
    and really if there is no any structural changes on modals, buttons on bs3 => bs4 then there is no need to update major version
    Tieson Trowbridge
    @tiesont
    Unfortunately, I don't use bower at all, so that would be on you or Nick.
    Tarmo Leppänen
    @tarlepp
    but what i have heard here now, it seems like there is
    same with package.json
    and that is another thing what we should discuss
    Tieson Trowbridge
    @tiesont
    The only structural change I know of is the order of the elements in the title
    Tarmo Leppänen
    @tarlepp
    and that is enough
    Tieson Trowbridge
    @tiesont
    Since BS4 uses flexbox, the order changes.
    Tarmo Leppänen
    @tarlepp
    is the structure same within bs3 and bs4 if not => breaking change
    Tieson Trowbridge
    @tiesont
    So, I guess to get back to the original question, do we want to push a 4.5 release with just the new locales? And then work on a plan for 5.0?
    Tarmo Leppänen
    @tarlepp
    yes
    again
    and "rapid" means like new minor in every month (if there is something new)
    new major in every 9 months (if there is a new one)
    and patches weekly (if there is any)
    Tieson Trowbridge
    @tiesont
    So, who should work on that? Like I said, I'm not really a bower/node/whatever user, so I can do anything that just requires putting files together and writing some documentation. Anything else is outside my comfort zone, although I'm not adverse to taking a crack at it.
    Tarmo Leppänen
    @tarlepp
    that i don't know how that is made within this project - i haven't never released new version
    but basically something like npm version <major|minor|patch> and the push new tag gh + npm
    bower versions should be made quite similar
    but because lots of people are using bower, imho we should support those too
    Tieson Trowbridge
    @tiesont
    Do you want to work on the actual release, then, and I'll update the various readme files, releases page, etc., or do you have a better suggestion? I would let Nick take care of it, but I assume he's busy at this point.
    @makeusabrew ?
    wolfieorama
    @wolfieorama
    Hi Good people, was wondering if there is a way to pass inputOptions: in to the prompt which has a select directly from rails jbuilder (produces an array) using a link ? something like /teams.json
    wolfieorama
    @wolfieorama
    no worries figured out
    Charles Crossan
    @crossan007
    hey - what's the best way to execute a callback when a bootbox is shown? I don't see an option to set a callback function in the options passed to bootbox.dialog({options}) that would be executed on .show()
    actually, i think what I'm looking for is defining a function inside of dialog.init()
    Tieson Trowbridge
    @tiesont
    @crossan007 Yes, use either init (which is only ever called once), or use the Bootstrap modal events: dialog.on('show.bs.modal', function(e){ ... }) or dialog.on('shown.bs.modal', function(e){ ... }), depending on your requirements.
    Charles Crossan
    @crossan007
    @tiesont thanks for that!
    Tieson Trowbridge
    @tiesont
    @tarlepp I've pinged Nick on what to do now that Beta is out, but I'm not entirely confident that he'll reply anytime soon. Do you have any interest in figuring out what our plan of attack should be with or without him?
    Tarmo Leppänen
    @tarlepp
    tiesont: i think nick has something else going on, he has been so quiet for a loooong time
    tiesont: + i don't follow gitter messages so often
    Tieson Trowbridge
    @tiesont
    @tarlepp Neither do I. That being said, are you interested in doing something? If so, what's the best way to communicate?
    Ryan Falzon
    @ryanfalzon
    Hi all, using bootbox v5.0.1 but for some reason the bootbox is listed in the html but is not seen in the browser. Any ideas please?
    Tieson Trowbridge
    @tiesont
    @ryanfalzon That's not much to go on. What version of Bootstrap are you using? Are you using this in conjunction with some other framework / library? A jsFiddle or similar, reproducing what you're seeing, would help. That being said - Bootbox doesn't have any styles of it's own, so this doesn't sound like an issue on our end.
    Tieson Trowbridge
    @tiesont
    @tarlepp If you get bored, I've been working on another update to the bootbox site. The source is here: https://github.com/tiesont/bootboxdocs, and I pushed it to this URL: https://tiesont.github.io/bootbox/index.html. Site uses Jekyll to build the static pages and to build the search index for lunrjs. Let me know what you think?