marionettejs/backbone.marionette

(⊃｡•́‿•̀｡)⊃━☆ﾟ.*･｡ﾟ The Backbone Framework: http://marionettejs.com

Mars

@marcelisaac_twitter

How do I use a user js on Firefox?

Paul Falgout

@paulfalgout

dimtabu

@taburetkin

I had a few revelations today.

dimtabu

@taburetkin

the first one was realizing that iteration over object's keys is pretty expensive task. (no matter own or all).
the second one was realizing that iteration over linked list items will be pretty slower than just iterating over array elements
the third one was realizing that super-puper modern generator/iterator still stay expensive when you trying to do it over object keys and values.
the fourth was that array manipulation like inserting / splicing / iteration will be much more faster that any compositions of objects/maps/objects+arrays.
and all this lead me to very simple solution for working with events - just use simple flat array and thats all.
finally i made a library which is faster than bb on some cases and the same in others.

Paul Falgout

@paulfalgout

don't you need keys to know which index of the array, or how are you keeping track?

also if this leads towards insights on https://github.com/marionettejs/backbone.marionette/blob/master/src/child-view-container.js#L34 I'm all ears :-D

dimtabu

@taburetkin

i realy ended with only flat arrays.
splice(indexOf(item),1) - works very well

tested on 1000 elements array

Paul Falgout

@paulfalgout

wow indexOf is faster ?!?

dimtabu

@taburetkin

i have stats, let me show

Paul Falgout

@paulfalgout

any chance you're testing events near the top of the stack so indexOf is cheap?

dimtabu

@taburetkin

at first i tested all possible variant of working with data set
without any events library, just adding/removing/iterating over 1000 elements.
there were object literal, map, array, my special linked list (i was hoped it will beat all of them but it isnt)
and after this when i realized that array is just better i tried to remove backbone's style events from my lib
i mean this._events.eventName.callbacks -> this.allcalbacks and starts the test against this libs. and that was pretty cool

dimtabu

@taburetkin

this is 1000 elements and delete operation is against random elements somewhere

awful object iteration just eat all gains you can have from crud operations :-/

dimtabu

@taburetkin

for example, i have this test

        benchmark('bb', () => {
          beforeEach(() => {
            inst = bb;
            other = bbOther;
            inst.off();
            inst.on('a b c d e', cb);
            other.listenTo(inst, 'a d', () => { });
            other.listenTo(inst, 'e', () => { });
            other.listenTo(inst, 'f g', cb);
          });
          it('', () => {
            inst.off('a d e');
          });
        });

and the same for yaff

dimtabu

@taburetkin

so, to be honest. indexOf + splice is slower, as you can see. but it never goes alone, and if there will be some kind of iteration with removal, then you get benefits

and it will be interesting to test views manager in different ways.
we should think of some working case for test purposes and i will try to do something with it, if you wish

dimtabu

@taburetkin

also tested in the same setup removing the g event. it is the last added event in an array

bb: 999 992 op/sec,  0.001 avg ms
yaff: 800 031 op/sec,  0.001249 avg ms

dimtabu

@taburetkin

just take a look closer on views manager
i am not pretty familiar with it
but on the first look i saw this.

add to the end
add at specified index
clear all
is there something else?

i mean how it used by cv

ah, + removing by index

Paul Falgout

@paulfalgout

yep.. beat me to it. I think that's it if I'm remembering correctly

dimtabu

@taburetkin

if i remember correctly _sortBy creates new instance of array

dimtabu

@taburetkin

what is swapChildViews ? who invokes this and in which case?

looks like orphan

Paul Falgout

@paulfalgout

you can switch the places of two children within a collectionview. it works? why does it look like an orphan?

dimtabu

@taburetkin

of course its not
correct me if i am wrong - its a public api but internally it not used

Paul Falgout

@paulfalgout

https://github.com/marionettejs/backbone.marionette/blob/master/docs/marionette.collectionview.md#swapping-child-views

yeah not used within the library to do anything

dimtabu

@taburetkin

i just not find any use of it, only declaration thats why i thought its an orphan
but after that i goes to the docs and see its a something i don't know before ))

dimtabu

@taburetkin

i start to extend ChildManager and realized that its already used indexOf + splice

so )) i don't know what to improve here

also, i can say that adding a view to the manager is 100 000 ops / sec
setting an array ov views is 200 000 o/s
and removing by view is 300 000 o/s

Mars

@marcelisaac_twitter

Does anyone know how I can self-host with nextcloud?

dimtabu

@taburetkin

Paul, do you know how to debug backbone's tests? i just can't realize how to do that, is it possible at all?

Mars

@marcelisaac_twitter

Have you guys ever used cryptomator?

dimtabu

@taburetkin

https://github.com/taburetkin/yaff-events/blob/master/performance.md

dimtabu

@taburetkin

what do you think about possibility to listen for dom events like this?

let el = document.createElement('div');
listener.listenToOnce(el, 'click', function(...args){ 
  console.log('CLICK', args, this);
});

i just checkit in codepen with my setInterop and you know what? it works :)

just published v2

John Michael Swartz

@graphographer

I'm wondering if anybody has noticed that the search function isn't working on marionettejs.com

I have a small team that needs to learn mn pretty quickly, and the docs are written such that a search feature is a necessity.

I'm happy to help out, should I just try to fix it and create a pull request?

Paul Falgout

@paulfalgout

yeah hmm https://github.com/marionettejs/marionettejs.com

FWIW: https://devdocs.io/marionette~4/

I'm not sure why it hasn't gotten 4.1.2 though

ah I think because 4.1.0 technically had some features, but didn't actually update the doc files

Where communities thrive

People

Repo info

Activity