Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • 09:01
    christinavoudouris synchronize #105
  • 08:59
    christinavoudouris synchronize #105
  • 08:54
    christinavoudouris synchronize #105
  • 08:53
    christinavoudouris synchronize #105
  • 08:26
    christinavoudouris synchronize #105
  • 08:21
    christinavoudouris commented #105
  • 08:17
    christinavoudouris synchronize #105
  • 08:17
    christinavoudouris synchronize #105
  • 07:59
    christinavoudouris synchronize #105
  • 07:24
    Smankusors labeled #105
  • 07:24
    Smankusors labeled #105
  • 07:23
    Smankusors edited #105
  • 00:46
    christinavoudouris edited #105
  • 00:30
    christinavoudouris edited #105
  • 00:29
    christinavoudouris synchronize #105
  • 00:14
    christinavoudouris edited #105
  • 00:07
    christinavoudouris opened #105
  • Apr 07 15:30
    zdpuppet closed #104
  • Apr 06 13:36
    ChildishGiant commented #104
  • Apr 06 11:39
    DanielRuf labeled #104
Florian Dendorfer
@fdendorfer
Hello, is this the right place to ask for quick help?
2 replies
Allie
@ChildishGiant
https://github.com/materializecss/materialize/blob/v1-dev/js/dropdown.js#L532 This line seems to be causing an error when using dropdown from local builds (npm run release). Any ideas?
People have run into this before but there's not been a PR or anything by the looks of things Dogfalo/materialize#6389
3 replies
Sam Schurter
@samschurter
Hello, I'm looking at doing some development on the new fork and had some questions on tests.
There's 2 folders, tests with the jasmine tests and test which just has some HTML files. The jasmine test folders each seem to have their own fixture files, so what are the files in test for?
5 replies
Sam Schurter
@samschurter
I fixed a few bugs in the Dropdown component related to the position when inside a modal (or any fixed division, I think), the z-index being too high, and not respecting coverTrigger: false when aligned to bottom.
All the tests in the jasmine package are related to whether an object exists or behaves properly, can it also test for size, position, and z-index visibility?
6 replies
Sam Schurter
@samschurter
No, sorry, I didn't mean to imply that it would. I just noticed how far behind current release we are when researching the issue. I'm writing a lot of tests and if they are going to need to be re-written later maybe it would be better to upgrade the dependencies first and then write the tests to be compatible the first time.
I also haven't read all the changelogs between 2.6 and 3.6 so who knows, upgrading might fix it. If I'm reading things right, upgrading from 2.6 to 3.6 would mean moving from the defunct PhantomJS to (Headless Chrome?) which is a big change.
Sam Schurter
@samschurter
Jasmine-jquery is also defunct, and I haven't even begun to look at grunt-contrib-jasmine
What I'm saying is, upgrading looks like it could be a big difficult project, but could be necessary at some point. If you and the other contributors agree, I think it makes sense to do the upgrade while we still have about 60 test cases rather than waiting until we have hundreds.
1 reply
Tom Elssjö
@tomwjerry
I tried using webpack and it passed all the tests except select test. Perhaps webpack is too overkill and it is better to just use package.json scripts + rollup.js One issue is grunt-jade (or what it is called) that needs to be replaced with something and it would force a switch to pug. Big upgrade process. As for jasmine we would have to use some kind of server for the fixtures to replace jasmine-jquery or directly make fixtures using dom creation in javascript.
Tom Elssjö
@tomwjerry
I wonder if it is possible to use css grid for the 12 column grid system? However css grids are very static so a flexbox solution would fit the general purpose. Right now the grid is made by floats.
Sam Schurter
@samschurter
Yes, I recently used Angular Material with angular/flex-layout and it was great. Uses css flex for everything. Also seems like it would be a huge project to upgrade
Sam Schurter
@samschurter
The way these tests interfere with each other is ridiculous.
On one hand I want a framework that runs each test in a truly clean environment so there aren't bad interactions, on the other hand maybe those interactions are a symptom of bugs to fix.
Sean Doherty
@doughballs
@tomwjerry I've created a rough sass mixin that converts the materialize grid to css grid...actually I think it could be improved, and there are probable some modifications needed but it's close.
Tom Elssjö
@tomwjerry
Nice! Did not know it was possible using css grid for it, just a therory I had
Andrew Brown
@drusepth
Hey all, been using the original materialize repo for years now, just wanted to pop in and say thank you so much for trying to get it off the ground again. There's been a lot of issues over the years, but things are looking positive with the community rallying :) Thank you!
Frank Harland
@harri00413

Hey all, been using the original materialize repo for years now, just wanted to pop in and say thank you so much for trying to get it off the ground again. There's been a lot of issues over the years, but things are looking positive with the community rallying :) Thank you!

My feelings exactly. Thank you guys.

Michal Sytko
@MichalSy
Since the original project is frozen. Do you plan to name the project differently and update the readme?
Because currently it is more of a ghost project?
Tom Elssjö
@tomwjerry
I cannot find where the discussion about it where but the conclusion was to not change name. It makes sense in a way since the community project is about improving materialize, not to make a new one.
Perhaps there will be a materialize2 in the future unless the original creators decide to claim copyright but it is not likely since it always been a community project. Or Materialize Next
It is far from a ghost project, we are all busy but do our best to keep the materialize project running.
Felipe Maia
@webfelipemaia
In Chrome, when using rowspan or colspan, the table overlaps the color of the borders when the color is set to transparent rgba.
materialize-table.png
It would be possible to get around this by defining $table-border-color with hexadecimal code instead of the current rgba. It would be something like $table-border-color: #dedede. This would correct this Chrome behavior that does not only affect the border color, as seen at https://stackoverflow.com/questions/53055413/make-border-invisible-with-rowspan-and-colspan.
Tom Elssjö
@tomwjerry
Good find! Maybe post an issue about it?
Felipe Maia
@webfelipemaia
Done.
Allie
@ChildishGiant
I feel like we should set a date for a release, otherwise we're never going to reach one
Tom Elssjö
@tomwjerry
Good idea
Allie
@ChildishGiant
It doesn't have to be set in stone as the release date but would act as a target
Filip Oščádal
@mxdpeep
which repo is the newest one? it's a slightly mess... 1) https://github.com/materializecss/materialize.git 2) https://github.com/Dogfalo/materialize.git
2 replies
Filip Oščádal
@mxdpeep
are there any plans to move the building process to use yarn / node v14?
1 reply
Allie
@ChildishGiant
This message was deleted
1 reply
Tomas Wilhelmsson
@tomaswilhelmsson
hey, i would like to have a drop down item at the right of a tabbed menu with an indicator for how many items there is in the menu ... but it looks like crap (added blue for contrast only) looks like this now .. https://snipboard.io/cKQpy4.jpg any tips for how to do this ? and that is with in webbrowser editing of some css values ...
using badges and material icons
Allie
@ChildishGiant
@DanielRuf I think we should set a project board up to track what needs doing before a release can happen. I'm happy to take on a more active role now if wanted
3 replies
CobyChetwyn
@CobyChetwyn

Hi,

Does anyone know of a way to make the datepicker (https://materializecss.com/pickers.html) inline, so it shows on a page without having to trigger it to open?

Similar to this - https://jqueryui.com/datepicker/#inline

Allie
@ChildishGiant

Does anyone know of a way to make the datepicker inline?

I don't think there's any support for that in the library but you can feel free to open an issue and suggest it

Allie
@ChildishGiant
Just submitted a PR for the first release version :D