Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • 05:27

    jklymak on main

    Fix issue with hist and float16… Merge pull request #23047 from … (compare)

  • 05:27
    jklymak closed #22773
  • 05:27
    jklymak closed #23047
  • 05:27
    jklymak closed #22622
  • May 15 21:27
    greglucas commented #23045
  • May 15 19:01

    timhoffm on main

    Fix missing section header for … Merge pull request #23044 from … (compare)

  • May 15 19:01
    timhoffm closed #23044
  • May 15 19:01
    timhoffm closed #23043
  • May 15 18:28
    anntzer commented #22950
  • May 15 18:28
    anntzer synchronize #22950
  • May 15 18:22

    timhoffm on main

    Demonstrate both usetex and non… Merge pull request #23029 from … (compare)

  • May 15 18:22
    timhoffm closed #23029
  • May 15 16:41
    anntzer synchronize #23029
  • May 15 16:40
    anntzer commented #23029
  • May 15 16:25
    Biswa96 commented #23051
  • May 15 16:24
    tacaswell commented #23051
  • May 15 16:23
    tacaswell commented #23051
  • May 15 16:17
    tacaswell milestoned #23051
  • May 15 16:08
    dstansby review_requested #21755
  • May 15 16:07
    Biswa96 opened #23051
Rohit Rawat
@xordux

Hi,
A Question about PR https://github.com/matplotlib/matplotlib/pull/18493/

Azure test is failing for Windows_py37, macOS_py37, macOS_py38 . But I can't understand if there is any relation to the code changes I have done.

I can see that other PR are also failing Azure test(like this merged recently but had all Azure tests failing: matplotlib/matplotlib#18696 )

So, is this like some other issue with master branch or I need to check it in my code?

Thomas A Caswell
@tacaswell
I was just looking at this
it looks like something changed under us in the OSX on azure envirmont and imagemagik is fighting back...
Rohit Rawat
@xordux
Previously (few weeks ago) every check passed smoothly, but today I change assert statement to py.warn and this started failing(I also synced my repo today).
Thomas A Caswell
@tacaswell
between the last CI that passed on azure OSX and the first that failed imagemagick changed from 7.0.10-31 to 7.0.10-34
Rohit Rawat
@xordux
I can't find any release notes of imagemagick in web. Should comparing two releases' code help ?
Thomas A Caswell
@tacaswell
https://github.com/ImageMagick/ImageMagick/releases <- looks like they have a very rapid super-micro release cadence
Rohit Rawat
@xordux
And comparing releases got me more confused :D .. still checking if I get any hint
Jody Klymak
@jklymak
The tk error is more problematic.
Rohit Rawat
@xordux
@jklymak strange thing is that it is passing in Windows_Py38 but not in Windows_Py37

Regarding tk error: Will increasing _test_timeout (which in 10 right now) help ?

Edit: 7th line in test_backend_tk.py
_test_timeout = 10 # Empirically, 1s is not enough on Travis.

Jody Klymak
@jklymak
Yeah, it could just be a transitory failure.
Rohit Rawat
@xordux
So should I test it again or increase timeout to some value?
Jody Klymak
@jklymak
I'd just try running again. I don't understand the test well enough to say. @dopplershift is the resident animation guru
Thomas A Caswell
@tacaswell
Do you use brew locally?
convert -size 800x600 -depth 8 -delay 20.0 -loop 0 rgba:- /tmp/temp.m4v
Rohit Rawat
@xordux
me? I work on Windows 10.
Thomas A Caswell
@tacaswell
I know @jklymak is a mac user ;) . If you update the imagemagick does that command work?
Rohit Rawat
@xordux
I am not sure if it is failing in my system. I am checking it
BTW is there some magic phrase to re-test a PR? Like mentioned here
Rohit Rawat
@xordux
or I need to do something like mentioned in this answer ? To retest PR.
and about imagemagick: I tried running this test(in my branch and current synced master branch both) and getting this error:
AttributeError: module 'matplotlib._c_internal_utils' has no attribute 'display_is_valid'
Thomas A Caswell
@tacaswell
did you re-install from source?
also try a git clean -xfd to clear the build products and force the c-extensions to be re-complied
Rohit Rawat
@xordux
No, I thought it's not required. I will try it now.
Thomas A Caswell
@tacaswell
also make sure you imagemagick is all the way updated, I can produce this on linux as well
Rohit Rawat
@xordux
sure thing 👍
Thomas A Caswell
@tacaswell
✔ 13:02:38 $ convert -size 800x600 -depth 8 -delay 20.0 -loop 0 /tmp/test.png /tmp/temp.m4v
convert: delegate failed `'avconv' -nostdin -v -1 -i '%M%%d.pam' -plays %I '%u.%m' 2> '%u'' @ error/delegate.c/InvokeDelegate/1898.
Rohit Rawat
@xordux
@tacaswell just to mention, imagemagick is not already installed in my system. I should install it and check then, right?
Thomas A Caswell
@tacaswell
definitly an imagemagick bug :-p
given that I think this is a regression in convert that shows up on both mac and linux, unless you want to help out imagmagick and confirm the bug is also present in 7.0.10-34 in windows I would not worry about it
Rohit Rawat
@xordux
is that test.png present somewhere or you created a blank image of size 800x600 to test it?
Thomas A Caswell
@tacaswell
I saved a mostly empty 800x600 image
In [1]: import matplotlib.pyplot as plt                                                                                                                                                                                                                                                                

In [2]: fig, ax = plt.subplots()                                                                                                                                                                                                                                                                       

In [3]: fig.set_size_inches(8, 6)                                                                                                                                                                                                                                                                      

In [4]: fig.savefig('/tmp/test.png')
Rohit Rawat
@xordux
ok, thank you.
@tacaswell getting same in windows as well:
(test_env) C:\PersonalProjects\MachineLearning\Github\18151>"C:\Program Files\ImageMagick-7.0.10-Q16-HDRI\convert" -size 800x600 -depth 8 -delay 20.0 -loop 0 tmp.png temp.m4v
convert: delegate failed `"ffmpeg.exe" -nostdin -v -1 -i "%M%%d.pam" -plays %I "%u.%m" 2> "%u"' @ error/delegate.c/InvokeDelegate/1898.
Thomas A Caswell
@tacaswell
can you please leave a comment on the imagemagick issue ?
Rohit Rawat
@xordux
yes, right away.
Thomas A Caswell
@tacaswell
thanks!
Rohit Rawat
@xordux
If I want to retest a PR without new commit, then should I do it like this ? Or is there some other way you do it?
Thomas A Caswell
@tacaswell
if the UI does not have a "re run the test" button in the check section (it is not always clear to me when things show up for me because I am an admin and when things are there for everyone), then close and re-open the PR
on the "checks" tab I have a "re-run failed" link next to the failed tests
Rohit Rawat
@xordux
There is no such button that I can find. I will close and re-open then.
Grigory Starkov
@Gregstrq
When a 3d surface is plotted, each of the surface patches has a constant color. Is it possible to have the colors change continously? (I think one can use linear interpolation inside the patch)
Bruno Beltran
@brunobeltran

looks like font_manager._rebuild is gone on master. What's the go-to advice for users that are installing many new fonts after installing matplotlib? Should I tell them to clear mpl.get_cachedir() directly each time?

The only way to do it from inside mpl itself now seems to be something like

font_manager.fontManager = font_manager._load_fontmanager(try_read_cache=False)?

(not saying that my go-to advice for people was to call a private method, but if someone who isn't me needed to update their recommendations 🐑)
Antony Lee
@anntzer
I think there should just be a public API for that (I believe this may be mentioned somewhere in one of the long font_manager issues...)