Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • 13:21
    oscargus labeled #24642
  • 13:21
    oscargus opened #24642
  • 13:14
    oscargus edited #23846
  • 13:13

    oscargus on main

    Use pybind11 for tri module Preinstall pybind11 on no-build… Triangulation.set_mask fix and … and 4 more (compare)

  • 13:13
    oscargus closed #24522
  • 13:04
    DWesl synchronize #22999
  • 12:58
    kostyafarber review_request_removed #24498
  • 12:58
    kostyafarber review_requested #24498
  • 12:56
    kostyafarber review_requested #24498
  • 12:56
    kostyafarber review_request_removed #24498
  • 12:33
    oscargus labeled #24641
  • 11:53
    almarklein opened #24641
  • 10:07
    timhoffm commented #24585
  • 10:05
    timhoffm commented #24585
  • 10:05
    timhoffm commented #24585
  • 09:58
    saranti commented #24637
  • 09:51
    timhoffm commented #24585
  • 09:44
    timhoffm commented #12577
  • 09:33
    anntzer labeled #24640
  • 09:33
    anntzer labeled #24640
Jody Klymak
@jklymak
Do yo mean the min and max of the colormapping? Use vmin and vmax in the Norm or hist2d (which will pass to the norm)
matrixbot
@matrixbot
physkets Jody Klymak (Gitter): Yes! the min & max extents. No, setting the vmin & vmax in the Norm with just scale things. That is not what I want.
I have different plots, and I'd like to use the same colorbar for all of them. If I normalize them all, the values will be incorrect. So I need to pre-set the colorbar extents, and then have them plot as per the values obtained form hist2d.
Jody Klymak
@jklymak
Sorry that is not making much sense to me suggest you show what you are doing with code on discourse.matplotlib.org
matrixbot
@matrixbot
hannah
@story645
hey, any of the maintainers want to be on a PyData maintainers meet & greet panel for pydata diversity scholarship recipients? it's Wednesday, Nov. 11, 5-6 PM EST , super low stakes, tends to be very at teh "how to contribute" level
(my very personal opinion is it's good to mix up the folk out there representing the project)
Thomas A Caswell
@tacaswell
I already added it to the agenda for next Tuesday as well
hannah
@story645
yay!
matrixbot
@matrixbot
Cadair Hey could someone who has the permissions do me a favour and kill this Travis build: https://travis-ci.org/github/matplotlib/pytest-mpl/builds/739905148
Cadair it hasn't auto-cancelled and Travis is already painfully slow without waiting for that to finish as well :(
Cadair thanks
Jody Klymak
@jklymak
Suggest you just close and re-open the PR.
matrixbot
@matrixbot
Cadair Well it didn't autocancel for one reason, I didn't expect it to for a close either. It ran eventually anyway, I am now just waiting for it all to run again 😀
Jody Klymak
@jklymak
Are @tacaswell and @anntzer aware of this effort? matplotlib/pytest-mpl#101
matrixbot
@matrixbot
Cadair I did keep an eye on the work aroundGSOC
Jody Klymak
@jklymak
OK, great. Thats what they were working on
matrixbot
@matrixbot
Cadair but I finally cracked and needed to pull the hacks that lived in sunpy out to somewhere else, so I spent way too long this week doing that instead
Thomas A Caswell
@tacaswell
unfortunately I have not had the bandwidth to push that work forward once GCOS ended, but it is still on my (semi-inifinite) queue
would not be offended if someone else worked on it though :)
matrixbot
@matrixbot
Cadair I think the GSOC approach and that approach are different, although maybe close in terms of usability
Jody Klymak
@jklymak
I didn't fully understand the GSOC approach, and it seemed rather burdensome to contributors.
matrixbot
@matrixbot
Cadair This workflow has worked well for sunpy over the last few years with some iteration. I think maybe we have a slightly easier time than mpl core would in terms of potential for subtle layout changes etc.
Thomas A Caswell
@tacaswell
the sunpy approach is to at some point generate a sha of the output and then compare against that in the future?
which means you still track all of the details about what it should be, but do not have to check the full images into the repo
matrixbot
@matrixbot
Cadair yeah, keep those hashes in the repo, and then images externally
Cadair indeed
Thomas A Caswell
@tacaswell
that still leaves you vulnerable to system-to-system changes (e.g. different freetype)
matrixbot
@matrixbot
Cadair we encode the freetype version into the hash library filename, and only do the compare if it matches
Thomas A Caswell
@tacaswell
the GSOC approach is to assume that a developer can from the current tip of the default branch generate a set of "correct" baseline images and then use those as the baseline for any changes you make
if you want to change a test image you change the file name (so it is easy to keep both old and new around)
matrixbot
@matrixbot
Cadair that sounds like it could be complementary, instead of downloading the baseline like we do, you could generate them from the default branch
Cadair with the hashes you would only need to generate ones if they didn't match
Thomas A Caswell
@tacaswell
also means you can accept small deltas because we are still using the per-pixel comparison
with vectors formats do you hash the vector file or after it has been rasterized?
matrixbot
@matrixbot
Cadair I think we have only ever done comparison to ong
Cadair *png
Cadair which is maybe another simplifying assumption that we can get away with that mpl core wouldn't be abel to
Thomas A Caswell
@tacaswell
over the summer we got through the internal changes that need to be made, but did not get to the dev-facing tools to automate the various steps
matrixbot
@matrixbot
Cadair We also haven't ever had issues with subtle changes to the images, by pinning mpl and freetype versions the hashes seem pretty stable
Thomas A Caswell
@tacaswell
or sorting out how to bend CI cache's to our will
but our goal is to un pin freetype
matrixbot
@matrixbot
Cadair that's a good goal.
Thomas A Caswell
@tacaswell
the final step is that as part of our release process we would generate a set of "blessed" baseline files for some version of freetype
matrixbot
@matrixbot
Cadair for us the bundled mpl freetype, either in wheels or downloaded at git build time has kept us snae
Thomas A Caswell
@tacaswell
so packagers can test
matrixbot
@matrixbot
Cadair *sane
Thomas A Caswell
@tacaswell
will we know if the py39 wheels work before we merge?
Elliott Sales de Andrade
@QuLogic
I haven't tested them, but the building works: https://github.com/QuLogic/matplotlib/actions/runs/335123526
Jerome Villegas
@jeromefv
Hey everyone! I looked at my notes and I'm hoping to confirm what kind of data Matplotlib manages. I have either an iterable or sequenced written down. Is there anything missing or unclear in that?
I feel like I remember having a rundown of all the containers that Matplotlib expects, but I can't remember any other details.