Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Dec 02 2020 08:54
    samuelsinayoko opened #40
  • Aug 24 2020 07:48
    cool-RR opened #39
  • Aug 21 2018 21:43
    kdorr opened #38
  • Aug 21 2018 21:40
    kdorr opened #37
  • Aug 21 2018 21:40
    kdorr opened #36
  • Aug 21 2018 21:39
    kdorr opened #35
  • Aug 21 2018 18:50
    palnabarun synchronize #34
  • Aug 21 2018 18:28
    palnabarun synchronize #34
  • Aug 21 2018 04:36
    palnabarun synchronize #18
  • Aug 21 2018 01:27
    palnabarun opened #34
  • Aug 21 2018 01:24
    palnabarun assigned #33
  • Aug 21 2018 01:24
    palnabarun opened #33
  • Aug 20 2018 23:55
    kdorr synchronize #24
  • Aug 20 2018 23:52
    kdorr synchronize #26
  • Aug 20 2018 23:51
    kdorr synchronize #23
  • Aug 20 2018 23:47
    kdorr synchronize #25
  • Aug 20 2018 22:22
    kdorr synchronize #22
  • Aug 20 2018 21:49
    kdorr synchronize #24
  • Aug 20 2018 21:36
    kdorr synchronize #26
  • Aug 20 2018 00:03
    story645 closed #21
kdorr
@kdorr
It's going pretty well. I have the convert_quantitative() function pretty much working and done. I haven't implemented support for aggregate functions yet. Right now, I'm working on adding the convert_temporal() function. I'm not very happy with the organization of my code right now, but I'm working to just get something written first and then I'll go back and refactor.
hannah
@story645
Oh! Forgot to tell you but I expect aggregate functions to happen way down the timeline
so ok to not worry about 'em/throw a not implemented error for now
olease open a PR on convert_quant
kdorr
@kdorr
I’ve made PRs for convert quant and convert temporal. Should I refactor/clean up what I have, or is there something else I should work on?
hannah
@story645
awesome. @tacaswell or I will figure out how to get travis to work
does this week Friday at 11:00 work for @/all ?
kdorr
@kdorr
I'm out of town on Friday.
hannah
@story645
ok, will put out a doodle for tomorrow and thursday
hannah
@story645
also @kdorr and @palnabarun the next step is getting the convertors working with an axis - so setting up ticks and the like for the data
hannah
@story645
sorry, forgot to give you the hangout
Nabarun Pal
@palnabarun
Is the meeting now?
hannah
@story645
should be
Nabarun Pal
@palnabarun
Okay. Joining.
hannah
@story645
did doodle not send you an invite?
kdorr
@kdorr
I didn't get an invite.
hannah
@story645
eek, sorry!
Nabarun Pal
@palnabarun
No.
hannah
@story645
also give me a minute 'cause I can't seem to get anything working
@palnabarun try again
Nabarun Pal
@palnabarun
I am trying to get in using my Gmail ID. My university account doesnot not support Meet.
hannah
@story645
ok, the metting got rescheduled for 1:40 and I'm gonna see if I can switch to hangouts 'cause meet is annoying
Nabarun Pal
@palnabarun
1:40EDT?
hannah
@story645
yes
Nabarun Pal
@palnabarun
Okay
hannah
@story645
thanks
hannah
@story645
let me know if it doesn't work
hannah
@story645
#5 is breaking for the same reasons as @kdorr 's PRs
Nabarun Pal
@palnabarun
I think #5 is breaking because of reduced code coverage.
Test's are passing for me
hannah
@story645
ack, sorry I meant #9
hannah
@story645
Hi @kdorr , @palnabarun already saw this but someone online was asking for the matplotlib/Altair code comparisons. Would both of you be interested in making blog posts with your comparisons? (Numfocus would likely promote them)
Also, are you both available next Monday 10AM est for a call in/check?
kdorr
@kdorr
I'd be open to writing a blog post. To make sure I'm on the same page, do you mean code comparisons where we show the code that produces the same plot in both Matplotlib and Altair?I'm available at that time for a call.
hannah
@story645
Yup, code comparisons that show the same plot using matplotlib and Altair
hannah
@story645
also a reminder that mpl-altair is Python 3 only
Nabarun Pal
@palnabarun
Hi, on a close look at the master branch, I saw that most of the code implemented in palnabarun/encodings is not there in mpl-altair/master . Is it supposed to be like that? Also, the same is true about some of the tests.
Some files are missing too, like _utils.py and tests/test_utils.py
kdorr
@kdorr

There were a lot of merge conflicts because of the two different approaches. A few meetings ago, I think we said we wanted to use the encoding conversion part from palnabarun/encodings and the data extraction/chart reading part from kdorr/convert-temporal and kdorr/convert-numeric, which is what I tried to do in the merge.

As for _utils.py and test_utils.py, since the way that kdorr/convert-temporal and ‘kdorr/convert-numeric` extract the data from the chart didn’t require reading any urls, the functions in _utils.py weren’t being used after the merge.

Nabarun Pal
@palnabarun
Ah. Okay.
But _utils.py had code to handle cases where the user gave an online dataset as a source.
kdorr
@kdorr
Oops! You're right. I overlooked that way to specify data in an Altair chart.
Sorry about that! We should put _utils.py back.