sorry, forgot to give you the hangout
@palnabarun try again
let me know if it doesn't work
Test's are passing for me
Also, are you both available next Monday 10AM est for a call in/check?
also a reminder that mpl-altair is Python 3 only
Some files are missing too, like
_utils.py and tests/test_utils.py
There were a lot of merge conflicts because of the two different approaches. A few meetings ago, I think we said we wanted to use the encoding conversion part from palnabarun/encodings and the data extraction/chart reading part from kdorr/convert-temporal and kdorr/convert-numeric, which is what I tried to do in the merge.
As for _utils.py and test_utils.py, since the way that kdorr/convert-temporal and ‘kdorr/convert-numeric` extract the data from the chart didn’t require reading any urls, the functions in _utils.py weren’t being used after the merge.
But
_utils.py had code to handle cases where the user gave an online dataset as a source.
Sorry about that! We should put
_utils.py back.
And integrate with the way currently data is being handled.
sorry forgot to add it on the invite
@kdorr don't want to sidetrack you, but the powernorm code might be in your wheelhouse ( or throw a not implemented error for now) https://github.com/matplotlib/matplotlib/blob/cf38546d06e53e640215fdba1105ba8e5fd5d3b8/lib/matplotlib/colors.py#L1169
it very possibly would have been quicker/easier to set up the docs using sphinx, but you've got a page now: https://matplotlib.org/mpl-altair/