Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
    Homa Wong
    @unional
    Hi @mattsawyer77
    Matt Sawyer
    @mattsawyer77
    hey. sorry i'm just now getting around to this. been insanely busy with other things lately.
    Homa Wong
    @unional
    No problem. We all are. :) I don't have too much time on improving the project either. You mentioned that you are not using atom right now. What are you using? I'm using atom, vscode and phpstorm. Seems like vscode is getting better. :smile:
    As for the project, I propose to refactor the code into environment (for handling p4 availability, is-in-client, etc), platform (for handling activation and subscription), and atom-perforce for business logic (all actions in one file, or one action per file as they are isolated). Currently it is a bit hard for me to address existing issues because I don't know where to add the code without making it more tangled.
    Not to say it is tangled right now, just foresee it will be a bit messy if we don't refactor it now.
    Matt Sawyer
    @mattsawyer77
    sounds good to me. yah this was kind of a dog food project I threw together quickly. and it could use some love as you suggested.
    I enjoyed using Atom, but now I'm back to my workhorse, vim (actually neovim, now that they've implemented some core functionality I've always wanted). I'd been using vim-mode in Atom which was pretty decent, but I kept bumping up against limitations with it and kept getting frustrated.
    I have also figured out a workflow (and some custom tooling) for using git inside a perforce workspace. So I'm mostly interacting only with git now.
    Homa Wong
    @unional
    Are you referring to git-p4? or another way? I would prefer to use git over p4 also. Had used git-p4 for a while, but not using it at the moment because of some environment changes and our codebase is huge with deep history, meaning I have to get only partial history into git and tracing history has to fall back to p4v and that is cumbersome for me.
    Matt Sawyer
    @mattsawyer77
    it seems that git-p4 wasn't going to work well for our situation -- but I might revisit it later. we have the same thing going on, giant monolithic depot with millions of changelists. I decided since I'm just using git for myself, I didn't need to import history. so I've developed a workflow and a few scripts to assist and its worked ok so far.
    Homa Wong
    @unional
    Hi Matt, do you see it as an option to write the package in TypeScript?
    Matt Sawyer
    @mattsawyer77
    I'm fine with that -- though I have not yet done any TS myself.
    Homa Wong
    @unional
    It is pretty simple, specifically I only use ES6 syntax + type system. You get better code completion and error checks out of it. The only thing I miss is that tslint is not as good as eslint yet.
    Matt Sawyer
    @mattsawyer77
    I've been wanting to learn ES6 and either TypeScript or Flow but haven't had a good opportunity. You have my blessing! Hopefully I'll get a chance to work on it soon too.
    Homa Wong
    @unional
    Thanks. I need to do some plumbing work first so that anyone can write atom package in typescript. Once that is done I'll let you know
    Homa Wong
    @unional
    Hi Matt, I have added the typings for atom. It might still have some problem as I need to better test it, but might able to write it in TypeScript soon.
    Homa Wong
    @unional
    Thanks. I need to do some plumbing work first so that anyone can write atom package in typescript
    Wow, I said that in Feb?
    Matt Sawyer
    @mattsawyer77
    cool, looking forward to seeing it.
    Homa Wong
    @unional
    Discover some issues with the atom typings. You can track it here: https://github.com/typed-typings/env-atom
    Ramkumar Ramachandra
    @artagnon
    vscode is definitely getting better, although it currently has some nasty bugs and limitations.
    I’m not sure what to think of the vscode codebase. To add a property to a DOM object, you have to edit six places.