Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Feb 10 2018 19:32

    maxjacobson on boooooo

    (compare)

  • Sep 09 2017 23:28

    maxjacobson on green

    Unlock some test dependencies t… Remove vine vines are still vi… (compare)

  • Sep 03 2017 18:58
    maxjacobson closed #15
  • Sep 03 2017 18:58
    maxjacobson closed #62
  • Jul 01 2017 14:45

    maxjacobson on testo

    Some great commit (compare)

  • Jul 01 2017 14:45

    maxjacobson on testo

    (compare)

  • Jun 01 2017 16:50
    maxjacobson unlabeled #60
  • Jun 01 2017 16:50
    maxjacobson closed #60
  • Jun 01 2017 16:50
    maxjacobson labeled #60
  • Jun 01 2017 16:50
    maxjacobson reopened #60
  • Feb 20 2017 22:17

    maxjacobson on oliver

    (compare)

  • Feb 20 2017 22:17

    maxjacobson on edge

    Update spec because john oliver… Update rubocop (compare)

  • Feb 20 2017 22:17
    maxjacobson closed #100
  • Feb 20 2017 22:03

    maxjacobson on oliver

    Update rubocop (compare)

  • Feb 20 2017 22:03
    maxjacobson synchronize #100
  • Feb 20 2017 21:57
    maxjacobson opened #100
  • Feb 20 2017 21:57

    maxjacobson on oliver

    Update spec because john oliver… (compare)

  • Dec 20 2016 18:29
    maxjacobson unassigned #62
  • Sep 01 2016 16:14

    maxjacobson on fix-tests

    bump (compare)

  • Sep 01 2016 16:14
    maxjacobson closed #99
Máximo Mussini
@ElMassimo
hahaha
Max Jacobson
@maxjacobson
require ‘film_snob’
FilmSnob.new('https://www.youtube.com/watch?v=qZv-iByJvBE').html #=> "<iframe width=\"480\" height=\"270\" src=\"http://www.youtube.com/embed/qZv-iByJvBE?feature=oembed\" frameborder=\"0\" allowfullscreen></iframe>”
Máximo Mussini
@ElMassimo
Now we are talkin'
Thanks Max
Max Jacobson
@maxjacobson
it has a nice “compose mode” for comfortably writing multi-line messages without worrying about submitting
no problem Max!
that doubles as a song recommendation
wow, clicking the link in the mac app didn’t kick over to the browser, that’s cool
Máximo Mussini
@ElMassimo
:rocket:
Victor Justo V.
@vjustov
Hey max i made the pull request for vine
Victor Justo V.
@vjustov
Oh, sorry i just noticed you already merged it!
Max Jacobson
@maxjacobson
yes! Thanks again @vjustov
Victor Justo V.
@vjustov
Hey Max, i was taking a look at #40 what is it that you'd like to change?
Max Jacobson
@maxjacobson

hey @vjustov,

I guess I'm just wondering if there is a better way to do this: https://github.com/maxjacobson/film_snob/blob/master/lib/film_snob.rb#L22-L28

the goal of that implementation was to forward those method calls to the internal VideoSite object. I implemented a kind of simple method forwarding system, but I learned late that Ruby provides one as well, so i thought it might be nice to use that instead

Victor Justo V.
@vjustov
yes, using forwardable is a lot cleaner and lowers the LOC count.
Victor Justo V.
@vjustov
Also i was taking a look a at ::UrlToVideo and i noticed that it just serves as sort of a parser for the url and then holds the video site. why dont we move that behavior to a class method in VideoSite ?
Max Jacobson
@maxjacobson
I guess I was reticent to give too many responsibilities to that class. It's mostly responsible for communicating with its oembed endpoint right now
Victor Justo V.
@vjustov
How about renaming UrlToVideo to Video. and the usage could be Video.from_url "youtube.com/....";
Luis Urraca
@lurraca
Hey @maxjacobson, I don't know why the build isn't passing on Travis CI. Any ideas?
Max Jacobson
@maxjacobson
Possible rubocop failures. Try running bundle exec rubocop
Falling asleep, thanks ya both
Luis Urraca
@lurraca
30 files inspected, no offenses detected
Finished in 0.16058 seconds (files took 0.98298 seconds to load)
33 examples, 0 failures
tomorrow if you could take a look
Max Jacobson
@maxjacobson
Oh... Maybe rubygems is down
Luis Urraca
@lurraca
How can I rerun the travis process?
It goes automatically
?
it looks like is a rubygem issue
Max Jacobson
@maxjacobson
Yeah, with every push
Luis Urraca
@lurraca
An error occurred while installing rspec-support (3.1.2), and Bundler cannot
Yes on the build's detail screen, there is a button "⟳ Restart Build"
apparently there’s a button
that you can click to restart build
Max Jacobson
@maxjacobson
Only I can click it?
Luis Urraca
@lurraca
looks like it
I don’t have it.
Max Jacobson
@maxjacobson
Ok it's done. Goodnight
Luis Urraca
@lurraca
Thanks.
@maxjacobson it errored again. Try tomorrow, looks like rubygem is acting up.
Max Jacobson
@maxjacobson
K
Luis Urraca
@lurraca
@maxjacobson I guess it has to do with the enconding.
I will push a commit for it
Luis Urraca
@lurraca
@maxjacobson I don’t know what its going on. :(
Travis doesn’t seem to be running the build.
Max Jacobson
@maxjacobson
released a new version with the recent spree of sweet contributions :smile:
here’s a roundup for the curious https://github.com/maxjacobson/film_snob/releases
Victor Justo V.
@vjustov
Yay!