These are chat archives for mbleigh/acts-as-taggable-on

12th
Jul 2016
Abdelkader Boudih
@seuros
Jul 12 2016 13:23
@rbritom , we probably need to fix the ugly queries soon , with Arel.
Radhames Brito
@rbritom
Jul 12 2016 13:23
thats my vote
its currently attempting the same thing arel does
Abdelkader Boudih
@seuros
Jul 12 2016 13:25
i'm ready to drop support until 4.2 if that make things easier
Radhames Brito
@rbritom
Jul 12 2016 13:26
we just need to make sure they are composable with what ever AR already does
Krzysztof Rybka
@krzysiek1507
Jul 12 2016 13:26
Hi guys
Abdelkader Boudih
@seuros
Jul 12 2016 13:26
Hi @krzysiek1507
thank you both for your work on AATO.
i want to release a prerelease as soon as possible
Krzysztof Rybka
@krzysiek1507
Jul 12 2016 13:28
There are 2 bugs in rails 5.0.0
Abdelkader Boudih
@seuros
Jul 12 2016 13:28
the build is not failling in mysql2 and AR 4.0/1
yes, i'm aware of that
we can use your patch for the prerelease
Radhames Brito
@rbritom
Jul 12 2016 13:28
the nested joins one and which is the other?
Abdelkader Boudih
@seuros
Jul 12 2016 13:28
no
Krzysztof Rybka
@krzysiek1507
Jul 12 2016 13:29
array passed as argument to scope
Radhames Brito
@rbritom
Jul 12 2016 13:29
ok, im not in the loop then
ah sure
Abdelkader Boudih
@seuros
Jul 12 2016 13:29
rails/rails#25702
and rails/rails#25653
Radhames Brito
@rbritom
Jul 12 2016 13:30
the first one I was aware of
we can use this patch if it really a bug
Krzysztof Rybka
@krzysiek1507
Jul 12 2016 13:33
I can create PR but about 9 p.m UTC. If you have time now, just copy this copy and create PR
Abdelkader Boudih
@seuros
Jul 12 2016 13:34
ok, i can do it using github inline edit
Krzysztof Rybka
@krzysiek1507
Jul 12 2016 13:36
Ok, thanks
Krzysztof Rybka
@krzysiek1507
Jul 12 2016 13:51
@seuros are you going to release the prerelease today?
Abdelkader Boudih
@seuros
Jul 12 2016 13:52
you think we should ?
Krzysztof Rybka
@krzysiek1507
Jul 12 2016 13:56
We should wait for 5.0.x with fixed but we could release with info about these bugs
Abdelkader Boudih
@seuros
Jul 12 2016 13:56
prerelease need to get installed manually
so bundle update won't upgrade
we can have a warning in the Upgrading.md
Krzysztof Rybka
@krzysiek1507
Jul 12 2016 13:57
Yeah, I know, but we should point out about known bugs
Abdelkader Boudih
@seuros
Jul 12 2016 13:57
i agree
Krzysztof Rybka
@krzysiek1507
Jul 12 2016 15:53
@seuros please ping me right after prerelease is released
Abdelkader Boudih
@seuros
Jul 12 2016 15:53
i will ping you before