Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
    Abdelkader Boudih
    @seuros
    https://github.com/krzysiek1507/acts-as-taggable-on/blob/1c1da29375ea1fbcc30e8055fe068c6a1bc43605/lib/acts_as_taggable_on/tagging.rb
    we can use this patch if it really a bug
    https://github.com/krzysiek1507/acts-as-taggable-on/blob/1c1da29375ea1fbcc30e8055fe068c6a1bc43605/lib/acts_as_taggable_on/tagging.rb#L12-L16
    Krzysztof Rybka
    @krzysiek1507
    I can create PR but about 9 p.m UTC. If you have time now, just copy this copy and create PR
    Abdelkader Boudih
    @seuros
    ok, i can do it using github inline edit
    Krzysztof Rybka
    @krzysiek1507
    Ok, thanks
    Krzysztof Rybka
    @krzysiek1507
    @seuros are you going to release the prerelease today?
    Abdelkader Boudih
    @seuros
    you think we should ?
    Krzysztof Rybka
    @krzysiek1507
    We should wait for 5.0.x with fixed but we could release with info about these bugs
    Abdelkader Boudih
    @seuros
    prerelease need to get installed manually
    so bundle update won't upgrade
    we can have a warning in the Upgrading.md
    Krzysztof Rybka
    @krzysiek1507
    Yeah, I know, but we should point out about known bugs
    Abdelkader Boudih
    @seuros
    i agree
    Krzysztof Rybka
    @krzysiek1507
    @seuros please ping me right after prerelease is released
    Abdelkader Boudih
    @seuros
    i will ping you before
    Krzysztof Rybka
    @krzysiek1507
    @seuros do you need any help?
    Abdelkader Boudih
    @seuros
    @krzysiek1507 i'm here now
    sorry for delay.
    Cody Loyd
    @codyloyd
    so... is there any way to get this gem working with rails/activerecord 5?
    Cody Loyd
    @codyloyd
    nevermind.. pulling it from the git source works
    Krzysztof Rybka
    @krzysiek1507
    @seuros what do we need to do before release?
    Abdelkader Boudih
    @seuros
    Update the changelog.
    if there is any other PR that could be added to the build, let me know
    Krzysztof Rybka
    @krzysiek1507
    @seuros this one mbleigh/acts-as-taggable-on#770
    Abdelkader Boudih
    @seuros
    oh awesome :)
    i will release the prerelease without changelog, then once people test it, i release the final version.
    wdyt ?
    Krzysztof Rybka
    @krzysiek1507
    Ok
    Krzysztof Rybka
    @krzysiek1507
    @seuros tests are passed
    Abdelkader Boudih
    @seuros
    merged
    Krzysztof Rybka
    @krzysiek1507
    Thanks
    Abdelkader Boudih
    @seuros
    this gem has very bad performance when it scale
    i will release a better one soon.
    Krzysztof Rybka
    @krzysiek1507
    Is it public?
    Abdelkader Boudih
    @seuros
    yes, it will be public. I have to extract it from one of my app
    you using Postgresql ?
    Krzysztof Rybka
    @krzysiek1507
    yes
    Abdelkader Boudih
    @seuros
    perfect
    because it will support just pg
    Krzysztof Rybka
    @krzysiek1507
    Why?
    Abdelkader Boudih
    @seuros
    so we don't end up in the same problem as we are now
    Krzysztof Rybka
    @krzysiek1507
    Did you marked the prerelease as public?
    We have got this gem in spree and we support mysql too
    Abdelkader Boudih
    @seuros
    hmm.
    Krzysztof Rybka
    @krzysiek1507
    Have you got raw pg SQLs?
    Abdelkader Boudih
    @seuros
    for what ?
    Krzysztof Rybka
    @krzysiek1507
    In this new gem
    Abdelkader Boudih
    @seuros
    @krzysiek1507 , unrelated https://rubygems.org/gems/acts-as-taggable-on/versions/4.0.0.pre
    Krzysztof Rybka
    @krzysiek1507
    Tag in github?