Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
    Krzysztof Rybka
    @krzysiek1507
    Have you got raw pg SQLs?
    Abdelkader Boudih
    @seuros
    for what ?
    Krzysztof Rybka
    @krzysiek1507
    In this new gem
    Abdelkader Boudih
    @seuros
    @krzysiek1507 , unrelated https://rubygems.org/gems/acts-as-taggable-on/versions/4.0.0.pre
    Krzysztof Rybka
    @krzysiek1507
    Tag in github?
    Abdelkader Boudih
    @seuros
    it was tagged
    i will update the readme now
    it has some outdated info now
    Krzysztof Rybka
    @krzysiek1507
    I can't see tag on Github
    Abdelkader Boudih
    @seuros
    https://github.com/mbleigh/acts-as-taggable-on/releases/tag/v4.0.0.pre
    Krzysztof Rybka
    @krzysiek1507
    Thanks!
    Ping me or give me an access to new gem as soon as you can
    Krzysztof Rybka
    @krzysiek1507
    @seuros are you going to release stable 4.0?
    Abdelkader Boudih
    @seuros
    yes , tomorrow morning
    Krzysztof Rybka
    @krzysiek1507
    Thanks!
    Abdelkader Boudih
    @seuros
    releasing now
    Krzysztof Rybka
    @krzysiek1507
    @seuros have you released it?
    Abdelkader Boudih
    @seuros
    @krzysiek1507 it on the wild
    Krzysztof Rybka
    @krzysiek1507
    @seuros thanks. Do you have any progress with new gem?
    Keisuke Izumiya
    @syguer
    hi
    Keisuke Izumiya
    @syguer
    no one is here...?
    Keisuke Izumiya
    @syguer
    hmm...
    Radhames Brito
    @rbritom
    @syguer hi
    @syguer hi >.<
    Keisuke Izumiya
    @syguer
    @rbritom oh sorry, thanks reply
    I want to check mbleigh/acts-as-taggable-on#821 out by you :)
    Keisuke Izumiya
    @syguer
    And acts-as-taggable-pn looks like not be maintained active :cry:
    So I want to maintain it. Can you add me to collaborators and gem owners?
    Abdelkader Boudih
    @seuros
    @syguer you are changing the behavior of the method: create! will raise a exception.
    Keisuke Izumiya
    @syguer
    thanks for check. OK, I understand find_or_create should not raise an exception.
    I'll change approach to fix problem what I really want to fix. thanks.
    Keisuke Izumiya
    @syguer
    @seuros I open another PR again. Would you check this please? mbleigh/acts-as-taggable-on#822
    Abdelkader Boudih
    @seuros
    what the bug that you are trying to fix ?
    Keisuke Izumiya
    @syguer
    when add too long tag name to tag_list, and call taggable.save!, it raises ActiveRecord::RecordInvalid: Validation failed: Tag can't be blank
    It occurs by this line. tag has no id when tag name is invalid.
    https://github.com/mbleigh/acts-as-taggable-on/pull/822/files#diff-6fb8d10ba793f1b09e64f2923988ee4eR413
    #822 's spec patch can reproduce it.
    Abdelkader Boudih
    @seuros
    you should sanitize your tag list with a parser
    inherit it and apply your rules https://github.com/mbleigh/acts-as-taggable-on/blob/master/lib/acts_as_taggable_on/default_parser.rb
    Keisuke Izumiya
    @syguer
    I understand you say. but I think this is not my rule.
    https://github.com/mbleigh/acts-as-taggable-on/blob/master/lib/acts_as_taggable_on/tag.rb#L13
    hmm... Parser should know validation rules?
    Abdelkader Boudih
    @seuros
    Parser will delete anything that don’t match your rules
    like the format
    also you have to have validations in the frontend before it reach the server
    Who is tagging with more than 255 char ?
    Keisuke Izumiya
    @syguer
    I agree we should have validations in the frontend. And I know nobody tagging with more than 255 characters(without cracker :worried: ).
    But the issue I said is clearly weird behavior. can't I fix this on gem code?
    If you can't accept, I'm going to give up :cry:
    Abdelkader Boudih
    @seuros
    It will break people code. They don’t expect a exception there.
    Keisuke Izumiya
    @syguer
    I understand. OK, thank you for discussion :smile:
    Piero Dotti
    @ProGM

    @seuros I'm having lots issues with the ActsAsTaggableOn::Taggable::Cache module.
    I honestly think that injecting it in "when required" is indeed a BAD idea.

    I'm talking about this:
    https://github.com/mbleigh/acts-as-taggable-on/blob/8e64c3d4a81cfbb8af621228eae36a65c1f94501/lib/acts_as_taggable_on/taggable/cache.rb#L38

    a few months ago I submitted a PR to fix a bug about it:
    mbleigh/acts-as-taggable-on#806

    But still is creating problems

    Abdelkader Boudih
    @seuros
    Let me check this