Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
    Piero Dotti
    @ProGM
    With certain conditions, the caching methods do not trigger (still investigating)
    Abdelkader Boudih
    @seuros
    i was planing in releasing a new version now. Let do it now.
    I dropped support for old versions of AR, so we can cleanup the code.
    can you test master with your test suite ? @ProGM
    Piero Dotti
    @ProGM
    ok, let's try :)
    Radhames Brito
    @rbritom
    Good morning
    Piero Dotti
    @ProGM
    It's not resolving...
    I'm trying to create a test case for this.
    Radhames Brito
    @rbritom
    I saw this issue
    I can investigate
    and provide a fix
    Abdelkader Boudih
    @seuros
    What do you think about having a outout config to remove cache ?
    opt-out
    Piero Dotti
    @ProGM
    Or maybe a opt-in
    acts_as_taggable_on :tags, caching: true ?
    Abdelkader Boudih
    @seuros
    i can’t do opt-in, that will break the upgrades.
    Piero Dotti
    @ProGM
    I see
    correct
    It makes sense
    Ok, an opt-out is ok, if well documented
    Radhames Brito
    @rbritom
    @ProGM you fix seemed to make sense, what new problem are you getting now?
    I mean after you PR was merge
    Piero Dotti
    @ProGM
    Indeed it fixes that bug
    But the caching module is still creating issues because it's loaded in runtime
    For instance:
    with "certain conditions" (I'm investigating), the "cached_tag_list" column is ignored
    Abdelkader Boudih
    @seuros
    i want to test master in spree codebase.
    Radhames Brito
    @rbritom
    that should not be hard
    Piero Dotti
    @ProGM
    I think I found a way to demostrate it:
    mbleigh/acts-as-taggable-on#830
    @seuros
    Piero Dotti
    @ProGM
    Uhm, I think I discovered the problem.
    Here
    Before trying to check if the cached_tag_list column is defined, add_custom_context is called
    by loading the taggings:
    so it performs a query
    even if cached_tag_list is present.
    Piero Dotti
    @ProGM
    So if you have a:
    MyModel.all.each { |e| e.tag_list } <-- this performs n+1 queries even if caching is enabled
    D:
    Abdelkader Boudih
    @seuros
    yeah
    Radhames Brito
    @rbritom
    this should happen only on the first call to custom_contexts
    Piero Dotti
    @ProGM
    Yes, but it's an instance method
    Piero Dotti
    @ProGM
    @seuros I committed a possible fix: mbleigh/acts-as-taggable-on#830
    J. Mark Locklear
    @marklocklear
    Hey folks! I asked this question on SO a few days ago:
    Any ideas? Should I be able to use dependent: :destroy ?
    Abdelkader Boudih
    @seuros
    @marklocklear it the default behavior , you don’t need to set it
    Tomek Rabczak
    @tomekr
    :wave: I opened an issue, but also wanted to double check with you all that this wasn't possible via another means mbleigh/acts-as-taggable-on#995
    the query is chained into a set of queries, so was looking for something that returned a relation