These are chat archives for mdedetrich/scala-json-ast

6th
Apr 2016
Matthew de Detrich
@mdedetrich
Apr 06 2016 00:05
@/all Okay guys, I have just pushed the latest version of scala-json-ast. The major change is that JNumber is now represented internally as a String. Its checked at runtime with a regex to make sure its a legitimate Json Number (according to the spec), and it also has unlimited precision due to it being stored as a String. Equals and hashcode also respect proper number equality (thanks @Ichoran ), however the hashcode may need a bit more work to make improve the performance of the hash and make it more consisitent
@travisbrown This will also fix your concern with doing JNumber(“34234e3452058230532”).to[BigInt]
This will be probably be the final revision of the AST, so people can start using it safely. The only additions that need to be done is some tests, and any future changes shouldn't hurt binary compatibility (hashcode doesn’t care about binary compatibility)
eugene yokota
@eed3si9n
Apr 06 2016 00:30
sjson-new is not April fools, it's meant to be a bridge towards new AST from existing
eugene yokota
@eed3si9n
Apr 06 2016 00:37
as per JNumber with String, I think it's cool
Matthew de Detrich
@mdedetrich
Apr 06 2016 00:40
Ah I see, I only glossed overy it really quickly and saw the remark about everyone creating their own JSON library
eugene yokota
@eed3si9n
Apr 06 2016 00:42
it's AST-less like Jawn