Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Jun 07 18:35
    Jacke commented #50
  • Sep 06 2019 10:44
    mdedetrich commented #48
  • May 28 2019 10:01
    remimi edited #50
  • May 28 2019 10:01
    remimi opened #50
  • May 25 2019 12:10

    mdedetrich on master

    Minor improvements (compare)

  • May 25 2019 09:02
    mdedetrich commented #41
  • May 25 2019 09:00

    mdedetrich on master

    Use Some constructor instead of… (compare)

  • May 25 2019 08:54

    mdedetrich on master

    Make case classes final (compare)

  • May 25 2019 08:38

    mdedetrich on master

    Apply and run scalafmt (compare)

  • May 19 2019 21:47
    christobill commented #48
  • May 19 2019 21:42
    christobill synchronize #49
  • May 19 2019 15:15
    christobill opened #49
  • May 19 2019 15:11
    christobill edited #48
  • May 19 2019 15:10
    christobill opened #48
  • May 19 2019 13:07
    christobill commented #47
  • May 19 2019 13:00
    christobill closed #46
  • May 18 2019 09:18
    mdedetrich commented #41
  • May 17 2019 14:12
    stewSquared commented #41
  • May 16 2019 08:31
    mdedetrich commented #47
  • May 16 2019 08:30

    mdedetrich on master

    [#46] Set up fatal warnings com… Merge pull request #47 from chr… (compare)

Matthew de Detrich
@mdedetrich
It should be there, next release should use proper versioning
Leonard Ehrenfried
@leonardehrenfried
@mdedetrich what happened during the release? do i need to adjust the release steps?
Leonard Ehrenfried
@leonardehrenfried
@mdedetrich good news, the 0.2.0 branch has been running in production at my current contract for ~ 1 week and no bugs were found. tickling along like a well oiled machine. well done!
Leonard Ehrenfried
@leonardehrenfried

@mdedetrich sorry, me again. would you be able to add a release of 0.2.1 or 0.2.2 to maven central please?

i'd really like to stop compiling the client from scratch on every ci build.

thanks!

Matthew de Detrich
@mdedetrich
@leonardehrenfried Was busy all weekend, I will add a release now
I am getting used to this sbt-release stuff right now as well, so I think I was doing it wrong
Matthew de Detrich
@mdedetrich
I just published 0.2.1 manually, next release will be 0.2.2 and it should work automatically with sbt-release now
Leonard Ehrenfried
@leonardehrenfried
fantastic! thanks for your help!
Leonard Ehrenfried
@leonardehrenfried
@mdedetrich hey, sorry to be annoying, but it appears that you only released 0.2.1 for scala 2.11: http://search.maven.org/#search%7Cga%7C1%7Cg%3A%22org.mdedetrich%22%20AND%20a%3A%22stripe-scala_2.12%22
Matthew de Detrich
@mdedetrich
@leonardehrenfried woops, let me do it for 2.12, will be up in an hour
Leonard Ehrenfried
@leonardehrenfried
great!
Leonard Ehrenfried
@leonardehrenfried

@mdedetrich i took the liberty to sneak in two very small commits directly to master:

  • mdedetrich/stripe-scala@0b1a656
  • mdedetrich/stripe-scala@ea0b2c8

Hope that is okay.

Matthew de Detrich
@mdedetrich
Yup thats fine
Leonard Ehrenfried
@leonardehrenfried
@mdedetrich would you mind creating a release with this week's changes?
Matthew de Detrich
@mdedetrich
@leonardehrenfried Making a release now
Matthew de Detrich
@mdedetrich
@leonardehrenfried sbt-release seems to be doing something weird, look at mdedetrich/stripe-scala#34
Matthew de Detrich
@mdedetrich
@leonardehrenfried I tried incorporating the changes into the build.sbt, I released 0.2.2 manally
Leonard Ehrenfried
@leonardehrenfried
@mdedetrich Okay, thanks and sorry for the hassle you've had. Hopefully it'll work next time.
Leonard Ehrenfried
@leonardehrenfried
@mdedetrich didn't you want to release 0.2.3?
Matthew de Detrich
@mdedetrich
@leonardehrenfried Yeah something came up on the weekend, will do it tonight, sorry for the delay
Matthew de Detrich
@mdedetrich
@leonardehrenfried I actually realised I was doing some work for fixing documentation, I just made a PR for it
mdedetrich/stripe-scala#37
Once you approve this, we can merge into master and then release
Leonard Ehrenfried
@leonardehrenfried
Ok, i merged to master.
Ready for the release.
Matthew de Detrich
@mdedetrich
@leonardehrenfried Looks like it was released succesfully, let me know if you cant find it in an hour or so
Leonard Ehrenfried
@leonardehrenfried

ok, cool. i just saw that. well done.

so the release went through without a hitch?

Matthew de Detrich
@mdedetrich
Yup the release wen’t perfectly, I will close the issue when it appears on maven
It should be there soon
Pierce Lamb
@piercelamb
@mdedetrich currently looking at
is "handle" part of the test suite?
Matthew de Detrich
@mdedetrich
@piercelamb I don’t believe there is
At least not directly
There is also an argument that instead of handle retrying on network errors manually, we should tell users to employ a circuit breaker and instead supply a partial function to handle errors in this circuit breaker
(or we can do this circuit breaker stuff ourselves since we already depend on akka-http)
MarcoH
@mheuer
@mdedetrich : Hi. Just opened #44. It's not an issue per se, more an improvement. Let me know what you think. Planning on changing the decoder https://github.com/mdedetrich/stripe-scala/blob/master/src/main/scala/org/mdedetrich/stripe/v1/Charges.scala#L230 to a forProduct12, the encoder https://github.com/mdedetrich/stripe-scala/blob/master/src/main/scala/org/mdedetrich/stripe/v1/Charges.scala#L249 to a .forProduct13, add the mappings and add the brand attribute to the DTO case class: https://github.com/mdedetrich/stripe-scala/blob/master/src/main/scala/org/mdedetrich/stripe/v1/Charges.scala#L213
Thoughts?
Matthew de Detrich
@mdedetrich
@mheuer Yeah that sounds good, just send a PR and I will look into it
MarcoH
@mheuer
Excellent. Probably early next week.
MarcoH
@mheuer
PR is submitted. Well, that was easier than expected. Please let me know if you want me to change anything. Thanks and Happy Easter (if you celebrate it). Do you have a view when you might do another release? I'd like to use the new field as soon as possible. No stress though. ;-)
Matthew de Detrich
@mdedetrich
It will be sometime this week, I am a bit busy
but I will try and look at it tomorrow
MarcoH
@mheuer
Awesome. That is perfect. BTW, the build for PR #45 was marked as failed due to a failing build for scala 2.11. Do you want me to see how to make that build succeed on 2.11?
MarcoH
@mheuer
Done. PR #45 is now succeeding.
Derek Wene
@dwene
Any chance this PR will merge soon? mdedetrich/stripe-scala#41
Matthew de Detrich
@mdedetrich
@dwene I pinged @stewsquared but never got a response
Is this still an issue for you?
Derek Wene
@dwene
I forked your repo and pulled in @stewsquared 's commits.