Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
Steve B
@meadsteve
@rkotze it actually turned out to be smaller than I thought so the first part will be done soon. I may ask for your help reviewing it
Steve B
@meadsteve
in fact. Now done (at least the first pass): meadsteve/white-bread#31
oops meadsteve/white-bread#34 I mean
Richard Kotze (mobile)
@rkotze
Great, I will take a look soon
Richard Kotze (mobile)
@rkotze
@meadsteve posted some comments
I would like to implement the one context per feature file issue meadsteve/white-bread#33
is that cool with you?
Steve B
@meadsteve
@rkotze go for it!
I've merged my PR so you should be able to build off of master
Juan Flores
@javflores
Thanks for the feature @meadsteve ! I have already used it, nice one!
My default_context file was getting big
Steve B
@meadsteve
@javflores glad to hear it. Let me know if you run in to any bugs or if you notice anything missing that you'd like
I think @rkotze is working on adding automatic one context per feature
Richard Kotze (mobile)
@rkotze
I will start on that soon, just been busy :)
Steve B
@meadsteve
@rkotze no worries. In many ways the longer you wait the more likely any bugs I added will surface :)
Steve B
@meadsteve
@rkotze also not sure what approach you're taking but my first thought would be to create a macro that calls SuiteConfiguration. add_suite/1 for each feature file it finds
as far as I can tell this should just work as long as you populate the arguments right
all .exs files in features/contexts are autoloaded
Richard Kotze (mobile)
@rkotze
@meadsteve that was kind of the idea what I was going with but was not sure if you can have all the modules loaded in when the macro runs
but I will look into it
I was thinking of using the suite_run.ex
which would call a 'context_per_feature' module
and that would deal with creating a suite struct
mm but I will see if I can do it all with the macro
aside from that I'm going on a two week holiday from this Wednesday
won't really get time to work on it till im back
Steve B
@meadsteve
I'm not sure it needs all the modules loaded when the macro runs. You can always deal with missing modules at runtime.
So it should be able to use the existing struct for a suite
Richard Kotze (mobile)
@rkotze
So if i've not made a pull request by end of tomorrow
Steve B
@meadsteve
and just pre-populate it's values
Richard Kotze (mobile)
@rkotze
then im fine if you or someone else wants to take it on
okay cool, sounds simple enough
I'll give it a try
Steve B
@meadsteve
@rkotze well I'm happy to wait for you if you're keen to do it. It's not a feature I'd use so it's not blocking me
So it's your call really
Richard Kotze (mobile)
@rkotze
cool, I'm keen to work on it
just short on time :D
Steve B
@meadsteve
cool! I know the feeling.
Richard Kotze (mobile)
@rkotze
yeah its not blocking me at the mo
Steve B
@meadsteve
and it's always better to have someone who wants/uses a feature to implement it. You'll have a much better idea of whether it fits the need or not
so I view this as a positive
Richard Kotze (mobile)
@rkotze
nice one :+1:
Richard Kotze (mobile)
@rkotze
@meadsteve are we just updating the readme for documentation for now?
Steve B
@meadsteve
@rkotze for now yes
Adding proper documentation is something I really need to do for this to be a "real" project.
I'm trying to work myself up to starting it :-)
Richard Kotze (mobile)
@rkotze
@meadsteve thanks for getting the context per feature merged in. back from holiday now - so will look at it soon.
Liam Stupid Name Humphreys
@Angry-Potato
@meadsteve Hi! Thanks for the great library! I just raised a tiny issue to do with assertion error message formatting when using power_assert, is that something you'd be willing to look into?
Steve B
@meadsteve
@Angry-Potato thanks for the issue! I've replied there but definitely a good idea :+1:
danielfoxp2
@danielfoxp2
Hello everybody! @meadsteve, I agree with @Angry-Potato, it is a great library, thank you. I created a new issue about running a feature that do not has step definition implemented. I hope it is something interesting. Cheers!
danielfoxp2
@danielfoxp2
Hi! Is there a way to run only one feature? I made two features and set the config to context_per_feature for each one. When I run white-bread all of them is executed. Then I guessed some args like --context <name-of-the-context-file> and this almost work but white-bread parses the two features, run just the one I choose and fail because the steps of the other one is not implemented in the feature that I am running.