by

Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
    Nizamutdinov Adel
    @adelnizamutdinov
    Hi @mg6maciej
    Are you still interested in bringing java8 support for hrisey?
    Or you moving completely from java annot. proc. to groovy AST transforms?
    Maciej Górski
    @mg6maciej
    @adelnizamutdinov Hey. I would really like to have it working with Java 8. Right now I'm doing a small project in Groovy, but I'll be back to Java sooner or later. I had fixed some issues, but there are still compilation problems and I didn't have time to work on it.
    I have had a short monologue about it here: https://groups.google.com/forum/#!searchin/project-lombok/parcelable/project-lombok/DZvMfm7MFOg/wtbl5nI6B3QJ and in #1
    Nizamutdinov Adel
    @adelnizamutdinov
    @mg6maciej yess! thank you so much
    Maciej Górski
    @mg6maciej

    @adelnizamutdinov Would you like to help with the fixes?
    This is what I fixed by trial and error: mg6maciej/hrisey@2990017
    I posted list of things this commit fixes in Lombok's google group.
    I think the best way would be to remove all but one test data that fails and try to correct for it, then add another.

    If you would be interested, I can give you some pointers on how easy is to run tests. Lombok guys did a really good job there.

    Nizamutdinov Adel
    @adelnizamutdinov
    @mg6maciej I am interested in helping with this
    @mg6maciej I am completely unfamiliar with ant, is it the build.xml where you disable the tests?
    Maciej Górski
    @mg6maciej

    @adelnizamutdinov Great. I've just merged with the latest lombok version (1.16.2) and fixed one more JDK 8 related issue.
    To disable tests, I just delete them. Just for convenience, I've created a branch with only 3 tests failing, one for each annotation: https://github.com/mg6maciej/hrisey/tree/feature/minimal_number_of_tests_failing_on_jdk8
    To build and run tests, you just need to have JAVA_HOME pointing to JDK8 and run commands which are listed in .travis.yml:

    • ant setupJavaOracle7TestEnvironment
    • mkdir -p lib/test/ & cp android-lib/* lib/test/
    • ant test

    Let me know if you get it working there.
    Then to see failing tests, change to JDK 8

    • ant setupJavaOracle8TestEnvironment

    and run tests again.

    Nizamutdinov Adel
    @adelnizamutdinov
    @mg6maciej aha, got it
    for some reason gitter is not sending me emails
    oh, apparently you need to enable them on the per room basis
    Maciej Górski
    @mg6maciej
    @adelnizamutdinov Ok. So if you run tests on java 8, you will see "x -1" thing. I have absolutely no idea what's that.
    Michail Plushnikov
    @mplushnikov
    Hello Marciej, I have finally merged your PR for @Parcelable annotation into intellij-lombok-plugin! Thank you!
    Maciej Górski
    @mg6maciej
    @mplushnikov Awesome. I'll send you a pull request for Preferences annotation. I'd like to keep it in one plugin.
    mrtowel
    @mrtowel
    Hey guys, is it possible to annotate class, which extends an abstract class, with @Parcelable?
    I'm getting an error
    :compileDebugJava error: cannot find symbol symbol: method writeToParcel(Parcel,int) 1 error
    @mg6maciej ^ :)
    Maciej Górski
    @mg6maciej
    @mrtowel I don't usually use abstract classes, especially for POJOs, but you may send a pull request with abstract annotated class and expected resulting generated code to before and after-delombok and if it fails tests, I'll take a look at it.
    zlymeda
    @zlymeda
    Hi Maciej, I checked out feature branch with failing tests for java 8. However I got no failing tests when running on java 8. My java build version: 1.8.0_60-b27.
    How can I reproduce it?
    Thanks
    Maciej Górski
    @mg6maciej

    @zlymeda Hey, if you follow the steps above to run tests, you will see BUILD SUCCESSFUL at the end, but scrolling up a bit will show this:

        [junit] Testcase: ParcelableBoolean.java took 0.035 sec
        [junit]     FAILED
        [junit] Value of x -1
        [junit] junit.framework.AssertionFailedError: Value of x -1

    Thanks for looking into it. I'd like to have it finally fixed, but don't have enough time to deeply investigate this issue.

    Michail Plushnikov
    @mplushnikov

    Hello Marciej, whats about :

    @mplushnikov Awesome. I'll send you a pull request for Preferences annotation. I'd like to keep it in one plugin.

    Do you want to integrate any other annotations into the lombok_plugin? :)