Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
    Micah Stubbs
    @micahstubbs
    merged, thanks neeraj!
    nice to have consistent whitespace formatting and more concise filtering
    neerajt
    @neerajt
    looks like i missed a few of the spaces, but in any case it would've been better as a separate pull request from the filtering part
    looks like you're making some great progress on the graphs!
    Micah Stubbs
    @micahstubbs
    likely so.
    need to update those screen shots
    check out this gif screencap tool http://www.cockos.com/licecap/
    neerajt
    @neerajt
    that's pretty awesome
    Micah Stubbs
    @micahstubbs
    a nice way to show chart animation or interaction with an image
    neerajt
    @neerajt
    you could gif the data collection bar chart too
    was just looking at that code again, that was pretty nifty
    Micah Stubbs
    @micahstubbs
    yea... the guys over in https://gitter.im/lightning-viz/lightning#initial use it
    what code?
    ROI is region of interest, yes
    I always get it confused with return on investment
    Micah Stubbs
    @micahstubbs
    my first thought 💭 too
    Micah Stubbs
    @micahstubbs
    http://vimeo.com/88326173#t=24m20s next is to figure out the line-brushing input
    and match it to the other companies' lines (or the slopes calculated from the points, more specifically)
    neerajt
    @neerajt
    line brushing input?
    ohhh
    yeah that's gonna be interesting
    Micah Stubbs
    @micahstubbs
    also, imagine if Wikipedia ran on git
    neerajt
    @neerajt
    did you integrate the gsub piece?
    neerajt
    @neerajt
    i liked that you stood up for your way of doing things re: the naming columns bit
    it's a different, but no less 'right' way of doing things
    i thought that was cool
    Micah Stubbs
    @micahstubbs
    it's a ruby idea - optimize for developer happiness
    (off topic for this repo, but not yet. will add the white space stripping gsub() to the OPIS gist soon)
    neerajt
    @neerajt
    oops, ok got the two confused
    yeah so i have a suggestion for the data cleaning piece, but it may conflict with this idea of developer happiness so feel free to reject the PR
    will sendit later today
    neerajt
    @neerajt
    sent
    theres another one, but i dont think it makes sense
    i think you should just leave it as is
    it was pertaining to where you use the substr() to explicitly pluck the year from the dates
    theres another way to do it but it's more work
    Micah Stubbs
    @micahstubbs