Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
  • 12:30

    greenkeeper[bot] on codecov-3.6.1

    (compare)

  • 12:28

    greenkeeper[bot] on codecov-3.6.1

    chore(package): update codecov … chore(package): update lockfile… (compare)

  • 02:36

    greenkeeper[bot] on codecov-3.6.0

    (compare)

  • 02:34

    greenkeeper[bot] on codecov-3.6.0

    chore(package): update codecov … chore(package): update lockfile… (compare)

  • Sep 16 11:06
    stavros-zavrakas commented #392
  • Sep 16 09:53
    lmammino commented #392
  • Sep 16 09:49
    stavros-zavrakas commented #392
  • Sep 16 09:20
    Industrial commented #322
  • Sep 16 06:40
    jhecking closed #393
  • Sep 16 06:40
    jhecking commented #393
  • Sep 15 17:16

    lmammino on 1.0.0-alpha.43

    (compare)

  • Sep 15 17:13

    lmammino on fix-jest

    (compare)

  • Sep 15 17:13

    lmammino on 1.0.0-alpha

    Rewrite tests to use async/awai… (compare)

  • Sep 15 17:13
    lmammino closed #391
  • Sep 15 17:09
    lmammino synchronize #391
  • Sep 15 17:09

    lmammino on fix-jest

    Version bump (compare)

  • Sep 15 17:08
    lmammino commented #391
  • Sep 15 17:05
    lmammino synchronize #391
  • Sep 15 17:05

    lmammino on fix-jest

    One moar attempt :( (compare)

  • Sep 15 17:03
    lmammino synchronize #391
Doruk Kutlu
@d0ruk
is there a reference repo for middy integration? i.e. examples
Luciano Mammino
@lmammino
@d0ruk, Do you mean writing your own middlewares?
Doruk Kutlu
@d0ruk
no, i read the docs.md
i meant a repo where i can scan some code
Luciano Mammino
@lmammino
regarding middy internals or use cases?
Doruk Kutlu
@d0ruk
to gauge best practices
use cases
Luciano Mammino
@lmammino
@DavidWells created an example repo, it might be useful: https://github.com/DavidWells/middy-example
Doruk Kutlu
@d0ruk
cheers
Luciano Mammino
@lmammino
You are welcome, @d0ruk, let us know if there's anything that is not clear or that we can improve in your opinion :)
Doruk Kutlu
@d0ruk
will do
Jose Santacruz
@joseSantacruz
Hi all, quick serverless question is there a way to preview the generated cloud formation files without building all the artifacts??
Chanlito
@chanlito
I found middyjs today, and I have to say, thank you, to @lmammino & all the contributors.
Luciano Mammino
@lmammino
@chanlito, thanks to your for trying middy :)
@joseSantacruz did you figure it out a way? I know that serverless framework has a command to build a package but not publish it, that way you should be able to see the cloudformation files
Thomas Edwards
@thomasedwards
I just found Middy today :heart_eyes:
Just casually re-writing my entire project now
dkatavic
@dkatavic
hello @thomasedwards . I hope you are gonna find it useful :smile:
Luciano Mammino
@lmammino
@thomasedwards looking forward to receiving your feedbacks :P
Today we just passed 200 stars!!! :)
Thomas Edwards
@thomasedwards
amazing!
has anybody ever had a Cannot destructure propertyhttpContentNegotiationof 'undefined' or 'null' error?
import middy from 'middy'

const {
  httpContentNegotiation,
  httpErrorHandler
} = middy.middlewares

const lovelyStuff = event => {
  // do stuff
}

const handler = middy(lovelyStuff)
  .use(httpContentNegotiation({ availableMediaTypes: ['application/json'] }))
  .use(jsonBodyParser())
  .use(httpErrorHandler())

export { handler }
I think it's because I'm using imports
Thomas Edwards
@thomasedwards
yup changed it to
const {
  httpContentNegotiation,
  httpErrorHandler,
  jsonBodyParser,
  validator
} = require('middy/middlewares')
Thomas Edwards
@thomasedwards
so when I import anything from middy/middlewares, I get the entire AWS library because of the S3 middleware?
this bumps up my file size from less than 1MB to 3.5MB
Thomas Edwards
@thomasedwards
done some digging and opened an issue: middyjs/middy#154
Luciano Mammino
@lmammino
Hello @thomasedwards , thanks a million for your contribution and sorry for the long wait, i was away for a conference :)
looking into your issue right now
Thomas Edwards
@thomasedwards
thank you! =)
have closed it, will investigate further
Thomas Edwards
@thomasedwards
also – any thoughts about giving more information from the validator? middyjs/middy#155
I have now realised that actually just editing the validator to pass the errors through as a string
rather than using 'Event object failed validation' would be possibly safer
Luciano Mammino
@lmammino
@thomasedwards thank you for pointing that out. I am currently slowly going over all the open issues an PR in my free time. I will try to address everything later this evening
Thomas Edwards
@thomasedwards
no worries! let me know if there's anything I can do to help
have replied to your comments, thanks @lmammino ! middyjs/middy#155
Thomas Edwards
@thomasedwards
Super loving 0.12 :thumbsup: Sooo much easier to debug now with the beautiful extreme logging – thanks team! :heart:
Thomas Edwards
@thomasedwards
Okay, I think I have a really tricky problem...
In one of my middlewares I have a promise that needs to return before it can continue
however, if I add async/await to the function, I get a whole load of errors and pain
Thomas Edwards
@thomasedwards
okay I found a way
I’m returning a promise to a variable set in the middleware
I don't do any async/await in the middleware
but then I await it when I use it later on
Andrea Falzetti
@rexromae_twitter
@vladgolubev hey mate, I'm trying to understand why the change that I've done to the docs, it's still not showing in the website. Did I miss any step?
Dan Van Brunt
@iDVB
HELP! Love Middy so far. Having an issue with writing jest tests with my custom middleware written with async/await. My middleware has a proper try/catch around the await. I've looked at the ssm middleware that is part of the core for ideas. My middleware works fine when I remove that single async call to S3. But with it I keep getting UnhandledPromiseRejectionWarning
Is there some special way to implement a middleware that uses async/await
Dan Van Brunt
@iDVB
@lmammino Would love if you have a moment to chime in on this. middyjs/middy#270 Seems like a current limitation when trying to test custom middleware.