Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
    Mike Penz
    @mikepenz
    it will show up
    (just make sure to remove the _int)
    DVassilev
    @DVassilev
    Ok, well I hope the lib authors add it in as I think your library is fantastic
    but again, unreasonable to expect many to have
    Mike Penz
    @mikepenz
    if not you can make a pull-request directly on the AboutLibraries
    DVassilev
    @DVassilev
    Ok
    DVassilev
    @DVassilev
    @mikepenz is it possible to add more to the 'about version'?
    I have some custom details like buildtime and git SHA that would be nice to implement.
    And as for the buttons in the sample app, how were they added?
    DVassilev
    @DVassilev
    In addition, is there any way to tweak the animation as there is a slight pause between clicking navigation drawer and AboutLibraries appearing.
    Mike Penz
    @mikepenz
    @DVassilev where do you mean? you can define the text programmatically so you could add it there. or the version.
    the buttons were added via xml but you can also define the with the builder
    which animation? you can modify the delay how long it takes the drawer to close after clicking. this is sometimes necessary when switichng fragments
    DVassilev
    @DVassilev
    @mikepenz in the About section of the app at the top where it shows the icon, app name, version code and version name. I would like to place some extra values up there and not in the description. Is there a way to append text to the version?
    As for the buttons, what is the method in the builder to add them?
    And the AboutLibraries animation, where the info flys in. That takes a while to kick in once the drawer has closed giving a noticeable delay
    Mike Penz
    @mikepenz

    @DVassilev no only to the text.

    @DVassilev those buttons can be defined with those methods withAboutSpecial1, withAboutSpecial1Description this will result in a button with text + a dialog with text

    you can hook in listeners too via the LibsConfiguration i think it should describe itself. take a closer look at the LibsListener and the method onExtraClicked
    you can disable the animation withAnimations(false)
    Justin Hall
    @wKovacs64
    @mikepenz 5.3.1 looks to have introduced a leak. It seems that the LibsConfiguration singleton is hanging on to the parent context (Activity) via the RecyclerView animator.
    * com.example.ui.activity.SupportActivity has leaked:
    * GC ROOT static com.mikepenz.aboutlibraries.LibsConfiguration.SINGLETON
    * references com.mikepenz.aboutlibraries.LibsConfiguration.mItemAnimator
    * references android.support.v7.widget.DefaultItemAnimator.mListener
    * references android.support.v7.widget.RecyclerView$ItemAnimatorRestoreListener.this$0
    * references android.support.v7.widget.RecyclerView.mContext
    * leaks com.example.ui.activity.SupportActivity instance
    * Reference Key: 283a7eb1-af47-431b-8247-5b8b5cce4516
    * Device: Genymotion generic Google Nexus 5 - 5.1.0 - API 22 - 1080x1920 vbox86p
    * Android Version: 5.1 API: 22 LeakCanary: 1.4-SNAPSHOT 6c0bee2
    * Durations: watch=5031ms, gc=115ms, heap dump=785ms, analysis=1360ms
    Mike Penz
    @mikepenz
    @wKovacs64 thanks for the report. strange enough as the animator itself does not need the context.
    Justin Hall
    @wKovacs64
    Yeah, I'm wondering if it's a platform leak in DefaultItemAnimator.
    Didn't see anyone else mention it in LeakCanary's issue list, but there's always a first.
    Mike Penz
    @mikepenz
    i have chagned this a bit. should fix this leak
    Justin Hall
    @wKovacs64
    oh ok
    Mike Penz
    @mikepenz
    but no new version today
    Justin Hall
    @wKovacs64
    I'll have to test in my own app to see if I can reproduce it after your commit. Just tried it in the sample app and got a leak but it's a different one, looks unique to the sample so I'm ignoring it for now.
    In com.mikepenz.aboutlibraries.sample.debug:5.3.1-DEBUG:531.
    * com.mikepenz.aboutlibraries.sample.FragmentActivity has leaked:
    * GC ROOT static com.mikepenz.aboutlibraries.LibsConfiguration.SINGLETON
    * references com.mikepenz.aboutlibraries.LibsConfiguration.mListener
    * references com.mikepenz.aboutlibraries.sample.FragmentActivity$1$1.this$1 (anonymous class implements com.mikepenz.aboutlibraries.LibsConfiguration$LibsListener)
    * references com.mikepenz.aboutlibraries.sample.FragmentActivity$1.this$0 (anonymous class implements com.mikepenz.materialdrawer.Drawer$OnDrawerItemClickListener)
    * leaks com.mikepenz.aboutlibraries.sample.FragmentActivity instance
    * Reference Key: 0c303936-a4f4-4898-8f8a-d0d37d170ac2
    * Device: HTC htc HTC One_M8 tmous
    * Android Version: 5.0.1 API: 21 LeakCanary: 1.4-SNAPSHOT 6c0bee2
    * Durations: watch=5048ms, gc=150ms, heap dump=1483ms, analysis=14311ms
    Mike Penz
    @mikepenz
    @wKovacs64 i hope this is also fixed in the new version
    Justin Hall
    @wKovacs64
    "no new version today" -- yeahhhhh right :)
    Mike Penz
    @mikepenz
    ah yeah :D
    but i sent you the message after midnight
    (my time :D)
    Justin Hall
    @wKovacs64
    :grin:
    Alvar Lagerlöf
    @alvarlagerlof
    Hey, I need help
    This message was deleted
    I'm trying to use LibsSupportFragment but Android stuido complains about it not beeing a fragment
    Wrong 2nd argument found 'com.mikepenz.aboutlibaries.ui.LibsSupportFragment', required 'android.app.Fragment'
    This happened when i upgraded to version 5.6.2
    Mike Penz
    @mikepenz
    @alvarlagerlof then use the LibsFragment ;)
    the AboutLibraries offer the original android fragment, and the support.v4 fragment
    Alvar Lagerlöf
    @alvarlagerlof
    LibsFragment libsFragment = new LibsBuilder()
    .withActivityStyle(Libs.ActivityStyle.LIGHT_DARK_TOOLBAR)
    .withAboutIconShown(true)
    .withAboutVersionShown(true)
    .withActivityTitle("Open source libaries")
    .withAboutAppName(getString(R.string.app_name))
    .withAboutSpecial1(getString(R.string.app_name))
    .supportFragment();
    Does not work
    Mike Penz
    @mikepenz
    what do you mean with it does not work?
    veovuive
    @veovuive
    show missing libs ?
    Mike Penz
    @mikepenz
    @veovuive what do you mean?
    ChoeSul
    @BongJaeChoi
    library is Awsomeeeeeeee!!! Very Very useful
    Thanks you !!
    Peter Gulko
    @zTrap
    If I'm all understands right, all fields will be getted from localized string.xml?
    Kurian Vithayathil
    @kvithayathil
    Anyone used AboutLibraries with the new Android Navigation library?
    Yannick
    @THEAccess
    Only a few libaries i use are shown. How can i add the missing ones fast without needing to commit any definition files?