Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
    Luke Stewart
    @lukestewart13
    done! #50
    Kaspar Minosiants
    @minosiants
    ­čĹŹ
    Kaspar Minosiants
    @minosiants
    Luke I've fixed this issue
    could you test it to see it is fixed in your case
    I published a new version v0.6.5
    Luke Stewart
    @lukestewart13
    works like a charm! thanks
    Kaspar Minosiants
    @minosiants
    ­čĹŹ
    Mauro González
    @maurogonzalez
    Hi @minosiants thanks for all the effort, I've using pencil for the last months and works like a charm. Now I'm updating dependencies but it has libraries versions that breaks things. I can do a PR during the day to update the dependencies but I don't know what are the steps to contribute in your project.
    Kaspar Minosiants
    @minosiants
    Hello @maurogonzalez go for it. Create pr request I will merge it
    Mauro González
    @maurogonzalez
    Done @minosiants : minosiants/pencil#52
    Kaspar Minosiants
    @minosiants
    @maurogonzalez thanks a lot for this
    I published a new version
    Mauro González
    @maurogonzalez
    Thanks!
    Luis Miguel Mej├şa Su├írez
    @BalmungSan
    Hi @minosiants I opened minosiants/pencil#53
    It is still WIP but maybe you would want to pick it up from there? (since what follows are heavy API changes)
    I think it is ok if we just ask for Async at the very entry point of the library but maybe you may want to provide your own Smtp capability trait.
    Also, it would be great if users doesn't have to provide a fs2.io.file.Files capability trait if they are not using attachments.
    I would be glad to help with whatever you may need, just let me know.
    Mauro González
    @maurogonzalez

    I've just noticed that this fix: https://github.com/minosiants/pencil/commit/abcecbcc8d3bc08015bd7f4f686ca1b128fc9b61#diff-da95014a2529f37759623bc34b80c966cf402ffda0554e5cd1b258e7b5db6655 is broken. Probably derived from https://github.com/minosiants/pencil/commit/0fcba21af7c48af7da9f2f16624185678fd1b4fa#diff-da95014a2529f37759623bc34b80c966cf402ffda0554e5cd1b258e7b5db6655

    In version 0.6.5:

    // More headers
    X-SES-Outgoing: 2021.04.08-54.240.8.60
    // Empty line
    Content-Type: text/html; charset=UTF-8
    Content-Transfer-Encoding: base64
    // Empty
    // Base64 Content

    I'll take a look later

    Mauro González
    @maurogonzalez
    Well, I'm not sure about what changed the behavior but this is happening with HTML mails. If I find something, I share it.
    Mauro González
    @maurogonzalez

    Yeah, MimeType's email without attachments adds an empty line that breaks the body decoding.
    I've tested with this change:

      def emptyLine[F[_]: MonadError[*[_], Throwable]](): Smtp[F, Unit] =
        email[F].flatMap {
          case e@MimeEmail(_, _, _, _, _, _, _, _) if !e.isMultipart =>
              unit[F]
          case _ =>
            text[F](Command.end)
        }

    But I'm not sure if this breaks other stuff. I haven't tested with other cases.

    Kaspar Minosiants
    @minosiants
    Ok I will have a look
    So you are saying mime email without attachment is broken
    Kaspar Minosiants
    @minosiants
    @maurogonzalez empty line is required to divide headers from body
    could you provide data that you re using to send email
    @BalmungSan to be honest I've not yet looked into scala 3
    so have to see how pencil should reflect changes
    Kaspar Minosiants
    @minosiants
    @maurogonzalez ok I see what you mean
    you are right this is a bug
    fixing it
    Kaspar Minosiants
    @minosiants
    I opened an issue minosiants/pencil#54
    Kaspar Minosiants
    @minosiants
    @maurogonzalez I pushed fix to master
    Luis Miguel Mej├şa Su├írez
    @BalmungSan
    @minosiants the PR is for cats-effect 3, not for Scala 3.
    Kaspar Minosiants
    @minosiants
    Ok I see :-)
    @BalmungSan If I want to make changes to the branch you have created How it is usually done
    should I clone your fork ?
    I've never done it
    Luis Miguel Mej├şa Su├írez
    @BalmungSan
    @minosiants Since you are the maintainer you should be able to full fetch and then pull that branch.
    Thus something like this:
    // balmung is the name, you can use whatever you want.
    // You may also use the https uri if you prefer.
    git remote add balmung git@github.com:BalmungSan/pencil.git
    
    git fetch balmung
    git checkout upgrade-ce3
    
    // this step should not be necessary but I prefer to be sure I am on the latest changes.
    git pull balmung upgrade-ce3
    
    // work, commit, push as usual.
    Kaspar Minosiants
    @minosiants
    Ok I will try
    Luis Miguel Mej├şa Su├írez
    @BalmungSan
    :+1:
    Let me know if I can help in any way :)
    Kaspar Minosiants
    @minosiants
    sure
    Mauro González
    @maurogonzalez
    Thanks @minosiants ! Sorry about not responding but it was late in this side of the world.
    Kaspar Minosiants
    @minosiants
    @BalmungSan could you check if you pushed build.sbt
    @maurogonzalez :+1:
    Luis Miguel Mej├şa Su├írez
    @BalmungSan
    @minosiants yes I did, note that we are using an RC version of scodec-stream we shouldn't merge it to master until a final release of that is done.
    Kaspar Minosiants
    @minosiants
    I've noticed that you introduced use of ip4s-core
    cant see its dependency in build.sbt
    Luis Miguel Mej├şa Su├írez
    @BalmungSan
    Ah yeah, it is provided transitively by fs2.
    But we may want to be explicit about it.
    Not sure what is your politic according to transitive dependencies.
    Kaspar Minosiants
    @minosiants
    I agree explicit is much more preferable
    Luis Miguel Mej├şa Su├írez
    @BalmungSan
    :+1: