Why are we normalising the event? I'm asking out of curiosity. I like to understand why things work the way they work. :slight_smile:
Or with it not be able to run without them being present?
they are exposed if we need them for example
ReactDOM is used here: thttps://github.com/mint-lang/mint/tree/master/core/source
maybe if we want to allow third party React components
Oh, by the way. I had an idea this morning. :slight_smile:
Would it make sense to add a Mint version to the
mint.json file? For instance, in Mint RealWorld it errors whenever you try to run mint install due to the fact that the structure of mint.json has changed between versions.
Right now you get a helpful message saying it didn't expect the key
external-javascrips. A even more helpful message would be something like You're running Mint X but the project expects Mint Y.
the checking can be also here I think
they were generated by hand
then you don't have these kind of changes
I don't think the API have any significant changes, most of the changes were related to
_h being removed in favour of Preact.h. Since those variables are exposed to the end-user anyway and we already relied on having React and ReactDOM readily available I unified the API to a single location, Preact.
Basically giving you
Preact.h, Preact.render, Preact.Fragment and Preact.createPortal.
there is no uglification step
Well, in that case, I can revert those changes ending up with
const _h = mint.Preact.h.
If so, should everything be underscored?
No worries, being a contractor myself, I understand that work comes first. Whenever you have time. 🙂
this is where they are being generated https://github.com/mint-lang/mint/blob/master/src/js.cr#L394