These are chat archives for mirumee/saleor

14th
May 2018
Akin Adebowale
@akinadebowale
May 14 2018 04:34
Is a SPA storefront with React and GraphQL really in the works for July? If so God bless your brilliant souls. If not, God bless your brilliant souls anyway — this is an amazing project.
Patryk Zawadzki
@patrys
May 14 2018 09:05
@akinadebowale The API is being built as part of the Dashboard 2.0 effort (currently a branch)
we have yet to build the UI
zchlebicki
@zchlebicki
May 14 2018 10:27
How do you recommend to import and refresh products from other database (with images and all necessary description). Current graphQL API is insufficient for this.
Let's say tens of thousands of products.
Patryk Zawadzki
@patrys
May 14 2018 10:37
there’s currently no dedicated API for that, historically we usually went directly to the database (COPY …)
NyanKiyoshi
@NyanKiyoshi
May 14 2018 12:51

Hi! I have a question about conformity and Saleor. As I was working on merging the latest release of Saleor over our version, I still noted on my checklist an issue that I would like to discuss with you.

So, one of the issue is that we are required (in France, but very likely in other countries in Europe) to show additional information that are missing on invoices/ order confirmation, which are: order ID and item ID.

So I was wondering about whether Saleor would add those information? The main issue with that (which is why I ask), is that we would need to show a value that is whether the internal db IDs which is mostly to be avoided or a made up value (or SKU for products).

Another issue, is that we are required to show a delivery date... and... We are required to make it be under 30 days (in France once again). That one is ready in another version as PR.

That's all the remaining issues about invoices that I note about Saleor.

NyanKiyoshi
@NyanKiyoshi
May 14 2018 13:46
Also, it's required to show the legal information about the society on invoices and mails. This one is a planned PR for Saleor, it introduces a new site settings field that fills both the site's footer and the mails footer.
Patryk Zawadzki
@patrys
May 14 2018 15:26
we do show order #s and SKUs I believe which should satisfy the invoice requirement
I don’t believe there are any EU-wide regulations on what needs to be displayed for an order (ie. not an invoice)
NyanKiyoshi
@NyanKiyoshi
May 14 2018 15:27
On order confirmation mails? I need to check that then
I don't think so too
Patryk Zawadzki
@patrys
May 14 2018 15:28
at least in Poland there are requirements on what needs to be shown on an invoice and that every customer can request an invoice when the seller is a company (ie. not a natural person)
here the interpretation is that an invoive needs to uniquely designate the purchased goods and services but it does not specify that you need to show a database ID or even an SKU as long as it’s easy to establish what was sold
so if I sell similar products it needs to be possible to disambiguate between them
NyanKiyoshi
@NyanKiyoshi
May 14 2018 15:33
I see
But yeah, here the law is obliging us to show an order ID that is sequential and item SKU. Depends of the country...
Just checked, shopify doesn't show the SKU or anything like that on PDF invoices
But we can edit the invoice template from the panel though
Also, invoices are a requirement here, our edited Saleor version has a button on order details (from customer's own panel) to get a valid invoice PDF
Not sure if we should or not implement it on Saleor as feature
Patryk Zawadzki
@patrys
May 14 2018 16:16
are you ok with regenerating the invoice on each click?
I’m asking since it’s usually illegal to release two documents with the same number but different contents
which means that if you edit an order and the customer clicks the button for the second time you are technically circulating two invoices for a single sale that differ in contents
NyanKiyoshi
@NyanKiyoshi
May 14 2018 16:18
Here, we have the invoices saved to a S3 bucket on order creation
We can have controls here and get a fine if they are able to do this ugh
Patryk Zawadzki
@patrys
May 14 2018 16:20
yeah, that’s what I mean, I’d suggest storing invoices in media (which in our case would also be S3)
NyanKiyoshi
@NyanKiyoshi
May 14 2018 16:22
Yeah, that's the best. Only issue, is that we store the invoices in the language that was set during the order creation request. But I decided to let it be, since it's very unlikely that the user will place an order in a given language and then want the invoice in another language
Patryk Zawadzki
@patrys
May 14 2018 16:24
that’s an interesting take, I think in (most of?) EU it’s fine if all your invoices are in English
NyanKiyoshi
@NyanKiyoshi
May 14 2018 16:24
Yeah, I guess so. At least I didn't see anything in laws saying it was an issue
Do you think we should implement it on Saleor then? It's a huge feature, so it would really be awesome if it becomes a Saleor feature (less work for me when merging Saleor, yay!)
Patryk Zawadzki
@patrys
May 14 2018 16:27
yes, I think with EU taxes behind us we should look into making the invoicing experience better
but in that case I’d start with all invoices in a single language (site’s default)
that being said our team is going to focus on Dashboard 2.0 and GDPR this month
NyanKiyoshi
@NyanKiyoshi
May 14 2018 16:29
Why not the request language when the user is placing an order?
Except for order created from dashboard, it makes sense to use the site default here when we place the order
Good luck for that! I still need to see what to do with #2020, because it looks like we need an opt-in for cookies with GDPR. But I'm really not sure about this
Patryk Zawadzki
@patrys
May 14 2018 16:31
I think reviewing invoice contents (and their styling) in multiple languages places additional burden on the company using the store
NyanKiyoshi
@NyanKiyoshi
May 14 2018 16:31
Also, while I think about that... I never get this... Why are we not allowing the Saleor users to set the default country and currency from the environment?
Patryk Zawadzki
@patrys
May 14 2018 16:32
what works beautifully when tested in English could completely fall apart in, say, German, where average word length is higher
I want to set this and more using the configuration panel in the dashboard
things like currency, languages, countries etc.
NyanKiyoshi
@NyanKiyoshi
May 14 2018 16:33
Makes sense. I made a lot of work on this overflow part to avoid those kind of issues, but yeah... PDF are great when it comes to overflows
Patryk Zawadzki
@patrys
May 14 2018 16:33
and have a first-time setup wizard when no users exist
NyanKiyoshi
@NyanKiyoshi
May 14 2018 16:33
Makes sense. But it would make users break easily their store though(?) If they decide to change the currencies
Patryk Zawadzki
@patrys
May 14 2018 16:34
I don’t think changing the currency should be that easy
there should likely be tons of warnings
NyanKiyoshi
@NyanKiyoshi
May 14 2018 16:35
Good idea
Patryk Zawadzki
@patrys
May 14 2018 16:36
...and some changes to the code as it will currently crash if it encounters an order in a currency other than the default one, I suspect some calculations wrongly try to mix the two (luckily prices raises an exception)
NyanKiyoshi
@NyanKiyoshi
May 14 2018 16:37
Yeah, to see
Anyway, good work, Saleor is way better than Shopify and others right now. Especially as VAT handling is done. Now dashboard 2.0 will shake things up. Good job :ok_hand:
I'm currently thinking about ways to make Saleor more easily customizable for non-IT users through both visual template (or just home page) editing, and template code editing (like Shopify's liquid templates).
It's really an issue right now, I get a lot of requests to customize the home page and ("static") pages which are really limited right now, and the home page requires a push to the production environment which is quite bad.
Patryk Zawadzki
@patrys
May 14 2018 16:41
we’re planning to tackle Draft.js (and Draftail by Wagtail) which could allow homepage to become an ordinary "CMS" page with some Draft.js embeds (products, collections etc.)
NyanKiyoshi
@NyanKiyoshi
May 14 2018 16:42
That sounds nice
I was thinking that we should probably allow both RichTextEditor and source editing on pages (and even products description)? Should we really care about blocking javascript, iframes, etc.?
Here, they want to embed videos (probably <video> or YouTube, I will see once they are ready to put the content over the website), which is not supported by Saleor.
Also, we have a page with a javascript map from Google API which is also not supported without forcing Saleor.
Patryk Zawadzki
@patrys
May 14 2018 16:46
with Draft.js it’s much easier to provide block types than to allow HTML to be embedded directly
NyanKiyoshi
@NyanKiyoshi
May 14 2018 16:46
Okay :ok_hand: I will let you handle that, that sounds nice.
Simon Søllingvraa
@simsoll
May 14 2018 18:31
Hi everyone, I’m new to Saleor having just setup up my local development and so far it seems promising :) But how do you typically customize a Saleor site? Just modify the provided html, scss and js files as the docs suggests?
I’m just worried that I might get into trouble once Saleor updates starts conflicting with my modifications…