These are chat archives for mirumee/saleor

2nd
Aug 2018
Joshua Fialkoff
@jfialkoff
Aug 02 2018 00:17
Hey all, it looks like there are a few tests failing in master related to test_emails.py. I think these tests are run as part of your continuous integration though, right? I'm not sure though why it would fail here, and not there.
NyanKiyoshi
@NyanKiyoshi
Aug 02 2018 00:55
@jfialkoff are the emails templates compiled? (npm run build-emails)
Joshua Fialkoff
@jfialkoff
Aug 02 2018 02:16
That did it, thanks.
Marcin Gębala
@maarcingebala
Aug 02 2018 07:14
@NyanKiyoshi regarding your question about MenuItems in graphql - we'll see how it works, but we assumed that it should be enough for the api client to be able to fetch the actual URL and name of an item.
Now I see that this may be not enough for the dashboard part which will have to know where does the actual item "come from", but we'll see when implementing this part in our new dashboard.
Joshua Fialkoff
@jfialkoff
Aug 02 2018 11:31
Could someone tell me where an address gets associated with a User in the checkout process?
Joshua Fialkoff
@jfialkoff
Aug 02 2018 11:37
I'm now seeing that it's done in GraphQL. Is that the only place?
Joshua Fialkoff
@jfialkoff
Aug 02 2018 12:25
I also see it in checkout.utils.create_order. So, new question: why is there a mutation for it?
Filip Kucharczyk
@Pacu2
Aug 02 2018 12:37
We are creating GraphQL API that will be used for the new dashboard & storefront, but it's not currently in use
Joshua Fialkoff
@jfialkoff
Aug 02 2018 12:38
Ah, got it. Thanks.
You might want to use the account.utils.store_user_addresses function in that mutation.
NyanKiyoshi
@NyanKiyoshi
Aug 02 2018 15:00
@elwoodxblues for now that could be enough for api client, yes. Then it will change for storefront 2.0 without any doubt. There is also another issue: we cannot retrieve/ differentiate the top_menu and bottom_menu, but once again this is an issue for the next storefront
NyanKiyoshi
@NyanKiyoshi
Aug 02 2018 16:06
@Pacu2 is #2475 ready for review?
Filip Kucharczyk
@Pacu2
Aug 02 2018 17:31
I think there might be some bits and bobs left in there, will give it a final polish tomorrow
NyanKiyoshi
@NyanKiyoshi
Aug 02 2018 17:32
Alright!
Joshua Fialkoff
@jfialkoff
Aug 02 2018 23:41
I'm trying to add a private field to Address so that users can optionally share them across a company (as it relates to the B2B pull request. I'm having difficulty understanding how to do this with i18n library. Could someone point me in the right direction?
NyanKiyoshi
@NyanKiyoshi
Aug 02 2018 23:43
About the address forms here?