These are chat archives for mirumee/saleor

25th
Sep 2018
Sandeep Balagopal
@ksandeep56_twitter
Sep 25 2018 06:33
hi team, Just wanted to clarify about the architecture. Saleor is not available in pypi, we have to clone and set up the project. Work our modifications directly to the core Saleor code, not really telling us to extend anything. Is this a good way to set up ? If we do like this, how can it be upgraded to a latest version ?
Marcin Gębala
@maarcingebala
Sep 25 2018 08:13
Hey @ksandeep56_twitter, at the moment this is the recommended way. Due to the "forkable" nature there is yet no better way to upgrade than doing a manual pull from our repo. We're working on separating things a little bit within the codebase to make it easier in the future.
If you're only willing to customize the theming of the storefront, it shouldn't be a big problem as we don't do much changes there.
Николай Инкогнито
@mmmsvit_gitlab
Sep 25 2018 08:23
@ksandeep56_twitter , i have pull request where separate settings, can override any template or static file without changing original files. I work on way to write views with not override original files, but at this moment simplest way - just try use template tags if possible. PR not allowed in master branch, so this not official at this moment.
Sandeep Balagopal
@ksandeep56_twitter
Sep 25 2018 09:17
@elwoodxblues @mmmsvit_gitlab thanks
Николай Инкогнито
@mmmsvit_gitlab
Sep 25 2018 15:43
continue trying separate Saleor core code and own code. Have solution: for example i wont override product/views.py function product_details , for do this - add to end file execfile("G:/Dev/tadshop/site/saleor_local/product/views.py"), and simple in file redeclare defination of function. Debug, highlight etc. all work fine (except what need little difference import paths). Problem: how dynamically add this code for example in end of settings.py without changing Saleor core files? Any know how? Or maybe you know another solution?
Pete Dermott
@petedermott
Sep 25 2018 15:57
Can I ask why Celery is a requirement for Saleor? Do you guys use it for anything or is it more just set up for the convenience of other developers?
zchlebicki
@zchlebicki
Sep 25 2018 15:58
Sending emails
Pete Dermott
@petedermott
Sep 25 2018 15:58
OK, is that it?
zchlebicki
@zchlebicki
Sep 25 2018 15:59
there are several more. Celery lists tasks on startup
Николай Инкогнито
@mmmsvit_gitlab
Sep 25 2018 15:59
[tasks]
. saleor.account.emails.send_account_delete_confirmation_email
. saleor.account.emails.send_password_reset_email
. saleor.core.analytics.ga_report
. saleor.dashboard.emails.send_promote_customer_to_staff_email
. saleor.dashboard.emails.send_set_password_email
. saleor.order.emails.send_fulfillment_confirmation
. saleor.order.emails.send_fulfillment_update
. saleor.order.emails.send_note_confirmation
. saleor.order.emails.send_order_confirmation
. saleor.order.emails.send_payment_confirmation
. saleor.product.thumbnails.create_product_thumbnails
Pete Dermott
@petedermott
Sep 25 2018 15:59
Cool, thanks guys
Filip Kucharczyk
@Pacu2
Sep 25 2018 16:35
@barthol0 You should check the console to see if there's any error with getting the image from the S3 bucket. Is there a possibility that those products were created before setting up the S3?