These are chat archives for mirumee/saleor

18th
Oct 2018
marojenka
@marojenka
Oct 18 2018 10:00
Hi, is there any guidelines on how to customise saleor for specific project without loosing ability to merge with new versions?
Stephen Moloney
@stephenmoloney
Oct 18 2018 11:24
@marojenka , I haven't found any guideline but for now the general git commands like git rebase and if you like git cherry pick will be useful. It can be tedious but I can't think of any alternative.
Looking to the future, Another valid option will be to create your own frontend for the storefront once the graphql portion of the app is complete.
@NyanKiyoshi , is google recapthcha required ? ie, what happens if no public or private key is set in a production app ?
(i'm writing some docs)
Also, on recaptcha, I noticed google have a v3 now ... https://www.google.com/recaptcha/intro/v3beta.html
marojenka
@marojenka
Oct 18 2018 11:30
@stephenmoloney thanks. Hacking into saleor and then merging each project once a moth sounds dreadful for me so far.
Stephen Moloney
@stephenmoloney
Oct 18 2018 11:32
I'd like to hear other stories about this - what are you doing ?
marojenka
@marojenka
Oct 18 2018 11:36
I have legacy of old projects, each one of them is unmaintained iteration of another. I hoped to use saleor to move them (or just some of them) to a new common engine to make thins DRY and possible to maintain.
Stephen Moloney
@stephenmoloney
Oct 18 2018 11:36
My own thinking is that keeping divergence from upstream to a minimum will be the best approach.
It would be nice to know what mirumee approach this themselves for their own forks, do you keep rebasing periodically with upstream (github.com/mirumee/saleor) or just freeze a forked release abandoning changes in github.com/mirumee/saleor ? @patrys
marojenka
@marojenka
Oct 18 2018 11:48
minimal changes to the core is the exact aim, but they are inevitable. No idea how to make them clear to see and easy to maintain.
Filip Kucharczyk
@Pacu2
Oct 18 2018 12:38
We are planning core freeze at somepoint, but Saleor is still rapidly changing and can't give an exact date when this will happen
NyanKiyoshi
@NyanKiyoshi
Oct 18 2018 17:44
I just would like to say that I won't be able to commit and update #3055, I'm really sorry about this, I really don't have any spare minutes, so I will update it in a bit more than a week, because I will have a few minutes, but I won't be fully available before January. I'm really sorry about this, I just want to let know so there is no wonder why this PR is stuck despite being so minor.
Filip Kucharczyk
@Pacu2
Oct 18 2018 18:49
That's totally fine, thanks for letting us know, I'll flag it and someone will pick it up once we have some spare time
NyanKiyoshi
@NyanKiyoshi
Oct 18 2018 18:50
Sure. Whenever I can I will update it if nobody did. It's really a tiny minor change so it's quite fine