These are chat archives for mirumee/saleor

21st
Oct 2018
ankittyagi20
@ankittyagi20
Oct 21 2018 15:56
I'm using saleor docker and according to https://saleor.readthedocs.io/en/latest/customization/frontend.html I'm making changes in /static/assets/storefront.css and running npm run build-assets --production however, the changes are not getting reflected. Is there something I'm missing?
Filip Kucharczyk
@Pacu2
Oct 21 2018 17:06
Yes, files in /saleor/static/assets/ should not be edited manually, try editing ones in saleor/static/scss/ instead
ankittyagi20
@ankittyagi20
Oct 21 2018 17:52
there's a class home--content-inner in storefront.css, but I don't see that inside scss/ folder.
Filip Kucharczyk
@Pacu2
Oct 21 2018 19:03
Try looking for partial name, as in SCSS those are glued dynamically, --content-inner has some hits in .scss
ankittyagi20
@ankittyagi20
Oct 21 2018 19:15
yeah I think I get it, looks like the architecture has been changed. I have two deployments on my local system one is of older version and another one I just did (with sept release) now I'm able to make changes under scss/ and they're getting reflected as well. But now the AWS configs are not picked up. I'm storing files on s3 and setup the credentials in common.env (AWS secrets). Do I also need to change anywhere else to pick the files from S3 bucket?
Filip Kucharczyk
@Pacu2
Oct 21 2018 19:47
As far as I remember setting env variables should do the job, but you might want to double check if you have all the env variables set, as I remember some changes in the setup in the last 6 months
ankittyagi20
@ankittyagi20
Oct 21 2018 21:02
Yeah the environment vars didn’t load properly