These are chat archives for mirumee/saleor

11th
Nov 2018
yogesh-kamble
@yogesh-kamble
Nov 11 2018 11:55
paypal endpoint should be PAYPAL_ENDPOINT=https://api.sandbox.paypal.com
victor felder
@vhf
Nov 11 2018 12:09
@yogesh-kamble Isn't this only for the sandbox and not for a live production thing?
Stephen Moloney
@stephenmoloney
Nov 11 2018 12:30
I am close to the point where I need to add a payment provider so I'm interested too. But I noticed that the payments has been refactored and now seems like django-payments is not adopted for saleor new shopfront.
So I'm debating/considering maybe make the move to the new shopfront more or less now or in next 2 weeks or so .. is this a reasonable choice I wonder?
Also, taking a look at the braintree payment provider, can someone in saleor team confirm that it follows this flow as outlined in braintree
image.png
Extracted from https://developers.braintreepayments.com/start/overview#how-it-works
So, with the new version of saleor, is saleor using payment nonces ? @Pacu2 (https://developers.braintreepayments.com/guides/payment-method-nonces)
Stephen Moloney
@stephenmoloney
Nov 11 2018 12:39
Which method of client authorisation is saleor adopting ? https://developers.braintreepayments.com/guides/authorization/overview
Filip Kucharczyk
@Pacu2
Nov 11 2018 13:10
Yup, we've just dropped django-payments in favor of pulling the payments into the Saleor.
We are using client-tokenauthorization, payment data is tokenized client-side, and the token gets send to the backend. Everything should be PCI compliant
victor felder
@vhf
Nov 11 2018 13:27
@Pacu2 How do we configure payments in the new saleor?
Filip Kucharczyk
@Pacu2
Nov 11 2018 14:33
@vhf Payment providers can be enabled via env variables. (Then you need to edit the settings file and add them to your checkout options...)
There's a simple guide on how-to add new payments in . https://docs.getsaleor.com/en/latest/guides/payments.html
Which will be expanded once mirumee/saleor#3205 is merged
Stephen Moloney
@stephenmoloney
Nov 11 2018 17:16
Thanks @Pacu2 , I think based on this, I'm going to use the new saleor shopfront with braintree.
I'm busy for a while but will get back to this soon. I might look into what would be involved in writing a stripe elements payments integration but it's something I can't consider/commit to right now anyways... way too busy.
Oleg
@gigimon
Nov 11 2018 19:53
hi all
Filip Kucharczyk
@Pacu2
Nov 11 2018 19:53
Hi Oleg, how you doin
Oleg
@gigimon
Nov 11 2018 19:53
@Pacu2 hi! Can help? :)
i catch a celery error about email django.template.exceptions.TemplateDoesNotExist: templated_email/compiled/confirm_order.html
but compiled directory is empty... how to compile messages? I don't found in docs :(
Filip Kucharczyk
@Pacu2
Nov 11 2018 19:54
Can you try running npm run build-emails?
Oleg
@gigimon
Nov 11 2018 19:55
no :)
@Pacu2 big thx! never think about npm commands for this
Filip Kucharczyk
@Pacu2
Nov 11 2018 19:56
No prob :) I think it should be listed in the docs in Getting Started section (if not please give us a shout!). You'll need to rerun this command each time email files were changed
Oleg
@gigimon
Nov 11 2018 19:57
understand, thx
Eli Spizzichino
@diramazioni
Nov 11 2018 22:45
Hi all! I've just started out with saleor and I got installed and populated with default content. I've been reading all the docs, but somehow I can't find why I don't get the price/variants and the ability to add the product to the cart. I can see DUMMY in the CHECKOUT_PAYMENT_GATEWAYS (in settings.py) I have not changed anything from the default git master clone.
image.png
Filip Kucharczyk
@Pacu2
Nov 11 2018 22:49
Could you check some other products, to narrow down the situation?
Eli Spizzichino
@diramazioni
Nov 11 2018 22:49
oh you are still awake! actually all the products have the same problem
Maybe is because I've run npm audit fix and I may have procken something?
this is the only thing non standard from the instruction
Filip Kucharczyk
@Pacu2
Nov 11 2018 22:52
Are you using the latest Saleor? You might want to check the browser's console for some javascript-related errors
Eli Spizzichino
@diramazioni
Nov 11 2018 22:54
actually yes last version checkout today. in js console 1 error:
Filip Kucharczyk
@Pacu2
Nov 11 2018 22:55
Seems like we've got the winner, could you try installing the npm packages as shipped with Saleor, without running npm audit fix?
Eli Spizzichino
@diramazioni
Nov 11 2018 22:56
yes while I was writing this I thought it could be this. Give me a min Irecreate the env
Eli Spizzichino
@diramazioni
Nov 11 2018 23:06
I've removed node_modules and run npm install && npm run build-assets still the same problem. Maybe this is not the way to really start from scratch? Did I miss something?
Filip Kucharczyk
@Pacu2
Nov 11 2018 23:09
I think that running npm audit fix modified your local package.json and package-lock.json, you'll need to drop those changes as well
Eli Spizzichino
@diramazioni
Nov 11 2018 23:10
you are absolutely right! sorry! restarting from a freshly cloned repo
Filip Kucharczyk
@Pacu2
Nov 11 2018 23:13
You could checkout the file from the origin repository like git checkout origin/master package.json :D
Eli Spizzichino
@diramazioni
Nov 11 2018 23:16
:/ no luck. I've even dropped the db and re- populatedb still the same error.
Filip Kucharczyk
@Pacu2
Nov 11 2018 23:19
Gotta go for today, do you mind opening an github issue with this error?
Eli Spizzichino
@diramazioni
Nov 11 2018 23:19
sure! I was curious to know if I'm the only one with this problem or somnething is broken in master
ty for the help
Eli Spizzichino
@diramazioni
Nov 11 2018 23:31
NyanKiyoshi
@NyanKiyoshi
Nov 11 2018 23:32
@diramazioni could you run npm run build-assets --development (or npm start) and get the error again, so we get a meaningful error?
Eli Spizzichino
@diramazioni
Nov 11 2018 23:34
yeah sorry!
NyanKiyoshi
@NyanKiyoshi
Nov 11 2018 23:34
No problem!
Eli Spizzichino
@diramazioni
Nov 11 2018 23:37
@NyanKiyoshi actually now in the console it just says Download the React DevTools for a better development experience: https://fb.me/react-devtools
NyanKiyoshi
@NyanKiyoshi
Nov 11 2018 23:37
It doesn't crash anymore?
Eli Spizzichino
@diramazioni
Nov 11 2018 23:38
no crash
it works now...
NyanKiyoshi
@NyanKiyoshi
Nov 11 2018 23:38
Weird
Eli Spizzichino
@diramazioni
Nov 11 2018 23:38
weird isn't it?
but this is it folks. Starting from a fresh clone of the master. I'll update the issue or close it (?)