These are chat archives for mirumee/saleor

21st
Nov 2018
Ray Besiga
@raybesiga
Nov 21 2018 08:57
Hey guys, I hope this is not a silly question but I am having a hard time choosing what tool to use within Github for continuous integration especially before merging pull requests for people outside of our team. What tools do you use and what are the upsides and downsides? Regards.
Ideally, the tool should also be able to do automated code reviews.
Marcin Gębala
@maarcingebala
Nov 21 2018 10:09
Hey, we have configuration for both Travis and CircleCI. They are both pretty much similar and I don't have strong preference which of them is better. We use them to run both backend and frontend tests. To help us with code reviews we use Code Climate which runs linters and checks for code style issues to help us maintain the same formatting rules.
cc @raybesiga
Stephen Moloney
@stephenmoloney
Nov 21 2018 10:20
I'm a fan of just using a private gitlab instance for private projects and it's integrated CI features.
AJ
@ajostergaard
Nov 21 2018 10:35
Gitlab ROX!
Ray Besiga
@raybesiga
Nov 21 2018 11:36
Thanks @maarcingebala! Will check these out. Also, the last time I sent a PR to Saleor, I saw something called "CodeCov". Is that a different tool?
Hi @stephenmoloney @ajostergaard I'll check out Gitlab. It looks a lot like the future
Stephen Moloney
@stephenmoloney
Nov 21 2018 11:39
I've just setup myself as an ADMIN in django and much to my surprise the emails include all the settings.py information.Putting the error exception seems fine bu putting the settings.py data in plain text seems like a bad idea to me. I know this is a django issue but is anyone else using emails for ADMIN reports and is there a way to remove the settings.py content entirely ?
Ray Besiga
@raybesiga
Nov 21 2018 11:40
Is debug=true? @stephenmoloney
Stephen Moloney
@stephenmoloney
Nov 21 2018 11:48
No.
@raybesiga in fact, the emails are only sent when DEBUG=False.https://docs.djangoproject.com/en/dev/howto/error-reporting/#server-errors
When DEBUG = False, errors and critical messages get sent to the admin mail handler. https://docs.djangoproject.com/en/dev/topics/logging/#django-s-default-logging-configuration
Ray Besiga
@raybesiga
Nov 21 2018 11:50
Ah yes, that is what I meant. My bad,
Stephen Moloney
@stephenmoloney
Nov 21 2018 11:54
Seems like djangos only really credible alternative is to use SENTRY. Filtering emails is not going to be sufficient. I thought just removing settings.py and including only the stacktrace in the email or even removing the entire body of the email and notifying you that an error had occurred might be a middleground solution. Anyone here using sentry ?
AJ
@ajostergaard
Nov 21 2018 13:10
From the Django docs: "Note that this HTML version of the email contains a full traceback, with names and values of local variables at each level of the stack, plus the values of your Django settings. This information is potentially very sensitive, and you may not want to send it over email. Consider using something such as Sentry to get the best of both worlds – the rich information of full tracebacks plus the security of not sending the information over email. You may also explicitly designate certain sensitive information to be filtered out of error reports – learn more on Filtering error reports."
@stephenmoloney I use Sentry. I suspect most folk do. Can't say I've stretched it much, don't get very many errors after dev is done. ;)
Stephen Moloney
@stephenmoloney
Nov 21 2018 13:17
@ajostergaard yea, I think sentry is the logical choice. Like you say, for a low volume traffic site, one could probably escape without it altogether once dev is done.