These are chat archives for mirumee/saleor

3rd
Dec 2018
Filip Kucharczyk
@Pacu2
Dec 03 2018 10:29
@wulaaf Try looking for google_measurement_protocol in Saleor, as it's definitely used.
jdivins
@jdivins
Dec 03 2018 10:33
@diramazioni I think this part:
Things that Needs to be done after merging this PR:
  • interface for adding translations in the dashboard
  • graphql api for translations
    Is not done ?
Filip Kucharczyk
@Pacu2
Dec 03 2018 10:35
@jdivins that's right
jdivins
@jdivins
Dec 03 2018 11:48
@Pacu2 but if I add translations of a product directly to database, when the language is changed on storefront, I have got to see the product in the selected language?
NyanKiyoshi
@NyanKiyoshi
Dec 03 2018 12:26
Would enforcing a warning-free document in sphinx be merged? We could check that during the travis build. I noticed multiple times syntax errors (warnings*) getting merged time to time into master. It would give that:
Image from Gyazo
Patryk Zawadzki
@patrys
Dec 03 2018 12:28
@/all hey everyone, it’s becoming harder and harder to follow the chat here as questions are often pushed off-screen before anyone has a chance to reply, we’re considering moving to Spectrum (https://spectrum.chat) as they’ve just announced merging with GitHub; what are your thoughts?
NyanKiyoshi
@NyanKiyoshi
Dec 03 2018 12:33
It seems great. Just having troubles as of now, getting 503 errors everywhere, but that's a temporary issue, I guess.
Patryk Zawadzki
@patrys
Dec 03 2018 12:34
yeah, the sudden spike of popularity is overwhelming
Filip Kucharczyk
@Pacu2
Dec 03 2018 12:52
@jdivins Yup, that's right, just as it happens on the gif in mirumee/saleor#2475
Eli Spizzichino
@diramazioni
Dec 03 2018 12:56
@Pacu2 @jdivins do you fixtures for that?
Filip Kucharczyk
@Pacu2
Dec 03 2018 12:57
You need to check if it's still up to date as I've created while testing the functionality
Eli Spizzichino
@diramazioni
Dec 03 2018 13:11
@Pacu2 thanks for the very useful example, I'll try it. When do you foresee the work on the dashboard will be finished?
Filip Kucharczyk
@Pacu2
Dec 03 2018 14:16
@diramazioni I don't know, if it's not on the roadmap already, then maybe @maarcingebala will know more in terms of the future roadmap
Eli Spizzichino
@diramazioni
Dec 03 2018 14:22
I'll try to help once I've it deployed in the default language. Maybe an economic incentive could accelerate the priority?
Filip Kucharczyk
@Pacu2
Dec 03 2018 14:23
I think the issue with this feature was a design task, how to make it useful but not overengineered at the same time
Eli Spizzichino
@diramazioni
Dec 03 2018 14:25
I was envisioning a simple dropdown with language selection while inside the editing page, to easily switch between translation of the same sku or menu
anyway I'm here for suggestions and help testing if needed
Filip Kucharczyk
@Pacu2
Dec 03 2018 14:29
I'll try to check what's the stage of design task and will get back to you
M Abdullah Abid
@wulaaf
Dec 03 2018 14:55
Why not Slack?
Filip Kucharczyk
@Pacu2
Dec 03 2018 14:56
Unfortunately Slack has no good plans for open source projects, and paying few bucks for each user is not an option
M Abdullah Abid
@wulaaf
Dec 03 2018 14:56
Hmm. Fair enough
Patryk Zawadzki
@patrys
Dec 03 2018 15:04
exactly, we use Slack internally but the cost of maintaining a paid instance for a large community would be prohibitive
Apollo GraphQL tried to use the free plan but they are also slowly migrating to Spectrum
Filip Kucharczyk
@Pacu2
Dec 03 2018 15:19
@diramazioni Check it out mirumee/saleor#2564
M Abdullah Abid
@wulaaf
Dec 03 2018 15:25
Btw is it just me or do VariantImages do not load on selection as of now?
mvondo
@mvondo
Dec 03 2018 17:04
@Pacu2 I can not do it if you can show me how to do it
Filip Kucharczyk
@Pacu2
Dec 03 2018 17:18
@mvondo Sorry, what post are you referring to? Not sure what do you mean
mvondo
@mvondo
Dec 03 2018 17:21
integrated the storage dropbox in saleor the documentation is very poor can you showed me an example of integration
@Pacu2 integrated the storage dropbox in saleor the documentation is very poor can you showed me an example of integration
Filip Kucharczyk
@Pacu2
Dec 03 2018 17:25
Unfortunately I can not, as I have not integrated it on my own
Patryk Zawadzki
@patrys
Dec 03 2018 17:26
@NyanKiyoshi sorry, only just saw your question about doc strictness (hence why we want to move away from Gitter), I would very much like a checker for that but I think Code Climate would be a better place and could help other projects as well
Patryk Zawadzki
@patrys
Dec 03 2018 17:32
if anyone wants to give Spectrum a try: https://spectrum.chat/saleor/ (there will be a separate announcement when we decide to fully migrate away from Gitter)
Muhammad Bandawa
@mdnur89
Dec 03 2018 17:39
Guys npm start is just on a hanged state, just after building the mini-css-extract-plugin assets and after that nothing happens and I'm looking at it still hoping for a miracle.
I changed logo.svg, logo-document.svg, block1, block2 and block3 files and invoked the npm start command but it's not completing the transaction.
Filip Kucharczyk
@Pacu2
Dec 03 2018 17:44
npm start works as a watcher
Patryk Zawadzki
@patrys
Dec 03 2018 17:45
@mdnur89 the idea behind start is that you launch it, it emits the initial set of files and then waits and watches over file changes that you make, rebuilding the necessary parts
it will not "finish" in the traditional sense, you'll need to stop it with Ctrl+C
Muhammad Bandawa
@mdnur89
Dec 03 2018 18:04
@patrys @Pacu2 Oh so are you in a sense saying I can make more file changes as it's running and it'll update per say, not sure if you can understand what I'm trying to say there. And in other funny news, y'all are saying that I've wasted the last 3hours of my life. 😭😂
NyanKiyoshi
@NyanKiyoshi
Dec 03 2018 21:57
@patrys that is true
NyanKiyoshi
@NyanKiyoshi
Dec 03 2018 23:09
@patrys could be really manage to get a full check over the RST files? I was thinking about building the sphinx docs during the travis build. I'm really not sure about doing full checks over codeclimate, as I was thinking about checking if the build passes or not (with a strict syntax). Otherwise... Maybe we could manage to trigger automatically a build on GitHub PR whenever a change is detected in docs/. That could be possible (I guess).