These are chat archives for mirumee/saleor

22nd
Mar 2019
Ashish Patil
@ashishnitinpatil
Mar 22 07:29
@jdivins Maybe gmail is blocking image loading (as it always does with spam & suspicious emails). I wouldn't bother much if thunderbird does show the image.
Ashish Patil
@ashishnitinpatil
Mar 22 09:00
What's the correct procedure to install additional dependencies? Respect Pipfile over requirements.txt or the other way round?
Ashish Patil
@ashishnitinpatil
Mar 22 09:09
IMO current requirements thing is a mess. requirements.txt uses "==" so that's not in sync with whatever pipenv has / will install, which is fine, but then we can't get minor updates to repositories if we use requirements.txt. On the other hand, if we use Pipfile (pipenv) or Pipfile.lock then any time we add a dependency it updates everything else too (yes, it affects other unrelated dependencies & there are quite some issues open on pipenv for this) which means we can't have consistency between 2 environments if there's a simple additional dependency to be installed :(
Safest option seems to be requirements.txt
This commit mirumee/saleor@ca0d935 tells me that there is a way that we can change / add dependencies without affecting other dependencies, but I am not sure what they did in order to achieve the minimal change to Pipfile.lock. If anyone could guide me, that'll be great!
jdivins
@jdivins
Mar 22 10:10
thanks @ashishnitinpatil ! I am going to try with the final domain... and correct https
Dushyant Rijhwani
@dushr
Mar 22 10:56

Hi everyone, I was wondering is the best way to use saleor for a project is to clone the current repository and modify it there?
I was thinking of not using django's templating and instead use graphql and react for building a storefront. So I would get rid of "template" and all the npm stuff from the project. (Maybe just leave the stuff for the dashboard)

There would be other modifications too, for example - I would want write integration of another payment gateway (Adyen)

However, my concern is the moment I do that I would lose any new features, bug fixes and security fixes that saleor's development team releases.

Ashish Patil
@ashishnitinpatil
Mar 22 12:10
@dushr that is indeed the recommended way (clone repo, make changes, deploy), which does need efforts for latest updates from saleor (git fetch, check diff, pull, merge, test, redeploy) but it isn't that bad.
Dushyant Rijhwani
@dushr
Mar 22 12:12
Thanks @ashishnitinpatil
Ashish Patil
@ashishnitinpatil
Mar 22 12:12
Also, seems like you should checkout the PWA (complete frontend based flow, I think) - https://pwa.getsaleor.com/
Martin
@martcot_gitlab
Mar 22 13:31
Hi everyone, do you know if saleor can handle Canadian taxes? if no is there is development now or I will have to build code for this?
Filip Kucharczyk
@Pacu2
Mar 22 13:31
Hi @martcot_gitlab, saleor has only support for EU taxes, we have some logic in place so this could be expanded to handle canadian as well. There's integration with Avalara planned, but I'm not familiar with the roadmap
Martin
@martcot_gitlab
Mar 22 13:33
ok thank your for you answer @Pacu2 I will check this!
Ashish Patil
@ashishnitinpatil
Mar 22 14:50
@martcot_gitlab like Pacu2 said, the EU taxes support can be extended with a little development work. Basically you have to create a VAT entry like this -
from django_prices_vatlayer.models import VAT VAT.objects.create( country_code='CA', data={'country_name': 'Canada', 'standard_rate': 10, 'reduced_rates': {}}, )
this will put a tax rate of 10% on all "standard" items. And of course, you need to handle the tax settings as well (check docs & then your shop's dashboard)
camiloruizi
@camiloruizi
Mar 22 15:53
Does anyone know how to upload saleor to google cloud platform?
Martin
@martcot_gitlab
Mar 22 18:03
thanks @ashishnitinpatil I will try that! :)