Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
resourceldg
@resourceldg
hi guys, what would be the right way to update saleor? I should work my project on a different branch and update on the master branch ...i like gitlab for many reasons ...it this complex to setup? where can i find this documentation?.Thanks!!
Chad Cassady
@beatboxchad

Such documentation isn't written yet, and there are a lot of different things you can do. I really love gitlab too! My experience with Saleor's deployment and development tooling in general has been that they provide great starting-point examples for common workflows. I learned a lot working on Saleor. But with the move to the PWA infrastructure during 2.x, lots of the tooling and documentation hasn't been updated yet. Big architectural changes are a ton of work. So right this second we're left figuring it out ourselves.

(To a degree, this has always been true. There's a lot of different ways to deploy and develop, and many overlapping tools to get the job done. It kind of depends on your team, your infrastructure, and how you're using Saleor -- especially true as the stack has gotten more complex.)

Back to your question: High-level, what I'd do is use git submodules for the storefront and dashboard repos, working from the classic Django repo. Then I'd add services using them to the Docker Compose files. Gitlab's more useful for production CI, but Docker Compose can be a part of that too. That's where the conversation gets kinda "well it depends on what you're doing, here are a few ideas".

resourceldg
@resourceldg
Thanks @beatboxchad ...I will read about it
Chad Cassady
@beatboxchad
no prob! feel free to reach out to me to talk shop about it.
resourceldg
@resourceldg
It would be great to see some examples of how they have solved this point.
Chad Cassady
@beatboxchad

that right there shows how to add to the Docker Compose files without git submodules, which isn't very useful except to just run the dashboard and storefront without editing them. It's a starting point, though. You can read about git submodules here: https://git-scm.com/book/en/v2/Git-Tools-Submodules

If you use submodules, change the context arg to the dashboard and storefront services to the local directories you're using. Add those directories to the .dockerignore file too so that the celery and web service builds don't start taking forever on those COPY commands

resourceldg
@resourceldg
great!
I will work on this
Chad Cassady
@beatboxchad

submodules are great. The one drawback is you gotta kinda geek out on git to use them, but once you cross that hurdle they're an excellent tool for figuring out what's compatible with what across the three repositories.

There are a couple other ways to do it, though. You could use separate repos and track which tags or revisions are compatible by using the git repos in the Docker Compose files, but the syntax that targets specific tags or branches or commits.

I personally like the submodule workflow a little better, but it took me awhile to figure out.

good luck!
resourceldg
@resourceldg
thanks, I didn't know the sub-modules ... it looks pretty much what I want
Chad Cassady
@beatboxchad

\m/ they use them pretty effectively in my other favorite OSS project, SuperCollider

(https://github.com/supercollider/supercollider)

adrienshen
@adrienshen
@karolkielecki Thanks, I think because AWS ElasticBeanstalk does not have support for some basic docker functionality is why. I'm switching to just pulling the image.
meshek2015
@meshek2015
Hi team is there any plan to have multi seller like marketplace in the read map? I could see multi store in road map...
Karol
@karolkielecki
@meshek2015 Hi there! Welcome to Saleor, and thanks for asking. We're not working on multi-seller. We have other priorities, such as multi-channel. Also, we're working on other important features. I'll update the roadmap as soon as I can.
@adrienshen Sure, let me know if you need any help :)
@beatboxchad Thanks a lot for helping @resourceldg!
@resourceldg If you have any questions you can also contact me via PM
Roger Boixader Güell
@rboixaderg

Hi saleor team. In the last days We have seen in your git, that your dash and front repositories don't seem to went at the same speed that your django saleor api back. Have you published in some place the roadmap of saleor or future plans?
We saw these two PR mirumee/saleor#5000
and mirumee/saleor#5043
We were thinking in change from django version to the react storefront version, but we need to make some predictions according to your roadmap.

Thanks!

Karol
@karolkielecki

@rboixaderg Hey Roger! Thank you for your question and support. Our detailed roadmap is still under discussion. I'll keep you updated once it's ready. However, what I can tell is that we're working on a few important features such as multi-currency, CSV import/export, permission groups, multi-channel, and more. There is no exact release date for each function, but you can expect them in Q1 (at least some of them).

The new storefront is still in beta. We fix the bugs and add some small improvements for now. We don't maintain the old storefront anymore, so all the new updates will be available only on the react version. I'll inform you what we are planning to add to the storefront as soon as I know more details.

And if you have any questions, you can also reach me via PM
Karol
@karolkielecki

@/all When it comes to A/B testing, everything boils down to reducing guesswork and making decisions based on hard data. Read more about best practices that should bring results to your e-commerce business: http://bit.ly/ABTesting_article

And what are your best practices for A/B testing? Do you run them often? It would be great if you could share your thoughts with us. We'd love to hear and discuss your experience!

jyoost
@jyoost
@beatboxchad thanks for the new info to try to pack into my cranium. 🤓
adrienshen
@adrienshen

@karolkielecki What would be the recommended setup and configuration to deploy the Saleor Dashboard 2.0? We have the GraphQL API deployed on AWS EBS Docker container. Should Dashboard be in its own separate server or better to have both in the same server or is it better to be deployed on some static host like S3?

PS: I'm more of a developer than devops guy.

adrienshen
@adrienshen

Here are the error logs from AWS: https://elasticbeanstalk-us-west-2-008033919350.s3.us-west-2.amazonaws.com/resources/environments/logs/tail/e-f2gubu5dhm/i-0c71c5062cb7a4c17/TailLogs-1579825541964.out?X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Date=20200124T002542Z&X-Amz-SignedHeaders=host&X-Amz-Expires=86399&X-Amz-Credential=AKIAJ4EUBGPT4J56L5CQ%2F20200124%2Fus-west-2%2Fs3%2Faws4_request&X-Amz-Signature=0f33712dda1e87cb5341e7950aede47b1c4740ee37da85749e917b0678bf1e0c

This is the Dockerfile

FROM node:10 as builder
WORKDIR /app
COPY package*.json ./
RUN npm install
COPY . .
ARG APP_MOUNT_URI
ARG API_URI
ARG STATIC_URL
ENV API_URI http://saleor20-cabinets-dev.us-west-2.elasticbeanstalk.com/graphql/
ENV APP_MOUNT_URI ${APP_MOUNT_URI:-/dashboard/}
ENV STATIC_URL ${STATIC_URL:-/dashboard/}
RUN STATIC_URL=${STATIC_URL} API_URI=${API_URI} APP_MOUNT_URI=${APP_MOUNT_URI} npm run build

FROM nginx:stable
WORKDIR /app
COPY ./nginx/default.conf /etc/nginx/conf.d/default.conf
COPY --from=builder /app/build/ /app/
adrienshen
@adrienshen

The container has nginx which reverse proxies the static files. Perhaps Elasticbeanstalk already uses nginx and that's why it's conflicting with the default docker configuration.

I've switched to using node http-server on port 8081, and it seems to work now.

Karol
@karolkielecki

Saleor 2.9.1 SECURITY release

@/all We've rolled out a new release that fixes a vulnerability issue in Saleor. The fixes are available on Saleor 2.9.1 and the master branch. If you use 2.9.0 or older version, please update Saleor as soon as possible.

Check out more details here: https://github.com/mirumee/saleor/releases/tag/2.9.1

RL89pl
@RL89pl
I have problem with tax rate.
image.png
Vatlayer added
image.png
aliasgartaksali
@aliasgartaksali
How can we change site title?
Karol
@karolkielecki
@adrienshen Do you still experience the errors? Does your solution still work?
@RL89pl Let me take a look at it. I'll get back to you as soon as possible
Karol
@karolkielecki
@aliasgartaksali Hey! If you would like to change the site title, please follow the steps written in our docs here: https://docs.saleor.io/docs/dashboard/configuration/site/#docsNav
Marcin Gębala
@maarcingebala
@RL89pl What's the problem with tax rates exactly? I see that there is a bug in the template with the "MISSING VARIABLE". Probably the template tries to render a value that doesn't exists in the context of that view.
Partappanda
@Partappanda
Hi guys are there any Ebay/Amazon plugins for this platform so we can push items out from the backend onto the respective sales chanels?
Maciej Korycinski
@korycins
@Partappanda IMO, you can do this by creating a django_command (crawler task) or Saleor's webhook -> your instance to convert data -> Amazon/Ebay or probably by the plugin when event order_created happens
Karol
@karolkielecki
@Partappanda We're also working on the multi-channel feature. Once I know more details on that functionality, I will update everyone.
RL89pl
@RL89pl
@maarcingebala but I doesn't change enything.
@maarcingebala i only changed default currency, and then look like invoice looks like:
image.png
resourceldg
@resourceldg

I am trying to implement saleor (from the beginning) with git submodules, help me to know if this is a correct way..
sorry maybe I need to be very explicit
initial setup

git remote rename origin fork //remane my origin reference as "fork"
git remote add origin https://github.com/mirumee/saleor.git//add saleor as "origin"

With the fork already made i create two branches (dev & prod)
My team will work against the dev branch and it will receive the ascending changes by the master brach. Logically, the prod branch is for deploy proposess, but it this will merged against the dev branch.
Also the master branch receive the ascending changes for saleor "origin".
In the dev branch i create submodules. pull , commit & ,push (on fork reference) the changes. This is when you have to really start being careful with send correclty this changes.

`*fork saleor
                |
                |
                |_>submodule dashboard 
                |
                |_>submodule storefront
                 `

Follow this way, the master branch is outdated respect to dev...this is not a problem for my workflow ...or yes?
What is the best way to handle it?

on branch (master)
git status

On branch master
Your branch is up to date with 'fork/master'.

Untracked files:
  (use "git add <file>..." to include in what will be committed)

    saleor-dashboard/
    saleor-storefront/

Thanks for your time...

Karol
@karolkielecki
@resourceldg Hi there! I'm not sure if I understood you correctly. What exactly would you like to achieve? Generally speaking, the best solution is to use and connect all stable versions to be sure that everything works fine. We usually don't use submodules, but the separate repositories.
resourceldg
@resourceldg
hi @karolkielecki I'm thinking how to keep the 3 (core-sotore and dashboard) repositories updated and balanced regarding each new saleor feature. But this work is taking longer than expected. I like Saleor! I assume that in a short time we will find a way to make this easier.
Karol
@karolkielecki
@resourceldg Hey! You can use docker for that. We're going to work on some improvements related to Docker. Also, there will be a blog article about how to run Saleor with Docker Compose written by @beatboxchad. Docker support was merged into the storefront repository a few weeks ago. You can find some info on how to modify the Docker Compose files to get up-and-running quickly here: https://spectrum.chat/saleor/general/saleor-install-with-frontend-and-dashboard~7c2b43e7-cfa3-443c-9797-5e641f0cf833?m=MTU3OTI5NzY3OTU0MA==
@resourceldg Also, I recommend you to use Saleor 2.9.1 instead of the master branch. Saleor 2.9.1 is the latest stable version.
https://github.com/mirumee/saleor/releases/tag/2.9.1
resourceldg
@resourceldg
Thanks Karol!
Karol
@karolkielecki
You're welcome :)
Chad Cassady
@beatboxchad
Hey @resourceldg the master branch being out of sync is no problem -- indeed, you can just treat master as an inbox for the upstream development, and then manually rebase/cherry-pick/whatnot into your development branch. If you're super careful with your development hygiene and use the plugin system, you'll probably be able to automate some of this process.