Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
  • Jan 30 2019 15:26
    isiahmeadows commented #2363
  • Jan 30 2019 01:24
    panoply opened #2364
  • Jan 29 2019 23:50
    Bondifrench commented #2363
  • Jan 29 2019 22:17
    isiahmeadows commented #2363
  • Jan 29 2019 16:10
    tivac removed as member
  • Jan 29 2019 16:10
    tivac edited as member
  • Jan 29 2019 16:10
    pygy edited as member
  • Jan 29 2019 16:10
    barneycarroll edited as member
  • Jan 29 2019 16:10
    lhorie edited as member
  • Jan 29 2019 16:00
    isiahmeadows edited #2363
  • Jan 29 2019 15:59
    isiahmeadows opened #2363
  • Jan 29 2019 15:59
    isiahmeadows labeled #2363
  • Jan 29 2019 15:58

    isiahmeadows on isiahmeadows-patch-2

    Include both backers and sponso… (compare)

  • Jan 29 2019 15:48

    isiahmeadows on isiahmeadows-patch-2

    Mithril now accepts donations t… (compare)

  • Jan 29 2019 15:09
    isiahmeadows labeled #2362
  • Jan 29 2019 15:09
    isiahmeadows labeled #2362
  • Jan 29 2019 15:08
    isiahmeadows closed #2362
  • Jan 29 2019 15:08
    isiahmeadows commented #2362
  • Jan 28 2019 12:38
    dlepaux commented #2362
  • Jan 28 2019 12:32
    dlepaux commented #2362
Barney Carroll
@barneycarroll
I don't see how that follows
Claudia Meadows
@dead-claudia
@barneycarroll Sorry, I meant if they're rendering actual vnode children in the list items they're managing.
Barney Carroll
@barneycarroll
Yes, thanks! I:)
Claudia Meadows
@dead-claudia
@tivac Tried updating mithril@next to 2.0.0-rc.1, but ran into this build glitch.
Claudia Meadows
@dead-claudia
I ended up deploying it manually, so it's not really an issue. The deploy script really needs updated to publish prereleases to mithril@next, but I'm not 100% sure if Travis allows this logic.
Pat Cavit
@tivac
https://docs.travis-ci.com/user/deployment/npm/#tagging-releases
Claudia Meadows
@dead-claudia
I found it and have since updated our Travis scripts.
I'm using my tokens for npm now.
Pat Cavit
@tivac
Ok, just checked .travis.yml in next and didn't see it
Claudia Meadows
@dead-claudia
I instead dropped a condition to just not auto-release on pre-releases for now.
Pat Cavit
@tivac
:ok:
Claudia Meadows
@dead-claudia
BTW, after I get some reviews for MithrilJS/mithril.js#2286 and MithrilJS/mithril.js#2207, I'd like to cut another release candidate.
Claudia Meadows
@dead-claudia
That and also, a couple upcoming bug fix PRs. (One for the bundler to use terser instead of the unmaintained uglify-es and one to not mutate the parameters sent to m.request/m.jsonp.)
Barney Carroll
@barneycarroll
Good idea
I am deeply frustrated by tests friction in implement #2192
It's such a simple change but the DOM mocks and the way tests play fast and loose with vnode / DOM mock implementation are a huge barrier
I thought fine, I'll 'just' rewrite the tests involving DOM mocks and vnodes to instantiate them properly
But it turns out that's a monster task
Barney Carroll
@barneycarroll
Slowly fixing hundreds of tests with a mixture of judicious delete / iterative replacement / case by case tweaking
There is so much duplication and strange self-validating stuff in here, the cognitive burden is massive
I'm reminded of Pat's gripes throughout the years
Why are we maintaining so much of this stuff manually
Claudia Meadows
@dead-claudia

@/all I've currently got 4 PRs that I would like reviewed and (hopefully) accepted, then I'll cut a v2.0.0-rc.2:

I don't think any of these should be controversial.

Claudia Meadows
@dead-claudia

@/all This is looking more attractive by the day... MithrilJS/mithril.js#2223

We're so close to a v2 release, but there's just a few outstanding PRs and issues that need addressed, mostly PRs.

Barney Carroll
@barneycarroll
I agree
It would be good to have a few days where a bunch of us are on hand to resolve conversations in minutes rather than dragging them out over months, where one person's insight can save another from wasted days etc
Claudia Meadows
@dead-claudia
How does a day in early December sound?
Barney Carroll
@barneycarroll
Could be done?
Claudia Meadows
@dead-claudia
?
Barney Carroll
@barneycarroll
December is always so busy with various social obligations and I get depressed in the dead of winter... But there's not much we can do about this. It is the time it is!
Claudia Meadows
@dead-claudia
Fair enough. I considered next weekend or next week, but I wasn't sure if I could get @pygy, @StephanHoyer, and others on board in time.
Barney Carroll
@barneycarroll
I could do this weekend
TBH there's nothing stopping just us two doing one if it comes to that
Claudia Meadows
@dead-claudia
Eh, true.
I'd like to at least get @StephanHoyer on board.
Barney Carroll
@barneycarroll
Oh yeah definitely
I'm talking about an extra
As well as, not instead of
Claudia Meadows
@dead-claudia
Oh okay. I'd be game for that. FWIW, about 80% of it could just be done with us alone in a quick 1-2 day sprint.
Barney Carroll
@barneycarroll
:+1:
I agree, a lot of this is just focus, and two people can help each other focus.
The onbeforeremove bug though :grimacing:
Stephan Hoyer
@StephanHoyer
I'm in
Weekday would be fine
Claudia Meadows
@dead-claudia
Okay. You have any days in mind? (I'm open mostly whenever.)
Claudia Meadows
@dead-claudia
@StephanHoyer
Stephan Hoyer
@StephanHoyer
Same here
Claudia Meadows
@dead-claudia
@barneycarroll You have any days in mind for next week?
Barney Carroll
@barneycarroll
Monday to Wednesday work well for me
Claudia Meadows
@dead-claudia
So does Tuesday/Wednesday sound okay to you @StephanHoyer