Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
  • Jan 30 2019 15:26
    isiahmeadows commented #2363
  • Jan 30 2019 01:24
    panoply opened #2364
  • Jan 29 2019 23:50
    Bondifrench commented #2363
  • Jan 29 2019 22:17
    isiahmeadows commented #2363
  • Jan 29 2019 16:10
    tivac removed as member
  • Jan 29 2019 16:10
    tivac edited as member
  • Jan 29 2019 16:10
    pygy edited as member
  • Jan 29 2019 16:10
    barneycarroll edited as member
  • Jan 29 2019 16:10
    lhorie edited as member
  • Jan 29 2019 16:00
    isiahmeadows edited #2363
  • Jan 29 2019 15:59
    isiahmeadows opened #2363
  • Jan 29 2019 15:59
    isiahmeadows labeled #2363
  • Jan 29 2019 15:58

    isiahmeadows on isiahmeadows-patch-2

    Include both backers and sponso… (compare)

  • Jan 29 2019 15:48

    isiahmeadows on isiahmeadows-patch-2

    Mithril now accepts donations t… (compare)

  • Jan 29 2019 15:09
    isiahmeadows labeled #2362
  • Jan 29 2019 15:09
    isiahmeadows labeled #2362
  • Jan 29 2019 15:08
    isiahmeadows closed #2362
  • Jan 29 2019 15:08
    isiahmeadows commented #2362
  • Jan 28 2019 12:38
    dlepaux commented #2362
  • Jan 28 2019 12:32
    dlepaux commented #2362
Claudia Meadows
@dead-claudia
This message was deleted
Edit: I'm dumb...I put exactly the wrong time in my calendar...
I'll certainly be awake then. It's 1pm, not 8am... :smile:
I calculated off-hand it being 1pm, then forgot the time zone, so when I put it in my calendar, I put it as 13 GMT = 8 EST , not 18 GMT = 13 EST
Stephan Hoyer
@StephanHoyer
Just to be sure, we are talkting about now + 32,5h?
Claudia Meadows
@dead-claudia
This message was deleted
Yeah.
This message was deleted
I just screwed up my calendar and just realized I screwed it up...
:smile:
Good thing I caught it instead of waking up 8 in the morning when it's 3 in the morning now...
Claudia Meadows
@dead-claudia
Hello @StephanHoyer @barneycarroll!
Stephan Hoyer
@StephanHoyer
Give me 30 Min
Claudia Meadows
@dead-claudia
:+1:
Barney Carroll
@barneycarroll
Hey folks
Claudia Meadows
@dead-claudia
:wave:
Stephan Hoyer
@StephanHoyer
hi
sorry for the delay
Can you point me on some ticket that might be doable in 3-4h
Claudia Meadows
@dead-claudia
I think a few in this are. Also, a lot of PRs need reviewed, and that may take much of it.
Stephan Hoyer
@StephanHoyer
ok, I start reviewing
Claudia Meadows
@dead-claudia
Most of them might take 15 minutes tops.
Claudia Meadows
@dead-claudia

Also, if either of you want to take a crack at redoing MithrilJS/mithril.js#2149, it'll take more than a few hours, but it mostly boils down to this:

  • Personally, HTML comments > headers. It's easier to parse out (it's just /<!--\s+meta-description:\s+(.*?)\s+-->/.exec(source)[0]), and it doesn't render on GH.
  • About half of the descriptions have outstanding comments by @barneycarroll and/or @pygy, so those need addressed.

I'd more likely go with the PR itself if it weren't for the fact it basically stalled.

Barney Carroll
@barneycarroll
I'll be with you folks shortly
Claudia Meadows
@dead-claudia
:+1:
And after the PRs, I'd like to see how many of the open non-feature issues we can chunk through, and then maybe if we have time, we could move on to some of the smaller feature requests.
Claudia Meadows
@dead-claudia
@StephanHoyer BTW, just gave you write privileges.
Stephan Hoyer
@StephanHoyer
:thumbsup:
Claudia Meadows
@dead-claudia
@barneycarroll Could you take a look at MithrilJS/mithril.js#2250 I think that should hopefully be a little more down your wheelhouse since I know you've done some consulting work with designers and in other circles that might have experience with jQuery and/or Bootstrap.
Stephan Hoyer
@StephanHoyer
:+1:
Claudia Meadows
@dead-claudia
And just a quick second hot take on MithrilJS/mithril.js#1933: I see it as pointless and likely an architectural code smell. I think we should close it.
Stephan Hoyer
@StephanHoyer
No that I commented on most PR i'll try redo the meta-description thing
ok with that?
Claudia Meadows
@dead-claudia
Sure.
As long as it gets stripped out before it gets to the website, I'm good.
Claudia Meadows
@dead-claudia
@barneycarroll Something come up, I'm guessing?
Barney Carroll
@barneycarroll
Sorry folks, I'm back!
Claudia Meadows
@dead-claudia
:+1:
Stephan Hoyer
@StephanHoyer
the docs generator is pretty low level...
we might be better of using any decent static site generator :D
Claudia Meadows
@dead-claudia
@StephanHoyer What we have currently works, so I'm not exactly interested in mucking with it.
Stephan Hoyer
@StephanHoyer
no, I don't want to switch that either for now
Claudia Meadows
@dead-claudia
@barneycarroll Could you look at the issues I linked to in your direction?
Stephan Hoyer
@StephanHoyer
but @lhorie is the king of the not-invented-here-syndrome I guess
Claudia Meadows
@dead-claudia
@StephanHoyer I've done it, too.
I'd rather not use a sledgehammer when a hammer is sufficient.
NIH issues are things like the home-rolled bundler.
Stephan Hoyer
@StephanHoyer
Me too, but only for simple things that also need to be performant. A static site generator would be not of this kind for me
but, it's ok, it works
and it's extendable enough for the meta-description problem