Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
    Stefan Appelhoff
    @sappelhoff

    And now I am running into issues with the fetch_faces_data function ... reading it in depth for the first time, its logic seems to be broken as well :)

    https://github.com/mne-tools/mne-bids/blob/cc131ceaffe1a8ad2cb71492cbfbee00ded79ebd/mne_bids/datasets.py#L18-L59

    in particular, look at this:

        for subject_id in subject_ids:  # pragma: no cover
            src_url = ('http://openfmri.s3.amazonaws.com/tarballs/'
                       'ds117_R0.1.1_sub%03d_raw.tgz' % subject_id)
            tar_fname = op.join(data_path, repo + '.tgz')
            target_dir = op.join(data_path, repo)
            if not op.exists(target_dir):
                if not op.exists(tar_fname):
                    _fetch_file(url=src_url, file_name=tar_fname,
                                print_destination=True, resume=True, timeout=10.)
                tf = tarfile.open(tar_fname)
                print('Extracting files. This may take a while ...')
                tf.extractall(path=data_path)
                shutil.move(op.join(data_path, 'ds117'), target_dir)
                os.remove(tar_fname)

    if more than one subject is defined in subject_ids, this will have no impact ... because before downloading, there is always the check to only do that if target_dir does not yet exist.

    HOWEVER, target dir will always exist after the first subject has been downloaded.

    Stefan Appelhoff
    @sappelhoff
    the fix is here: mne-tools/mne-bids#262
    Mainak Jas
    @jasmainak
    Nice blog post! Last week now? Sprint to the finish line! 🏁
    Stefan Appelhoff
    @sappelhoff
    :runner:
    once these two get merged, I can complete the release:
    Mainak Jas
    @jasmainak
    @sappelhoff I would also suggest spending some time last week on general housekeeping of the study template code
    and make it clean so people can start using it
    Stefan Appelhoff
    @sappelhoff
    okay :-) let's see what I can get done
    Stefan Appelhoff
    @sappelhoff

    mne-bids 0.3 is released :rocket:

    Alexandre Gramfort
    @agramfort
    :beers:
    Stefan Appelhoff
    @sappelhoff

    Final Report: https://github.com/sappelhoff/gsoc2019/blob/master/FINAL_REPORT.md

    I prepared the final report already so that @agramfort and @jasmainak have a chance to read it before I submit.

    If you guys are okay with it, I'll make the evaluation soon

    If I should make some changes, please let me know :-)

    Mainak Jas
    @jasmainak
    looks good to me!
    @sappelhoff do you plan to do the fetcher before GSoC finishes? if there are small issues that can be taken up by new contributors, feel free to tag them in mne-bids and/or mne-study-template. I have some victims for the upcoming sprint :)
    Stefan Appelhoff
    @sappelhoff

    I have some victims for the upcoming sprint :)

    :heart_eyes:

    @sappelhoff do you plan to do the fetcher before GSoC finishes?

    I am a bit worried that it will not get finished ... and when my contract at the institute starts again, I will be expected to do lots of data recording and analysis instead of open source shenanigans :(

    so I keep doing other things instead, which is not helping the situation
    what do you think I should do?
    Alexandre Gramfort
    @agramfort
    whatever you want :)
    Mainak Jas
    @jasmainak
    am I the only one who cannot see the project boards?
    Eric Larson
    @larsoner
    @jasmainak you have admin access to the mne-study-template board
    (repo rather)
    I can see the project board with a single card on the panels
    Mainak Jas
    @jasmainak
    github_issue.png
    Ah finally figured it out ... it was the banner: "Learn Git and GitHub without any code!" that I had to close before I could see anything. I'm getting old ...
    Mainak Jas
    @jasmainak
    @sappelhoff do we have an issue to track the generalized fetcher for openneuro? Can this be added to a project board? Even if you start it and it's not finished I think it can be a good starting point for someone to take over ...
    I created this: https://github.com/orgs/mne-tools/projects/1 and I'm going to close the other project boards. So everything is in one place rather than being fragmented across different project boards
    Stefan Appelhoff
    @sappelhoff

    do we have an issue to track the generalized fetcher for openneuro? Can this be added to a project board? Even if you start it and it's not finished I think it can be a good starting point for someone to take over ...

    okay :+1:

    will add to the project board :+1:
    Stefan Appelhoff
    @sappelhoff

    Wednesday, 2019-08-31

    Stefan Appelhoff
    @sappelhoff
    gosh, the digitization is killing me already. why is this so tough?

    anyhow, I summarized the problem here: https://github.com/bids-standard/pyedf/issues/7#issuecomment-523960790

    and the following answer by Robert is also informative IMO

    Mainak Jas
    @jasmainak
    As I said in my email yesterday, the pain is real :) People developing the specification who don't work with software don't realize this
    but no pain, no gain ;)
    Mainak Jas
    @jasmainak
    @sappelhoff there is a lot of discussion and I've read it but haven't managed to quite wrap the issues around my head. Is it the case that MNE populates the dig points differently for different file formats = different units + coord systems which complicates things when you write the _electrodes.tsv file? Is there something that fundamentally stops you from writing the _electrodes.tsv file in whatever coordinate system that MNE stores things in? Sorry I am not an expert in dig stuff, probably not much of a help :)
    Alexandre Gramfort
    @agramfort
    @sappelhoff we can talk during the day quickly if you want. I can then update you with the vision about the dig refactoring with @massich
    Stefan Appelhoff
    @sappelhoff
    +1, I am available between 14:00 and 17:00 if that works for you --> else, you can also ping me on the relevant PRs and I can comment/review :-)
    Alexandre Gramfort
    @agramfort
    ping me on hangout whenever you want
    Joan Massich
    @massich
    any time !
    Mainak Jas
    @jasmainak
    I’m also awake 😁 Can be an observer to the discussion if it didn’t happen already
    Alexandre Gramfort
    @agramfort
    we jsut need stefan then ;)
    Alexandre Gramfort
    @agramfort
    ping @sappelhoff it's 2pm
    Mainak Jas
    @jasmainak
    Earlier is better for me too
    Stefan Appelhoff
    @sappelhoff
    ok
    which link?
    Alexandre Gramfort
    @agramfort
    ready stefan and mainak?
    Mainak Jas
    @jasmainak
    yes
    Stefan Appelhoff
    @sappelhoff
    yes