Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
  • 17:44
    juergba review_requested #4125
  • 17:44
    juergba review_requested #4125
  • 17:44
    juergba review_requested #4125
  • 17:15
    juergba labeled #4110
  • 17:15
    juergba labeled #4110
  • 17:15
    juergba unlabeled #4110
  • 17:15
    juergba labeled #4125
  • 17:15
    juergba labeled #4125
  • 17:15
    juergba labeled #4125
  • 17:15
    juergba milestoned #4125
  • 17:15
    juergba opened #4125
  • 17:15
    juergba assigned #4125
  • 16:51

    juergba on inspect-timeout

    fix: disable of timeout order o… additional test (compare)

  • 08:05
    juergba labeled #3895
  • 08:02
    juergba closed #4072
  • 08:02
    juergba labeled #4072
  • 08:02
    juergba unlabeled #4072
  • 07:37
    juergba closed #4124
  • 07:37
    juergba labeled #4124
  • 07:37
    juergba unlabeled #4124
Craig Taub
@craigtaub
@SheetJSDev From what I understand it's more a question of finding good uses for the pot. Aside from tooling
SheetJSDev
@SheetJSDev
who pays for the mochajs.org domain?
Craig Taub
@craigtaub
i believe @boneskull ?
Christopher Hiller
@boneskull
ojsf
though I paid for it in the past. the foundation owns it now
Craig Taub
@craigtaub
@juergba I just want to make sure we are on the same page. A couple of items were added to 7.0.0 milestone recently. I thought non-breaking should go in next?
Juerg B.
@juergba
@craigtaub yes, because IMO v7.0.0 should be next. First there are important PR's in v7.0.0 which finally should be published like dropping Node v6. Second the older the release/v6.2.x branch gets, the more conflicting gets the cherry-picking, eg. I can't tell you the implications when we release some PR's of my uncaughtException stuff now and the rest later ... It just gets too complicated and too risky (for me).
Juerg B.
@juergba
btw one of your merges has a terrible commit message, we should define how those messages should look like, when we have more time.
Craig Taub
@craigtaub

@juergba

important PR's in v7.0.0 which finally should be published

Yes that makes alot of sense. So lets aim to release 7 asap.

one of your merges has a terrible commit message

One of the recent doc updates? I thought they were both fine.

JeongHoon Byun (aka Outsider)
@outsideris
We should turn on sponsorship for mochajs/mocha#4097 .
Christopher Hiller
@boneskull
I think I agree with publishing v7
Juerg B.
@juergba
A part of our code base (eg. lib/cli) is linted based on ES6 (==ES2015). Those files are supposed to be not used by our browser part. Since we are dropping Node v6 with Mocha v7.0.0, I would like to upgrade from ES6 to ES2018 for those files, in order to use async/await. Default remains ES5 (=> IE11).
Any objections?
Peter Müller
@Munter
@juergba I'd love to see those changes happen
Juerg B.
@juergba

@Munter I'm unsure about the browserify process, regarding ignored files. We have three informations:

  • browser field in package.json
  • karma.config.js
  • the browserify script with its --ignore option

I have two questions:

  • are above informations redundant? or do we need them all?
  • why are the "lib/cli/*" files not ignored? error or intention?
Peter Müller
@Munter
Ugh. Forgot about browserify
Juerg B.
@juergba
@Munter could you review mochajs/mocha#4115, please?
I decided for ES2017 instead of ES2018, to be updated when we drop Node v8.
Craig Taub
@craigtaub
guys just to confirm, under trunk-based development the process is to branch off master for release branch release/v7.0.x and release that. No cherry-picking required. My assumption is we use this branch for future patches to 7.0.
This message was deleted
Craig Taub
@craigtaub
if anyone wants me to hold back on this let me know but sounds like we want v7 out asap.
Craig Taub
@craigtaub
@outsideris I just want to confirm something. There is a label on mochajs/mocha#3988 for landed-on-v6.2.x which doesnt seem right as we havnt released 6.2.3 yet (and mite opt for v7 instead). Can u confirm if ok to remove pls. Im starting on CHANGELOG for 7.
Juerg B.
@juergba
For release v7.0.0 its not necessary to create a release branch, since you are going to publish all commits (no cherry-picking). But your way does work as well.
re PR3988: I agree, label landed-on-v6.2.x should be removed.
Juerg B.
@juergba
@Munter thank you.
@craigtaub can I still merge to master?
Craig Taub
@craigtaub
@juergba yeah go for it. Made a start on release but likely be several days time earliest before actually do it
Juerg B.
@juergba
@craigtaub btw in github "Actions" you can customize a workflow "Publishes a Node.js package to npm". This could be worth having a look. Possibly even me (on Windows) could publish releases again.
Craig Taub
@craigtaub
@juergba yeah ive seen GH pushing it but not seen them used yet. Think i’ll focus on doing this one manually but defo put some energy after that into them. Could be a big time saver.
dhuang612
@dhuang612

Hi,

Sorry, I tried to update my last answer, but edit was grayed out.

I'm now running into a new error it doesn't matter which html template I am using for the browser tests I am now getting this error:

mocha.js:9 Uncaught ReferenceError: require is not defined
    at mocha.js:9

The two templates are under docs folder and browser folder
Here is the template I'm using:
https://gist.github.com/dhuang612/95e11562558d1f25c6a225659a76b5d7

I reviewed the contributing guidelines and it said if you are doing something browser based it's likely a change under bin / lib browser-entry.js

I am trying to get my html template to recognize my local version of mocha so that I can make changes to the way that the browser based tests display results.

I have tried using the mocha.js file under bin and lib and I get the same error either way. Need help figuring out how to get my local mocha app recognized on this template.

Thanks for any help provided!

Juerg B.
@juergba
@dhuang612 you have to use the bundled version of mocha.js, not the versions under bin and lib. We bundle with browserify, see "package-scripts.js".
Juerg B.
@juergba
btw the first question you should ask yourself is wether your PR makes sense at all (for Mocha). Sometimes I get the impression people want their PR's merged as they collect "likes" on facebook. Wether the PR makes sense (for Mocha), is of no interest.
Craig Taub
@craigtaub
@dhuang612 think u want nps build n point template to <script src="../../mocha.js">. Same for CSS file
Craig Taub
@craigtaub
FYI guys issue to look at GH actions mochajs/mocha#4117
dhuang612
@dhuang612

thanks @craigtaub and @juergba I'll try that.

As to your second comment Juerg, I'm trying to complete PR's to get a job.

Christopher Hiller
@boneskull
@juergba +1 on ES2018
@juergba @craigtaub I mentioned this in craig’s issue, but ideally everybody who is publishing has 2FA enabled on npm for publishing. afaik this means we can’t automate publishing from CI
@dhuang612 you will need to modify lib/reporters/html.js to change the reporter output, then run npm run build to build/bundle /mocha.js. load this file to see your changes
dhuang612
@dhuang612
@boneskull thank you!
JeongHoon Byun (aka Outsider)
@outsideris
@craigtaub Sorry for late response. I removed the label.
dhuang612
@dhuang612

Hi again,

I followed the instructions above for bundling together the root mocha.js file.

my steps were as followed:

under docs -> example -> tests.html

 <script src="../../mocha.js"></script>

under reporters -> html.js

I started with a simple change for proof of concept:

under statsTemplate variable changed failures -> failure

from the cli:

ran npm build ./
which completes without error

I then open tests.html in a chrome browser and still see the s at the end of failures under statsTemplate ul area?

changed this line under statsTemplate
'<li class="failures"><a href="javascript:void(0);">failure:</a> <em>0</em></li>' +
Christopher Hiller
@boneskull
afaik npm build does nothing
use nps build or npm start build
that will fix your problem ^ @dhuang612
dhuang612
@dhuang612
thank you @boneskull
Christopher Hiller
@boneskull
to that end we should probably alias the build script in package.json to nps build
just for convenience
dhuang612
@dhuang612
npm start build worked for me, thank you!
nps is executing `build` : browserify -e browser-entry.js --plugin ./scripts/dedefine --ignore 'fs' --ignore 'glob' --ignore 'path' --ignore 'supports-color' -o mocha.js
Juerg B.
@juergba
@Munter my last netlify build failed. Can you restart it, or should I re-push my PR?
Peter Müller
@Munter

@juergba Will do.

Yikes, that's not a good error for a CDN to send out

6:16:47 PM:   ---
6:16:47 PM:     operator: load
6:16:47 PM:     expected: "200 https://unpkg.com/mocha/mocha.css"
6:16:47 PM:     actual:   "HTTP 429 Too Many Requests"
6:16:47 PM:     at: docs/_site/example/tests.html:6:34 <link rel="stylesheet" href="https://unpkg.com/mocha/mocha.css">
6:16:47 PM:   ...
Juerg B.
@juergba
@Munter passed, thank you!