Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
  • Feb 26 23:12
    jbactual labeled #4590
  • Feb 26 23:12
    jbactual opened #4590
  • Feb 26 15:30
    RossVertizan labeled #4589
  • Feb 26 15:30
    RossVertizan opened #4589
  • Feb 26 08:44
    juergba closed #4586
  • Feb 26 08:44
    juergba labeled #4586
  • Feb 25 19:41
    nopeless edited #4588
  • Feb 25 19:35
    nopeless edited #4588
  • Feb 25 19:33
    nopeless edited #4588
  • Feb 25 19:31
    nopeless edited #4588
  • Feb 25 19:28
    nopeless edited #4588
  • Feb 25 19:25
    nopeless edited #4588
  • Feb 25 19:25
    nopeless edited #4588
  • Feb 25 19:24
    nopeless edited #4588
  • Feb 25 19:09
    nopeless edited #4588
  • Feb 25 19:07
    nopeless opened #4588
  • Feb 25 19:07
    nopeless labeled #4588
  • Feb 25 17:14
    saadisfy edited #4587
  • Feb 25 16:00
    saadisfy labeled #4587
  • Feb 25 16:00
    saadisfy opened #4587
Gil Tayar
@giltayar
Definitely!
I'll wait for @boneskull's thoughts on this. In the meantime, I'll add a PR to fix the first bug.
Juerg B.
@juergba
ok
Gil Tayar
@giltayar
@boneskull Added a bug to document the issue (and possible solutions) and discuss it over there: mochajs/mocha#4559.
Christopher Hiller
@boneskull
@giltayar for const {it} = require("mocha") to work as expected (wherever you expect it to work), I can only imagine a significant fundamental rearchitecturing
my recommendation is to.. not do that. Mocha just isn’t designed to work that way, even if you can get away with it sometimes
also: I’ve gotten word I’m going to be laid off. so I’m looking for new work. hopefully that work will allow me to continue work on Mocha. but can’t imagine it’d be as much as i’ve been working on it
I am still working with our designer and she has some nice mockups. I think you’ll be pleased
Gil Tayar
@giltayar
@boneskull sorry to hear that. Hope your next gig will let you continue to work on Mocha.
@boneskull am I the only one doing that (require-ing mocha to get at the functions)? I'm assuming not, because doing so makes it work so well with linters, TS, and others, without needing to change the configuration (which is the reason I'm doing it). In any case, given that it is documented, I believe we should fix the bug. And, yes, I agree that the best way to fix the bug is to change the test functions (e.g. it, before) to be static and not rely on the "PRE_REQUIRE" method. Are you sure doing that is a fundamental re-architecture-ing? Won't it just be a case of making the functions act on a "current" global mocha that is set whenever a new Mocha is instantiated?
Gil Tayar
@giltayar
I'd be glad to try and implement that change, or go the simpler route of implementing the parallelism a bit differently, as I outlined above.
Gil Tayar
@giltayar
Yesterday night I had an epiphany on how to solve the entry points problem, and I implemented it in the "ESM entry points" PR. The explanation can be found here: https://github.com/mochajs/mocha/issues/4559#issuecomment-766320556 and can be found in commit giltayar/mocha@9499f28 of the PR mochajs/mocha#4298.
Christopher Hiller
@boneskull
@giltayar thanks
haven’t read your PR yet, but, I mean, given that people do want to require/import mocha, I would be onboard with a rethinking of how we handle this. for example, if you wanted to use the tdd interface, you could import {test, suite} from ‘mocha/tdd’. mocha would always export it, describe, etc.
this seems way more sane than how it happens now
to be clear: I am not against people using mocha this way; it’s just that it was not really built to support it (and especially not in a static/ESM manner). it may be challenging to get right while still supporting “legacy” usage. (I am against doing away with the globals entirely, because it would break the internet)
@giltayar applitools hiring? :D
Gil Tayar
@giltayar
@boneskull Applitools is hiring, and they even have one remote developer in the US. Want me to check?
@boneskull about the require/import: what you proposed is exactly what I implemented in the PR. You can look at lib/entrypoints: there is CJS and ESM for each one of the interfaces.
@juergba At work I'm using Github Actions and Node v15, and I'm also getting the error with ERR_INVALID_ARG_TYPE around workerpool that we got in my PR (https://github.com/mochajs/mocha/runs/1822789163?check_suite_focus=true). Any chance we can publish a new Mocha version with this fix?
Juerg B.
@juergba
@giltayar no, I'm not planing to publish in short run, sorry. You should be fine with Node v15.7. though.
Gil Tayar
@giltayar
@juergba that worked, thanks! Now it can wait. :-)
Juerg B.
@juergba
👍
Juerg B.
@juergba
At npm mocha => Versions: lists the weekly downloads. There are still users downloading our nine years old versions. That's crazy.
Peter Müller
@Munter
Stable software is stable :)
Juerg B.
@juergba
Our page doesn't show any sponsors/backers anymore. Does anybody know the reason?
JeongHoon Byun (a.k.a Outsider)
@outsideris
Ooops! I will check it.
JeongHoon Byun (a.k.a Outsider)
@outsideris
I fixed it mochajs/mocha#4569
Juerg B.
@juergba
@outsideris thanks! I will review and merge.
Juerg B.
@juergba
I merged and pushed to master and to mochajs.org. The sponsors/backers don't show up on our page yet. Hope to see them tomorrow after nightly deploy action has run.
JeongHoon Byun (a.k.a Outsider)
@outsideris
Last night, I tracked it. It is not related to #4569 fix.
I couldn't find a root cause. So, I submit a temporary workaround mochajs/mocha#4570 because our mochajs.org is broken.
Juerg B.
@juergba
@outsideris thanks, I don't understand much of this topic.
@Munter could you have a look at above PR, please?
JeongHoon Byun (a.k.a Outsider)
@outsideris
The workaround just exclude codepiot.ai sponsor. So, we can show other sponsors and backers. And then we can fix it for codepiot.ai.
Nico Jansen
@nicojs
Hi guys! 👋 I'm back from a long break, sorry about that 🙄
@giltayar I've been taking a look as well, couldn't reproduce
@boneskull sorry to hear that! Did you find a new job? Hope you can keep up the awesome work
Juerg B.
@juergba
This invoice of Jaime King, he/she is a cheater, right? Stefanie Fluin is the correct one?
I will refuse this invoice, unless I get infos about this person.
Nico Jansen
@nicojs
People seem to want/expect events to also stream back to the main process in a parallel-mode situation. I've seen a couple of remarks like it, for example, #4560. @boneskull Do you think we can add a specific event for parallel tests that stream back to the main process?
Nico Jansen
@nicojs
Does someone want to review #4574? 😇
Nico Jansen
@nicojs
@giltayar I'm triggered by something in #4574. Is there a way to unload files loaded in node-js's esm cache? Similar to how you can use delete require.cache.foo in cjs land? I'm very interested in this, but couldn't find anything last time I checked.
Fun fact! I've seen you live on node conf in San Fransisco once, in the before-time
2 replies
Christopher Hiller
@boneskull
@nicojs it doesn’t seem to support it the way node does, or something
anyway sorry I’ve been out of pocket. this will continue for a bit, working on finding a job
1 reply
anyway, please see this https://xd.adobe.com/view/3ac17041-91ac-41f2-b577-a32ff7e0603f-6f92/ which should be a mock-up of the docs site. any feedback would be appreciated, if you feel like it
i am still meeting with our designer but not much else
things are in the works! thanks
Nico Jansen
@nicojs
Looks great! Minimalistic
I like that
but what happened to ☕?
How would this website be generated? I assume it's statically generated