Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
    Rob Mayer
    @RobMayer
    I know this is silly, but do you have an SVG logo for Modular-CSS for branding purposes?
    Pat Cavit
    @tivac
    Nope, no logo whatsoever
    Rob Mayer
    @RobMayer
    fair enough - like I said, I know it's silly, but I'm working on the template that gets spawned when you use create-react-app
    image.png
    Pat Cavit
    @tivac
    The little touches like that matter, I'm just not a logo designer and have never bothered to even consider a logo for modular-css
    Rob Mayer
    @RobMayer
    legit :)
    Pat Cavit
    @tivac
    Since it's mostly just a thing I built for myself because CSS Modules is a great idea with a crappy implementation
    Rob Mayer
    @RobMayer
    ^ amen
    fwiw, it was :external that sealed the deal for me, I use it all the time
    Pat Cavit
    @tivac
    I try to limit how often we use it but yeah, it's super valuable
    Rob Mayer
    @RobMayer
    if you ever do end up doing any kind of branding, I'll gladly add it to this here thingy :3
    Pat Cavit
    @tivac

    tivac/modular-css#633

    Just put up a RFC for an idea that we've kicked around multiple times, @inherits

    Rob Mayer
    @RobMayer
    FYI, it seems that the recent patch has broken something related to the @modular-css\processor\plugins\values*.js files
    const parser = require("../parsers/values.js"); -- it seems that "../parsers/values.js" doesn't exist?
    Rob Mayer
    @RobMayer
    should've tagged - sorry @tivac
    Pat Cavit
    @tivac
    :eyes:
    oh shit yeah the parsers folder is empty in the release
    that's bad
    Rob Mayer
    @RobMayer
    T_T!
    Pat Cavit
    @tivac
    I'll get a patch release fixing that out shortly, scary that travis succeeded but npm release was missing files
    Rob Mayer
    @RobMayer
    thanks for jumping on it - it's much appreciated
    Pat Cavit
    @tivac
    @modular-css/processor@24.2.2 looks correct
    Haven't tried installing locally yet though
    Rob Mayer
    @RobMayer
    cool cool - mmk - gimme 10 minutes and I'll see if it's working on my end
    "don't publish the .gitignore, dummy" - nearly spit out my coffee at that one
    Pat Cavit
    @tivac
    :)
    I forgot that npm reads a .gitignore if there's no .npmignore
    so when I was all "oh yeah let's add a .gitignore to that parsers directory because it's generated code we don't want in the git history"
    that was... dumb
    Rob Mayer
    @RobMayer
    @tivac just tried it out using the create-react-app fork. Works great. Thanks, chief!
    Pat Cavit
    @tivac
    Sorry for the borked release :-\
    Glad it's working now though
    Thiago Lagden
    @lagden
    Hey @tivac
    How can I set a parser?
    sugarss for example:
    // postcss.config.js
    
    'use strict'
    
    module.exports = ({file}) => ({
        parser: (file && file.extname === '.sss') ? 'sugarss' : false,
        plugins: {
            'postcss-easy-import': {},
            'postcss-mixins': {},
            'postcss-conditionals': {},
            'postcss-simple-vars': {},
            'postcss-nested': {},
            'autoprefixer': {}
        }
    })
    Pat Cavit
    @tivac
    I don't think that postcss option is exposed yet
    Should be though
    Sorry it took me a bit to see this
    @lagden would you be willing to file an issue for that?
    Thiago Lagden
    @lagden
    I had success in one setup that I done... I am using rollup + svelte
    I will create a issue. Tks @tivac
    Thiago Lagden
    @lagden
    // ...
    
    import css from '@modular-css/rollup'
    import pp from '@modular-css/svelte'
    import sugarss from 'sugarss'
    
    const {preprocess, processor} = pp({
        exportGlobals: true,
        before: [
            require('postcss-easy-import')({
                extensions: ['.sss', '.css']
            }),
            require('postcss-mixins'),
            require('postcss-conditionals'),
            require('postcss-simple-vars'),
            require('postcss-nested')
        ],
        postcss: {
            parser: sugarss
        }
    })
    
    // ...
    Thiago Lagden
    @lagden
    well... I create this demo using sugarss...
    Rob Mayer
    @RobMayer
    hey @tivac - is there any way to combine values pulled from another css files and !important?

    this doesn't seem to work:
    / main.css /
    @value * as colors from "../colors.css";
    .root:global(.state_disabled) {
    background: colors.Disabled_M0 !important;
    }

    nor does
    / colors.css /
    @value Disabled_M0: #5a5a5a !important;

    both methods, invididually or together don't seem to parse right
    Rob Mayer
    @RobMayer
    uncertain if this is intended - I know that !important kinda sucks...
    Pat Cavit
    @tivac
    @RobMayer can you provide a failing repl link?
    seems to work ok for me based on some quick tests