These are chat archives for mojotech/pioneer

8th
Aug 2014
Josh
@joshtombs
Aug 08 2014 13:38
look at how strange this is
Screen Shot 2014-08-08 at 9.38.31 AM.png
This message was deleted
clearly prevent-browser-reload isn't in any of the arguments
thats what jakes problem was yesterday
Josh
@joshtombs
Aug 08 2014 13:50
found the bug
!!!!!!!!
Sam Saccone
@samccone
Aug 08 2014 13:50
!
Josh
@joshtombs
Aug 08 2014 13:50
"false" resolves to true
Josh
@joshtombs
Aug 08 2014 14:16
@samccone how do i get rid of a stub?
for example i stubbed out a function in the tests before this one, how can i nullify that so i can get the real function after
Sam Saccone
@samccone
Aug 08 2014 14:17
.restore
Josh
@joshtombs
Aug 08 2014 14:17
actually
if its inside a different descirbe
does it still know about it
Josh
@joshtombs
Aug 08 2014 14:28
quick question, if i only want to do something once
that restore, where does it go
not "beforeeach"
Sam Saccone
@samccone
Aug 08 2014 14:29
in the it
Josh
@joshtombs
Aug 08 2014 14:29
okay
you're okay with a ton of unit tests right?
Sam Saccone
@samccone
Aug 08 2014 14:33
always
Josh
@joshtombs
Aug 08 2014 14:33
alright cool
Sam Saccone
@samccone
Aug 08 2014 14:33
:)
Josh
@joshtombs
Aug 08 2014 14:33
zero chance this doesnt work after all these :D
Sam Saccone
@samccone
Aug 08 2014 14:33
hhahaha
Josh
@joshtombs
Aug 08 2014 14:39
how about specifiying "should be greater than"
as opposed to .should.eql
sometimes i google
othertimes i just ask Sam
Josh
@joshtombs
Aug 08 2014 14:40
lol i didnt think we were using chai
expect()
wasnt registering
Sam Saccone
@samccone
Aug 08 2014 14:40
require it
like a baws
Josh
@joshtombs
Aug 08 2014 14:40
oh igggght
Sam Saccone
@samccone
Aug 08 2014 14:40
that is pronounced bauueeewss
Josh
@joshtombs
Aug 08 2014 14:57
mojotech/pioneer#146
okay i tested for basically every situation i could think of
Josh
@joshtombs
Aug 08 2014 15:26
@samccone updated that pr
Josh
@joshtombs
Aug 08 2014 15:36
lol @ your comment, i saw that and pushed up before you said that but you mustve had it open :P
Sam Saccone
@samccone
Aug 08 2014 15:36
hahah
Sam Saccone
@samccone
Aug 08 2014 17:31
.pioneer.json
--preventReload=true
change default prevent reload to false
Josh
@joshtombs
Aug 08 2014 17:50
mojotech/pioneer#147
boom
any luck contacting jpbros?
Sam Saccone
@samccone
Aug 08 2014 17:50
i think he is out for the day
Josh
@joshtombs
Aug 08 2014 17:51
okay thats fine
Sam Saccone
@samccone
Aug 08 2014 18:24
@joshtombs i am going to fix the marionette repo
and publish the iframe and marionette repos now
Josh
@joshtombs
Aug 08 2014 18:25
okay
haha woah, now im seeing how big this actually was
we did a lot in this release
Sam Saccone
@samccone
Aug 08 2014 18:29
yeah
tons
Sam Saccone
@samccone
Aug 08 2014 18:49
cool
ok time to do it :)
Josh
@joshtombs
Aug 08 2014 18:50
hit that big RELEASE button