These are chat archives for mojotech/pioneer

12th
Sep 2014
Taylor Gautier
@tsgautier
Sep 12 2014 05:30
I have a working @Pending
I wrote a few tests for it - I wanted to make sure the pending is working so I wrote a test that has a pending in it
I don't really know how to isolate the execution context so that the step doesn't actually become pending
so at the moment, all tests pass, but, because of the pending step, at the end you get a result which indicates 1 pending step (and one skipped step, since I put an intentionally failing step below the pending step, to prove it's not executed)
Not sure if that's an acceptable solution - it feels a bit hackish to me
I can go ahead and submit a pull request if you'd like to make a suggestion for a better approach
Sam Saccone
@samccone
Sep 12 2014 13:13
hey @tsgautier thanks for the PR!!!!!!!!!
looks great going to go over it in detail today
Taylor Gautier
@tsgautier
Sep 12 2014 14:24
no problem - I think I am being to clever in the implementation - looking it over after a few hours I think it might be better to not use _.partial - I don't think that adds anything and it makes it feel like it's needed, when it reality it's probably not
Sam Saccone
@samccone
Sep 12 2014 14:25
sure sure, I really appreciate it
it is great stuff