These are chat archives for mojotech/pioneer

17th
Oct 2014
Jarid Margolin
@jaridmargolin
Oct 17 2014 00:24
Added an issue a few hours ago if you are interested in following
mojotech/pioneer#274
Jarid Margolin
@jaridmargolin
Oct 17 2014 04:18
@samccone - Why have you created a getAttribute method that maps to getCssValue? What if there is a desire to get actual attributes from an element?
Jarid Margolin
@jaridmargolin
Oct 17 2014 04:24
Sam Saccone
@samccone
Oct 17 2014 15:15
;)
also per the driver…. @jaridmargolin
and the keys
i actually thought about this for a long time a few months ago
and adding more globals seemed pretty anti node
Dominik Guzei
@DominikGuzei
Oct 17 2014 22:59
there are two options: either make it easily configurable or go with an opinionated option and support it fullstack
Jarid Margolin
@jaridmargolin
Oct 17 2014 23:01
@samccone - Should selenium-webdriver be a peer dependency of pioneer then?
Dominik Guzei
@DominikGuzei
Oct 17 2014 23:01
pioneer seems pretty opinionated toward selenium-webdriver to me, so adding it to the global context is totally ok, not to say important
but maybe the biggest problem currently is: in the docs you say one can just use Driver.Key.ENTER but it doesn't work because its not exposed ;-)
Jarid Margolin
@jaridmargolin
Oct 17 2014 23:04
Maybe pass Driver into the module similar to how this is passed in? Similar to how grunt gets passed around for plugin creation
... just brainstorming
*this is not passed in, its the context... but idea is the same, pass Driver to the module as an argument
Dominik Guzei
@DominikGuzei
Oct 17 2014 23:07
@jaridmargolin its a one-liner, I answered your issue request at the pioneer github page. selenium-webdriver is already required in that file, so you basically only have to add it to the context @Driver = Driver and be done with it
Jarid Margolin
@jaridmargolin
Oct 17 2014 23:08
Implementation is easy enough... responding to @samccone regarding his concerns of passing more globals around
If he is not good with attaching the class on the environment instance.. at the very least I think pioneer should consider selenium-webdriver a peer dependency
This at least allows for it to be required in a module
btw... thanks for responding to the ticket
Dominik Guzei
@DominikGuzei
Oct 17 2014 23:11
yeah I know, but that's a hugely different viewpoint – Pioneer is in currently not very configurable, so keeping that very useful Driver reference out for now, only for a (eventual) future improvement seems strange to me.
yeah peer dependency would also work