These are chat archives for mojotech/pioneer

11th
May 2015
Jarid Margolin
@jaridmargolin
May 11 2015 19:42
@samccone - Updated to latest pioneer and all tests utilizing wait are now failing :/
Sam Saccone
@samccone
May 11 2015 19:42
oh no :|
what is the error?
Jarid Margolin
@jaridmargolin
May 11 2015 19:42
Digging deeper now. Have you ran into any issues?
Sam Saccone
@samccone
May 11 2015 19:42
no...
i know selenium slightly changed wait
Jarid Margolin
@jaridmargolin
May 11 2015 19:42
Error: Wait timed out after
Sam Saccone
@samccone
May 11 2015 19:42
to accept returning promises
Jarid Margolin
@jaridmargolin
May 11 2015 19:42
I'm hunting for the selenium changelog
Sam Saccone
@samccone
May 11 2015 19:43
oh yeah
easiest to go into node_modules
selenium
there is a .html changelog
but nothing should be breaking…..
Jarid Margolin
@jaridmargolin
May 11 2015 19:43
:thumbsup:
Sam Saccone
@samccone
May 11 2015 19:47
@jaridmargolin can i see your wait code?
Jarid Margolin
@jaridmargolin
May 11 2015 19:47
I was explicitly defining how long to wait
*wasn't
Sam Saccone
@samccone
May 11 2015 19:48
oh that might be why...
:P
Jarid Margolin
@jaridmargolin
May 11 2015 19:54
You are explicitly defining wait timeouts throughout your code?
Sam Saccone
@samccone
May 11 2015 19:55
yeah
driver.wait(func(){}, xxx)
Jarid Margolin
@jaridmargolin
May 11 2015 19:55
There are some places where I am dependent on the latency of network calls. I guess I can put a sizable timeout just in case
Docs state timeout is optional
Sam Saccone
@samccone
May 11 2015 19:56
for wait?
for selenium
Jarid Margolin
@jaridmargolin
May 11 2015 19:57
maybe not
nvm
Sam Saccone
@samccone
May 11 2015 19:57
:grimacing:
if opt_ prefix refers to option
Sam Saccone
@samccone
May 11 2015 19:58
hahaha
Jarid Margolin
@jaridmargolin
May 11 2015 19:58
I would assume options are optional
Sam Saccone
@samccone
May 11 2015 19:58
might be assuming too much
:P
Jarid Margolin
@jaridmargolin
May 11 2015 19:59
maybe but wait also defines an opt_message which is optional
and looking at other method signatures, opt_ seems like it would refer to optional arguments
if this is not the case, it would be helpful for the docs to state which params are required
Sam Saccone
@samccone
May 11 2015 20:00
well it looks like it is passed to wait
flow wait
and… something there might have changed
Jarid Margolin
@jaridmargolin
May 11 2015 20:03
it looks like it now accepts a promise or a "condition"
Sam Saccone
@samccone
May 11 2015 20:03
yep i read that
Jarid Margolin
@jaridmargolin
May 11 2015 20:03
For a webdriver.until.Condition or function, the wait will repeatedly evaluate the condition until it returns a truthy value. If any errors occur while evaluating the condition, they will be allowed to propagate. In the event a condition returns a promise, the polling loop will wait for it to be resolved and use the resolved value for whether the condition has been satisified. Note the resolution time for a promise is factored into whether a wait has timed out.
Sam Saccone
@samccone
May 11 2015 20:03
hmm