I used to spend almost 2h every day on the bus and travelling twice a month
@paualarco I accidentally pushed a commit: https://github.com/monix/monix-connect/blob/master/website/siteConfig.js
Actually it's this one: monix/monix-connect@eaf733e
It was meant to be a PR, but apparently I'm bad at using GitHub's interface.
will roll it back :P
In the settings file, it gives a warning that the
CNAME file doesn't have a correct format: https://github.com/monix/monix-connect/settings
This means the GitHub Pages haven't been deployed yet (an assumption).
I mean it's a proposal. If you don't like it you can revert.
API link is broken: https://connect.monix.io/api/monix/connect/index.html
Is the API published along with the website? As I'm not seeing it in
gh-pages: https://github.com/monix/monix-connect/tree/gh-pages
no, api docs are not there yet monix/monix-connect#149
have created monix/monix-connect#321 for bringing downloadMultipart, existsBucket, existsObject, copyObject and an enhanced listObjects operations, will leave it there for a couple of days :)
I found an issue in S3 adapter and thought I could make an easy fix and do a PR but I cannot get started, aws-auth does not compile ... getting
[error] ## Exception when compiling 6 sources to /home/thijs/repositories/monix-connect/aws-auth/target/scala-2.13/classes
[error] java.lang.StackOverflowError
[error] scala.tools.nsc.typechecker.Typers$Typer.typedBlock(Typers.scala:2571)
[error] scala.tools.nsc.typechecker.Typers$Typer.typedOutsidePatternMode$1(Typers.scala:5911)
[error] scala.tools.nsc.typechecker.Typers$Typer.typed1(Typers.scala:5946)
[error] scala.tools.nsc.typechecker.Typers$Typer.typed(Typers.scala:5993)
[error] scala.tools.nsc.typechecker.Typers$Typer.typedTyped$1(Typers.scala:5703)
[error] scala.tools.nsc.typechecker.Typers$Typer.typed1(Typers.scala:5939)
[error] scala.tools.nsc.typechecker.Typers$Typer.typed(Typers.scala:5993)
[error] scala.tools.nsc.typechecker.Macros$DefMacroExpander.$anonfun$onSuccess$1(Macros.scala:631)
[error] scala.tools.nsc.typechecker.Macros$DefMacroExpander.typecheck$1(Macros.scala:631)
[error] scala.tools.nsc.typechecker.Macros$DefMacroExpander.onSuccess(Macros.scala:643)
[error] scala.tools.nsc.typechecker.Macros$MacroExpander.$anonfun$expand$1(Macros.scala:582)
[error] scala.tools.nsc.Global.withInfoLevel(Global.scala:228)
wanted to adjust this:
def deleteObject(
bucket: String,
key: String,
bypassGovernanceRetention: Option[Boolean] = None,
mfa: Option[String] = None,
requestPayer: Option[String] = None,
versionId: Option[String] = None)(implicit s3AsyncClient: S3AsyncClient): Task[DeleteObjectResponse] = {
val request: DeleteObjectRequest =
S3RequestBuilder.deleteObject(bucket, key, bypassGovernanceRetention, mfa, requestPayer, versionId)
S3RequestBuilder.deleteObject(bucket, key, bypassGovernanceRetention, mfa, requestPayer, versionId)
deleteObject(request)
}into
def deleteObject(
bucket: String,
key: String,
bypassGovernanceRetention: Option[Boolean] = None,
mfa: Option[String] = None,
requestPayer: Option[String] = None,
versionId: Option[String] = None): Task[DeleteObjectResponse] = {
val request: DeleteObjectRequest =
S3RequestBuilder.deleteObject(bucket, key, bypassGovernanceRetention, mfa, requestPayer, versionId)
deleteObject(request)
}
compiling that submodule should be fine, maybe that's something to do with your local config? have seen a similar where it seems like they fixed it by increasing -Xss8m.
regarding the change ... notice that I also removed the implicit s3-client as it is already part of the S3 trait and was not used by the method implementation
maybe first try just compiling the
aws-auth subproject?
sbt -mem 2048 aws-auth/compile
didn't find this tip in the monix-connect documentation :P
Hi guys!
I've just found this library and it's a nice piece of work! I have several ideas for improvement though - it might be better to discuss it here than in GH issue I guess... Everything is related to S3 connector as it's what I want to use.
- It'd be great if there's a factory method taking already parsed
MonixAwsConfso one can fill it manually (or parse it, whatever) and not has to usefromConfig. - It'd be great if pureconfig readers are configurable regarding casing. We're used to have camelCase and existing readers for your case classes are kebab-case only.
- It'd be great if
fromConfigtakes aConfigSourceso users are not forced to have the configuration in a hardcoded place (root, in this case). - Why are config classes (e.g.
MonixAwsConf) private? :-D - I'd love to see
offsetorrangeparameter in thedownloadMultipartmethod - we need to be able to resume download of a big file and that is currently not possible.
So, what do you think? I'm willing to help implementing these changes, I just want your approval first so I don't waste my time :-D
Thanks!
Hi @jendakol
Appreciate the feedback! :D I basically agree in all the points you have raised and would be happy to adopt them.
I was already aware of 1 and 2 , though I have had no time to address it, yet.
In response to 4, it is private because the current signatures does not allow to overwrite nor read it, so we will make it public access if that changes.
We could create issues to keep track of them, would you be interested in contributing to those?
Appreciate the feedback! :D I basically agree in all the points you have raised and would be happy to adopt them.
I was already aware of 1 and 2 , though I have had no time to address it, yet.
In response to 4, it is private because the current signatures does not allow to overwrite nor read it, so we will make it public access if that changes.
We could create issues to keep track of them, would you be interested in contributing to those?
@jendakol have addressed 1, 2 and 3, 4 in monix/monix-connect#685, would appreciate your review/feedback if you have time :)